mbox series

[v1,0/2] gpiolib: acpi: A couple of error checks amendmends

Message ID 20240410202243.1658129-1-andriy.shevchenko@linux.intel.com
Headers show
Series gpiolib: acpi: A couple of error checks amendmends | expand

Message

Andy Shevchenko April 10, 2024, 8:21 p.m. UTC 
One error check is moved and one is dropped.
No functional changes intended.

Andy Shevchenko (2):
  gpiolib: acpi: Remove never true check in acpi_get_gpiod_by_index()
  gpiolib: acpi: Check for errors first in acpi_find_gpio()

 drivers/gpio/gpiolib-acpi.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Mika Westerberg April 11, 2024, 1:28 p.m. UTC | #1 
On Wed, Apr 10, 2024 at 11:21:45PM +0300, Andy Shevchenko wrote:
> One error check is moved and one is dropped.
> No functional changes intended.
> 
> Andy Shevchenko (2):
>   gpiolib: acpi: Remove never true check in acpi_get_gpiod_by_index()
>   gpiolib: acpi: Check for errors first in acpi_find_gpio()

Both,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Andy Shevchenko April 11, 2024, 1:37 p.m. UTC | #2 
On Thu, Apr 11, 2024 at 04:28:06PM +0300, Mika Westerberg wrote:
> On Wed, Apr 10, 2024 at 11:21:45PM +0300, Andy Shevchenko wrote:
> > One error check is moved and one is dropped.
> > No functional changes intended.
> > 
> > Andy Shevchenko (2):
> >   gpiolib: acpi: Remove never true check in acpi_get_gpiod_by_index()
> >   gpiolib: acpi: Check for errors first in acpi_find_gpio()
> 
> Both,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!