mbox series

[V2,0/3] Add pinctrl driver support for Amlogic T7 SoCs

Message ID 20230921083407.1167510-2-huqiang.qin@amlogic.com
Headers show
Series Add pinctrl driver support for Amlogic T7 SoCs | expand

Message

Huqiang Qin Sept. 21, 2023, 8:34 a.m. UTC 
This patch adds pinctrl driver support for Amloigc T7 SoC (A311D2)

[PATCH 1/3]: 
  V1 -> V2: Rename amlogic-t7-gpio.h to amlogic,t7-periphs-pinctrl.h

[PATCH 2/3]:
  V1 -> V2: Include header file changed to amlogic,t7-periphs-pinctrl.h

[PATCH 3/3]:
  V1 -> V2: Unchanged.

Huqiang Qin (3):
  dt-bindings: pinctrl: Add compatibles for Amlogic T7 SoCs
  pinctrl: Add driver support for Amlogic T7 SoCs
  arm64: dts: Add pinctrl node for Amlogic T7 SoCs

 .../pinctrl/amlogic,meson-pinctrl-a1.yaml     |    1 +
 arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi   |   16 +
 drivers/pinctrl/meson/Kconfig                 |    6 +
 drivers/pinctrl/meson/Makefile                |    1 +
 drivers/pinctrl/meson/pinctrl-amlogic-t7.c    | 1612 +++++++++++++++++
 .../gpio/amlogic,t7-periphs-pinctrl.h         |  179 ++
 6 files changed, 1815 insertions(+)
 create mode 100644 drivers/pinctrl/meson/pinctrl-amlogic-t7.c
 create mode 100644 include/dt-bindings/gpio/amlogic,t7-periphs-pinctrl.h


base-commit: e143016b56ecb0fcda5bb6026b0a25fe55274f56

Comments

Huqiang Qin Sept. 21, 2023, 9:43 a.m. UTC | #1 
Hi Conor,

On 2023/9/21 17:19, Conor Dooley wrote:
> I'd argue that "Add support for" would be a better $subject for the
> changes here though given that there is only one compatible and you've
> added a bunch of new definitions.

Thank you for your suggestion, I will do this for future commits.

Best regards,
Huqiang Qin
Andy Shevchenko Sept. 21, 2023, 10 a.m. UTC | #2 
On Thu, Sep 21, 2023 at 04:34:07PM +0800, Huqiang Qin wrote:
> Add a new pinctrl driver for Amlogic T7 SoCs which share
> the same register layout as the previous Amlogic S4.

...

> +static const char * const uart_ao_a_groups[] = {
> +	"uart_ao_a_rx_c", "uart_ao_a_tx_c", "uart_ao_a_tx_w2",
> +	"uart_ao_a_rx_w3", "uart_ao_a_tx_w6", "uart_ao_a_rx_w7",
> +	"uart_ao_a_tx_w10", "uart_ao_a_rx_w11", "uart_ao_a_tx_d0",
> +	"uart_ao_a_rx_d1",

> +

Redundant blank line.

> +};

With that fixed,
Reviewed-by: Andy Shevchenko <andy@kernel.org>