mbox series

[libgpiod,0/2] minor build warning fixes

Message ID 20230629101455.127795-1-warthog618@gmail.com
Headers show
Series minor build warning fixes | expand

Message

Kent Gibson June 29, 2023, 10:14 a.m. UTC 
Fixes for a couple of minor warnings reported when building with a fresh
OS install.
The first fixes another typo in the examples makefile.
The second fixes another warning that is emitted by recent rust.

I note that with a fresh/minimal OS install the rust bindings still fail
to build due to a missing dependency on libclang and clang headers, but
that isn't tested for by configure - it fails during the build.

Kent Gibson (2):
  examples: fix typo in Makefile.am
  bindings: rust: fix unclear resolver warning

 bindings/rust/Cargo.toml | 2 ++
 examples/Makefile.am     | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

Comments

Bartosz Golaszewski June 30, 2023, noon UTC | #1 
On Thu, Jun 29, 2023 at 12:15 PM Kent Gibson <warthog618@gmail.com> wrote:
>
> The trailing "s" is missing from "toggle_multiple_line_values" in
> several places, so add it.
>
> Signed-off-by: Kent Gibson <warthog618@gmail.com>
> ---
>  examples/Makefile.am | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/examples/Makefile.am b/examples/Makefile.am
> index daf902b..e92f303 100644
> --- a/examples/Makefile.am
> +++ b/examples/Makefile.am
> @@ -37,7 +37,7 @@ reconfigure_input_to_output_SOURCES = reconfigure_input_to_output.c
>
>  toggle_line_value_SOURCES = toggle_line_value.c
>
> -toggle_multiple_line_value_SOURCES = toggle_multiple_line_value.c
> +toggle_multiple_line_values_SOURCES = toggle_multiple_line_values.c
>
>  watch_line_info_SOURCES = watch_line_info.c
>
> --
> 2.41.0
>

I'm wondering if we should just drop these as autotools will default
to using a single source file named after the target executable if
foobar_SOURCES is not defined. (iow: if the target is foobar and no
foobar_SOURCES is defined, then it will try foobar.c).

Bart