mbox series

[0/2] pinctrl-amd debugfs improvements

Message ID 20230328174231.8924-1-mario.limonciello@amd.com
Headers show
Series pinctrl-amd debugfs improvements | expand

Message

Mario Limonciello March 28, 2023, 5:42 p.m. UTC
Debugging an issue recently of poor residency in a low power state
concluded it was caused by GPIO controller misprogrammed in BIOS.

What happened was _CRS was missing a configuration but device was
trying to assert an interrupt.  This is found by interrupt status
bit which isn't currently covered in debug output.

Add this and also the similar wake status bit to debug output.
As the display is very busy and growing long again with so much info,
adjust the display to only render characters for relevant bits
and to now use headers for each GPIO bank.

New sample output, including demonstrating detection of
BIOS issue (by 🔥):

gpio	  int|active|trigger|S0i3| S3|S4/S5| Z|wake|pull|  orient|       debounce|reg
#0	   😛|     ↑|   edge|  ⏰| ⏰|     |⏰|    |4k ↑|input  ↑|b (🕑 046875us)|0x81578e3
#1	    ∅|      |       |    |   |     |  |    |4k ↑|input  ↑|               |0x150000
#2	   😛|     ↓|   edge|  ⏰| ⏰|     |  |    |4k ↑|input  ↑|               |0x157a00
#3	   😛|     ↓|   edge|  ⏰| ⏰|     |  |    |4k ↑|input  ↑|               |0x157a00
#4	    ∅|      |       |    |   |     |  |    |4k ↑|input  ↑|               |0x150000
#5	    ∅|      |       |    |   |     |  |    |4k ↑|input  ↑|               |0x150000
#6	   😷|     ↓|  level|    |   |     |⏰|    |4k ↑|input  ↑|               |0x8150b00
#7	    ∅|      |       |    |   |     |  |    |4k ↑|input  ↑|               |0x150200
#8	🔥 😷|     ↓|  level|    |   |     |⏰|    |4k ↑|input  ↓|               |0x18140b00

Mario Limonciello (2):
  pinctrl: amd: Adjust debugfs output
  pinctrl: amd: Add fields for interrupt status and wake status

 drivers/pinctrl/pinctrl-amd.c | 90 +++++++++++++++++------------------
 1 file changed, 44 insertions(+), 46 deletions(-)