| Message ID | 20230327-cleanup-pinctrl-binding-v1-0-b695e32e4f2e@baylibre.com |
|---|---|
| Headers | show |
| Series | Cleanup Mediatek pinctrl device tree binding | expand |
On 28/03/2023 15:41, AngeloGioacchino Del Regno wrote: > Il 28/03/23 15:06, Alexandre Mergnat ha scritto: >> Deprecate mediatek,drive-strength-adv which shall not exist, that was an >> unnecessary property that leaked upstream from downstream kernels and >> there's no reason to use it. >> >> The generic property drive-strength-microamp should be used instead. >> >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> >> --- >> .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- >> .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- >> 2 files changed, 11 insertions(+), 3 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml >> index c30cd0d010dd..b82a066b91ec 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > > Thanks for doing MT8183!!! > >> @@ -110,8 +110,13 @@ patternProperties: >> drive-strength: > > ..snip.. > >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> index 4b96884a1afc..347f533776ba 100644 >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml >> @@ -91,8 +91,13 @@ patternProperties: >> >> input-schmitt-disable: true >> >> + drive-strength-microamp: >> + enum: [125, 250, 500, 1000] >> + >> mediatek,drive-strength-adv: >> + deprecated: true > > In the case of MT8365, since there's *no* devicetree using this property, *at all*, > I think you can even just entirely remove this block, as that should not be > considered an ABI breakage in that case. > > Krzysztof, can you please confirm? If it is defined as ABI in a released kernel, then should be rather deprecated. Best regards, Krzysztof
On Wed, Mar 29, 2023 at 09:58:57AM +0200, Krzysztof Kozlowski wrote: > On 28/03/2023 15:41, AngeloGioacchino Del Regno wrote: > > Il 28/03/23 15:06, Alexandre Mergnat ha scritto: > >> Deprecate mediatek,drive-strength-adv which shall not exist, that was an > >> unnecessary property that leaked upstream from downstream kernels and > >> there's no reason to use it. > >> > >> The generic property drive-strength-microamp should be used instead. > >> > >> Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> > >> --- > >> .../devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 ++++++-- > >> .../devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 6 +++++- > >> 2 files changed, 11 insertions(+), 3 deletions(-) > >> > >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > >> index c30cd0d010dd..b82a066b91ec 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8183-pinctrl.yaml > > > > Thanks for doing MT8183!!! > > > >> @@ -110,8 +110,13 @@ patternProperties: > >> drive-strength: > > > > ..snip.. > > > >> diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > >> index 4b96884a1afc..347f533776ba 100644 > >> --- a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > >> +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8365-pinctrl.yaml > >> @@ -91,8 +91,13 @@ patternProperties: > >> > >> input-schmitt-disable: true > >> > >> + drive-strength-microamp: > >> + enum: [125, 250, 500, 1000] > >> + > >> mediatek,drive-strength-adv: > >> + deprecated: true > > > > In the case of MT8365, since there's *no* devicetree using this property, *at all*, > > I think you can even just entirely remove this block, as that should not be > > considered an ABI breakage in that case. > > > > Krzysztof, can you please confirm? > > If it is defined as ABI in a released kernel, then should be rather > deprecated. Yes, but if no one notices it's not an ABI. It's up to the platform maintainers really. I only care that the commits indicate they know what they are doing (usually not). Rob
Deprecate properties which shall not exist, leaked upstream from downstream kernels, there's no reason to use them. Here the deprecated properties and the generic properties which will replace them: - mediatek,drive-strength-adv => drive-strength-microamp - mediatek,pull-up-adv => bias-pull-up - mediatek,pull-down-adv => bias-pull-down Thanks AngeloGioacchino Del Regno to reported it. [1] [1]: https://lore.kernel.org/all/6e08d78f-ef4c-b228-f7d2-d63767ea87b8@collabora.com/ Signed-off-by: Alexandre Mergnat <amergnat@baylibre.com> --- Alexandre Mergnat (2): dt-bindings: pinctrl: mediatek: deprecate custom drive strength property dt-bindings: pinctrl: mediatek: deprecate custom bias pull properties for mt8365 .../bindings/pinctrl/mediatek,mt8183-pinctrl.yaml | 8 +++-- .../bindings/pinctrl/mediatek,mt8365-pinctrl.yaml | 38 +++++++++++++++++++--- 2 files changed, 39 insertions(+), 7 deletions(-) --- base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6 change-id: 20230327-cleanup-pinctrl-binding-8064a8f8bf68 Best regards,