| Message ID | 20221016170035.35014-1-krzysztof.kozlowski@linaro.org |
|---|---|
| Headers | show |
| Series | pinctrl/arm64: qcom: continued - fix Qualcomm TLMM pinctrl schema warnings (third set) | expand |
On Sun, 16 Oct 2022 13:00:08 -0400, Krzysztof Kozlowski wrote: > Certain pins, like SDcard related, do not have functions and such should > not be required. Add a check for this in common Qualcomm TLMM pin > controller schema. > > Applied, thanks! [07/34] dt-bindings: pinctrl: qcom,tlmm-common: add common check for function https://git.kernel.org/krzk/linux-dt/c/1b88672e7fd9f83f3a6f507747dc95b8a4d40f4b Best regards,
On Sun, 16 Oct 2022 13:00:09 -0400, Krzysztof Kozlowski wrote: > The IPQ6018 pinctrl driver supports qpic_pad and DTS already uses it: > > 'qpic_pad' is not one of ['adsp_ext', 'alsp_int', 'atest_bbrx0', ... > > Applied, thanks! [08/34] dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function https://git.kernel.org/krzk/linux-dt/c/6664924176497c40f20380eae298241e3b175217 Best regards,
On Sun, 16 Oct 2022 13:00:11 -0400, Krzysztof Kozlowski wrote: > One pinxmux node can have more than 4 pins to configure: > > ['gpio1', 'gpio3', 'gpio4', 'gpio5', 'gpio6', 'gpio7', 'gpio8', 'gpio10', 'gpio11', 'gpio12', 'gpio13', 'gpio14', 'gpio15', 'gpio17'] is too long > > Applied, thanks! [10/34] dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux https://git.kernel.org/krzk/linux-dt/c/5cf95fcd6d75375195d15cabfaed835e76eec4c1 Best regards,
On Sun, 16 Oct 2022 13:00:14 -0400, Krzysztof Kozlowski wrote: > Bindings example should be indented with 4-spaces. > > Applied, thanks! [13/34] dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example https://git.kernel.org/krzk/linux-dt/c/4c05adcaa6054a2a6f229b1598615028816aad19 Best regards,
On Sun, 16 Oct 2022 13:00:16 -0400, Krzysztof Kozlowski wrote: > Reference common Qualcomm TLMM pin controller schema, to bring common > properties, other pinctrl schemas and additional checks, like function > required only for GPIOs. > > Applied, thanks! [15/34] dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema https://git.kernel.org/krzk/linux-dt/c/4799452e1823c6c9ca8b05d47e116871b0c5921f Best regards,
On Sun, 16 Oct 2022 13:00:18 -0400, Krzysztof Kozlowski wrote: > Bindings example should be indented with 4-spaces. > > Applied, thanks! [17/34] dt-bindings: pinctrl: qcom,msm8226: fix indentation in example https://git.kernel.org/krzk/linux-dt/c/1780bac7c11c341f99ab10a83ede9e96464c5f91 Best regards,
On Sun, 16 Oct 2022 13:00:20 -0400, Krzysztof Kozlowski wrote: > Certain pins, like SDcard related, do not have functions and such should > not be required. > > Applied, thanks! [19/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs https://git.kernel.org/krzk/linux-dt/c/0ec9c96fdaab2ee920bf58747af78e0f98697bb3 Best regards,
On Sun, 16 Oct 2022 13:00:21 -0400, Krzysztof Kozlowski wrote: > Bindings example should be indented with 4-spaces. > > Applied, thanks! [20/34] dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example https://git.kernel.org/krzk/linux-dt/c/6471d94807c33b9c2f0d806ee0d78b984626a819 Best regards,
On Sun, 16 Oct 2022 13:00:22 -0400, Krzysztof Kozlowski wrote: > The TLMM pin controller follows generic pin-controller bindings, so > should have subnodes with '-state' and '-pins'. Otherwise the subnodes > (level one and two) are not properly matched. This method also unifies > the bindings with other Qualcomm TLMM and LPASS pinctrl bindings. > > Applied, thanks! [21/34] dt-bindings: pinctrl: qcom,msm8953: fix matching pin config https://git.kernel.org/krzk/linux-dt/c/ce4762ae0228024961d70a38631cc9177f7f8818 Best regards,
On Sun, 16 Oct 2022 13:00:24 -0400, Krzysztof Kozlowski wrote: > Bindings example should be indented with 4-spaces. > > Applied, thanks! [23/34] dt-bindings: pinctrl: qcom,msm8953: fix indentation in example https://git.kernel.org/krzk/linux-dt/c/479cc0adcd7412815962b9bf69f4288f79cfd18e Best regards,
On Sun, 16 Oct 2022 13:00:27 -0400, Krzysztof Kozlowski wrote: > The TLMM pin controller follows generic pin-controller bindings, so > should have subnodes with '-state' and '-pins'. Otherwise the subnodes > (level one and two) are not properly matched. This method also unifies > the bindings with other Qualcomm TLMM and LPASS pinctrl bindings. > > Applied, thanks! [26/34] dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config https://git.kernel.org/krzk/linux-dt/c/7d3da666f2c0f9416f6d1a2c436b87a6d9f61e79 Best regards,
On Sun, 16 Oct 2022 13:00:30 -0400, Krzysztof Kozlowski wrote: > Reference common Qualcomm TLMM pin controller schema, to bring common > properties, other pinctrl schemas and additional checks, like function > required only for GPIOs. > > Applied, thanks! [29/34] dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema https://git.kernel.org/krzk/linux-dt/c/fd583a4f6db479a8e3f4ed3390b1cc3c258ace63 Best regards,
On Sun, 16 Oct 2022 13:00:31 -0400, Krzysztof Kozlowski wrote: > Bindings example should be indented with 4-spaces. > > Applied, thanks! [30/34] dt-bindings: pinctrl: qcom,sdx55: fix indentation in example https://git.kernel.org/krzk/linux-dt/c/4e0434d4788be2cbb44ce1918ac492c1fd6c195b Best regards,
On Sun, 16 Oct 2022 13:00:33 -0400, Krzysztof Kozlowski wrote: > Reference common Qualcomm TLMM pin controller schema, to bring common > properties, other pinctrl schemas and additional checks, like function > required only for GPIOs. > > Applied, thanks! [32/34] dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema https://git.kernel.org/krzk/linux-dt/c/7947f01598418c999be7a5cf0371221bdacd1721 Best regards,
On Sun, 16 Oct 2022 13:00:01 -0400, Krzysztof Kozlowski wrote: > Changes since v4 > ================ > 1. Drop drive-strength (included by common TLMM node). > > Changes since v3 > ================ > 1. All patches with subject: "use common TLMM schema": > Drop properties and required items which are already provided by common TLMM > schema. > The change against v3 is non-trivial, however I retained reviewed-by tags. > 2. Add Rb tags. > > [...] Applied, thanks! [03/34] ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl commit: 0139f183bcddcf5b36f805254bb0f0625963f783 [04/34] ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema commit: bda79af488a3e75769433fb961800c39bb07b29c [05/34] ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema commit: df9c86025510c45a6d90669347129e8000e1bbbc [06/34] ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema commit: 6cd72414abc7345e277fcab5e1c763c3a017dc6a Best regards,
Hi, Changes since v4 ================ 1. Drop drive-strength (included by common TLMM node). Changes since v3 ================ 1. All patches with subject: "use common TLMM schema": Drop properties and required items which are already provided by common TLMM schema. The change against v3 is non-trivial, however I retained reviewed-by tags. 2. Add Rb tags. Changes since v2 ================ 1. ipq6018-cp01-c1: do not switch to blsp1 (Robert). 2. pinctrl: qcom,ipq6018: correct BLSP6->BLSP0 functions: new patch. 3. Drop quotes from $ref when not needed (Rob). 4. Add Rb tags. Few patches from v1 got review from Rob, but I changed them in v2 significantly, so I did not keep these Rb tags. Changes since v1 ================ v1: https://lore.kernel.org/linux-devicetree/20220924080459.13084-1-krzysztof.kozlowski@linaro.org/T/#t 1. As Stephan suggested, move check for function on non-GPIO pins to common TLMM schema. This affects few commits in the set named: "use common TLMM schema" "do not require function on non-GPIOs" Overview ======== This is the third, independent patchset around Qualcomm pinctrl in recent days: 1. First round of TLMM fixes: merged 2. LPASS fixes: https://lore.kernel.org/linux-devicetree/20220927153429.55365-1-krzysztof.kozlowski@linaro.org/T/#t 3. ARMv7 TLMM fixes: *THIS PATCHSET* 4. ARMv8 remaining TLMM fixes: https://lore.kernel.org/linux-devicetree/20220930192954.242546-1-krzysztof.kozlowski@linaro.org/ 5. Fifth clean - styles and using common TLMM schema: https://lore.kernel.org/linux-arm-msm/20221011172358.69043-1-krzysztof.kozlowski@linaro.org/T/#m277d25a5f3e9d10ca8221a7fba62ca468a67a60b Dependencies ============ 1. No dependencies. 2. dt-bindings are independent of DTS patches. Best regards, Krzysztof Krzysztof Kozlowski (34): arm64: dts: qcom: ipq6018-cp01-c1: use BLSPI1 pins arm64: dts: qcom: ipq6018: align TLMM pin configuration with DT schema ARM: dts: qcom: sdx55: add gpio-ranges to TLMM pinctrl ARM: dts: qcom: sdx55: align TLMM pin configuration with DT schema ARM: dts: qcom: msm8226: align TLMM pin configuration with DT schema ARM: dts: qcom: msm8974: align TLMM pin configuration with DT schema dt-bindings: pinctrl: qcom,tlmm-common: add common check for function dt-bindings: pinctrl: qcom,ipq6018: add qpic_pad function dt-bindings: pinctrl: qcom,ipq6018: correct BLSP6->BLSP0 functions dt-bindings: pinctrl: qcom,ipq6018: increase number of pins in pinmux dt-bindings: pinctrl: qcom,ipq6018: fix matching pin config dt-bindings: pinctrl: qcom,ipq6018: use common TLMM schema dt-bindings: pinctrl: qcom,ipq6018: fix indentation in example dt-bindings: pinctrl: qcom,msm8226: fix matching pin config dt-bindings: pinctrl: qcom,msm8226: use common TLMM schema dt-bindings: pinctrl: qcom,msm8226: add functions and input-enable dt-bindings: pinctrl: qcom,msm8226: fix indentation in example dt-bindings: pinctrl: qcom,msm8909-tlmm: fix matching pin config dt-bindings: pinctrl: qcom,msm8909-tlmm: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,msm8909-tlmm: fix indentation in example dt-bindings: pinctrl: qcom,msm8953: fix matching pin config dt-bindings: pinctrl: qcom,msm8953: use common TLMM schema dt-bindings: pinctrl: qcom,msm8953: fix indentation in example dt-bindings: pinctrl: qcom,mdm9607: do not require function on non-GPIOs dt-bindings: pinctrl: qcom,mdm9607: fix indentation in example dt-bindings: pinctrl: qcom,qcm2290: fix matching pin config dt-bindings: pinctrl: qcom,qcm2290: use common TLMM schema dt-bindings: pinctrl: qcom,sdx55: fix matching pin config dt-bindings: pinctrl: qcom,sdx55: use common TLMM schema dt-bindings: pinctrl: qcom,sdx55: fix indentation in example dt-bindings: pinctrl: qcom,sdx65: fix matching pin config dt-bindings: pinctrl: qcom,sdx65: use common TLMM schema dt-bindings: pinctrl: qcom,sc7280: fix matching pin config dt-bindings: pinctrl: qcom,sc8280xp: fix indentation in example (remaining piece) .../pinctrl/qcom,ipq6018-pinctrl.yaml | 106 +++++++----------- .../pinctrl/qcom,mdm9607-pinctrl.yaml | 23 ++-- .../pinctrl/qcom,msm8226-pinctrl.yaml | 98 +++++++--------- .../bindings/pinctrl/qcom,msm8909-tlmm.yaml | 64 +++++------ .../pinctrl/qcom,msm8953-pinctrl.yaml | 92 ++++++--------- .../pinctrl/qcom,qcm2290-pinctrl.yaml | 52 ++------- .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml | 14 ++- .../pinctrl/qcom,sc8280xp-pinctrl.yaml | 4 +- .../bindings/pinctrl/qcom,sdx55-pinctrl.yaml | 90 ++++++--------- .../bindings/pinctrl/qcom,sdx65-pinctrl.yaml | 50 +++------ .../bindings/pinctrl/qcom,tlmm-common.yaml | 20 +++- arch/arm/boot/dts/qcom-apq8026-lg-lenok.dts | 6 +- arch/arm/boot/dts/qcom-msm8226.dtsi | 24 ++-- .../qcom-msm8974-lge-nexus5-hammerhead.dts | 30 ++--- .../boot/dts/qcom-sdx55-telit-fn980-tlb.dts | 45 +++----- arch/arm/boot/dts/qcom-sdx55.dtsi | 1 + arch/arm64/boot/dts/qcom/ipq6018-cp01-c1.dts | 6 +- arch/arm64/boot/dts/qcom/ipq6018.dtsi | 4 +- 18 files changed, 296 insertions(+), 433 deletions(-)