mbox series

[v2,00/40] pinctrl/arm64: qcom: fix some of Qualcomm pinctrl schema warnings

Message ID 20220912061746.6311-1-krzysztof.kozlowski@linaro.org
Headers show
Series pinctrl/arm64: qcom: fix some of Qualcomm pinctrl schema warnings | expand

Message

Krzysztof Kozlowski Sept. 12, 2022, 6:17 a.m. UTC 
Hi,

That's a set for some of arm64 pinctrl bindings fixing most common warnings.  I
have a plan to continue this for remaining arm64 (sm8250 needs updates) and for
arm.

Changes since v1
================
1. Correct commit msg in commits "fix matching pin config".
2. Correct commit msg in commit #2 .
3. Add Rb tags.

Dependencies
============
1. dt-bindings are independent of DTS patches.

Best regards,
Krzysztof

Krzysztof Kozlowski (40):
  dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sm6115-pinctrl: require function on GPIOs
  dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sm6125-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sm6125-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sm6125-pinctrl: extend example
  dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sm6350-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sm6375-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sm8250-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sm8250-pinctrl: reference tlmm common pins
  dt-bindings: pinctrl: qcom,sm8250-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sm8350-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sm8450-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sm8450-pinctrl: add gpio-line-names
  dt-bindings: pinctrl: qcom,sc7280-pinctrl: correct number of GPIOs
  dt-bindings: pinctrl: qcom,sc7280-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sc7280-pinctrl: add gpio-line-names
  dt-bindings: pinctrl: qcom,sc7280-pinctrl: reference tlmm schema
  dt-bindings: pinctrl: qcom,sc7280-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sc8180x-pinctrl: do not require function on
    non-GPIOs
  dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix indentation in example
  dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix matching pin config
  dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: do not require function
    on non-GPIOs
  dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix indentation in
    example
  arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sm6350: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sm8350-sagami: correct TS pin property
  arm64: dts: qcom: sm8350: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sm8450: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema
  arm64: dts: qcom: sc7280-herobrine: correct TLMM gpio-line-names

 .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml |  55 +--
 .../pinctrl/qcom,sc8180x-pinctrl.yaml         |  79 +++--
 .../pinctrl/qcom,sc8280xp-pinctrl.yaml        |  73 ++--
 .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml |  94 +++---
 .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml |  61 +++-
 .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml |  73 ++--
 .../bindings/pinctrl/qcom,sm6375-tlmm.yaml    |  73 ++--
 .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml |  41 ++-
 .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml |  73 ++--
 .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml |  82 +++--
 .../boot/dts/qcom/sc7280-herobrine-crd.dts    |   2 -
 .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi |  44 +--
 .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi |   8 +-
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi      |  20 +-
 arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi    |  14 +-
 arch/arm64/boot/dts/qcom/sc7280.dtsi          | 316 +++++++++---------
 .../qcom/sm6125-sony-xperia-seine-pdx201.dts  |   4 +-
 arch/arm64/boot/dts/qcom/sm6125.dtsi          |  10 +-
 arch/arm64/boot/dts/qcom/sm6350.dtsi          |  14 +-
 .../dts/qcom/sm8350-sony-xperia-sagami.dtsi   |   4 +-
 arch/arm64/boot/dts/qcom/sm8350.dtsi          |  44 +--
 .../qcom/sm8450-sony-xperia-nagara-pdx223.dts |  12 +-
 arch/arm64/boot/dts/qcom/sm8450.dtsi          | 152 ++++-----
 23 files changed, 733 insertions(+), 615 deletions(-)

Comments

Bjorn Andersson Sept. 13, 2022, 7:47 p.m. UTC | #1 
On Mon, Sep 12, 2022 at 08:17:06AM +0200, Krzysztof Kozlowski wrote:
> Hi,
> 
> That's a set for some of arm64 pinctrl bindings fixing most common warnings.  I
> have a plan to continue this for remaining arm64 (sm8250 needs updates) and for
> arm.

Very nice.

Reviewed-by: Bjorn Andersson <andersson@kernel.org>

@Linus, please pick the dt binding patches through your tree. I will
pick the dts changes at the end.

Regards,
Bjorn

> 
> Changes since v1
> ================
> 1. Correct commit msg in commits "fix matching pin config".
> 2. Correct commit msg in commit #2 .
> 3. Add Rb tags.
> 
> Dependencies
> ============
> 1. dt-bindings are independent of DTS patches.
> 
> Best regards,
> Krzysztof
> 
> Krzysztof Kozlowski (40):
>   dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sm6115-pinctrl: require function on GPIOs
>   dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sm6125-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sm6125-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sm6125-pinctrl: extend example
>   dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sm6350-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sm6375-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sm8250-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sm8250-pinctrl: reference tlmm common pins
>   dt-bindings: pinctrl: qcom,sm8250-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sm8350-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sm8450-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sm8450-pinctrl: add gpio-line-names
>   dt-bindings: pinctrl: qcom,sc7280-pinctrl: correct number of GPIOs
>   dt-bindings: pinctrl: qcom,sc7280-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sc7280-pinctrl: add gpio-line-names
>   dt-bindings: pinctrl: qcom,sc7280-pinctrl: reference tlmm schema
>   dt-bindings: pinctrl: qcom,sc7280-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sc8180x-pinctrl: do not require function on
>     non-GPIOs
>   dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix indentation in example
>   dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix matching pin config
>   dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: do not require function
>     on non-GPIOs
>   dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix indentation in
>     example
>   arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema
>   arm64: dts: qcom: sm6350: align TLMM pin configuration with DT schema
>   arm64: dts: qcom: sm8350-sagami: correct TS pin property
>   arm64: dts: qcom: sm8350: align TLMM pin configuration with DT schema
>   arm64: dts: qcom: sm8450: align TLMM pin configuration with DT schema
>   arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema
>   arm64: dts: qcom: sc7280-herobrine: correct TLMM gpio-line-names
> 
>  .../bindings/pinctrl/qcom,sc7280-pinctrl.yaml |  55 +--
>  .../pinctrl/qcom,sc8180x-pinctrl.yaml         |  79 +++--
>  .../pinctrl/qcom,sc8280xp-pinctrl.yaml        |  73 ++--
>  .../bindings/pinctrl/qcom,sm6115-pinctrl.yaml |  94 +++---
>  .../bindings/pinctrl/qcom,sm6125-pinctrl.yaml |  61 +++-
>  .../bindings/pinctrl/qcom,sm6350-pinctrl.yaml |  73 ++--
>  .../bindings/pinctrl/qcom,sm6375-tlmm.yaml    |  73 ++--
>  .../bindings/pinctrl/qcom,sm8250-pinctrl.yaml |  41 ++-
>  .../bindings/pinctrl/qcom,sm8350-pinctrl.yaml |  73 ++--
>  .../bindings/pinctrl/qcom,sm8450-pinctrl.yaml |  82 +++--
>  .../boot/dts/qcom/sc7280-herobrine-crd.dts    |   2 -
>  .../arm64/boot/dts/qcom/sc7280-herobrine.dtsi |  44 +--
>  .../arm64/boot/dts/qcom/sc7280-idp-ec-h1.dtsi |   8 +-
>  arch/arm64/boot/dts/qcom/sc7280-idp.dtsi      |  20 +-
>  arch/arm64/boot/dts/qcom/sc7280-qcard.dtsi    |  14 +-
>  arch/arm64/boot/dts/qcom/sc7280.dtsi          | 316 +++++++++---------
>  .../qcom/sm6125-sony-xperia-seine-pdx201.dts  |   4 +-
>  arch/arm64/boot/dts/qcom/sm6125.dtsi          |  10 +-
>  arch/arm64/boot/dts/qcom/sm6350.dtsi          |  14 +-
>  .../dts/qcom/sm8350-sony-xperia-sagami.dtsi   |   4 +-
>  arch/arm64/boot/dts/qcom/sm8350.dtsi          |  44 +--
>  .../qcom/sm8450-sony-xperia-nagara-pdx223.dts |  12 +-
>  arch/arm64/boot/dts/qcom/sm8450.dtsi          | 152 ++++-----
>  23 files changed, 733 insertions(+), 615 deletions(-)
> 
> -- 
> 2.34.1
>
Bjorn Andersson Sept. 13, 2022, 10:48 p.m. UTC | #2 
On Mon, 12 Sep 2022 08:17:06 +0200, Krzysztof Kozlowski wrote:
> That's a set for some of arm64 pinctrl bindings fixing most common warnings.  I
> have a plan to continue this for remaining arm64 (sm8250 needs updates) and for
> arm.
> 
> Changes since v1
> ================
> 1. Correct commit msg in commits "fix matching pin config".
> 2. Correct commit msg in commit #2 .
> 3. Add Rb tags.
> 
> [...]

Applied, thanks!

[34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema
        commit: be24fd19b1b42e0b38e77e0d6a379282bafb6aa6
[35/40] arm64: dts: qcom: sm6350: align TLMM pin configuration with DT schema
        commit: 448f5a002fedb2ff2d19e5a563d3af1ea5e123e1
[36/40] arm64: dts: qcom: sm8350-sagami: correct TS pin property
        commit: c9c53d1f4329564f98ed0decfe3c377c6639ec5d
[37/40] arm64: dts: qcom: sm8350: align TLMM pin configuration with DT schema
        commit: e227fa2970fd259fa65f97c4defb0b85dffc62d7
[38/40] arm64: dts: qcom: sm8450: align TLMM pin configuration with DT schema
        commit: a73747528867fabea8e285a1b604594181091507
[39/40] arm64: dts: qcom: sc7280: align TLMM pin configuration with DT schema
        commit: d801357a0573105ff5db9fbfde80c3572369a261
[40/40] arm64: dts: qcom: sc7280-herobrine: correct TLMM gpio-line-names
        commit: e0eeb08522c94860c3528816f612c335a6d6552c

Best regards,
Linus Walleij Sept. 14, 2022, 10:21 a.m. UTC | #3 
On Mon, Sep 12, 2022 at 8:17 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:

> That's a set for some of arm64 pinctrl bindings fixing most common warnings.  I
> have a plan to continue this for remaining arm64 (sm8250 needs updates) and for
> arm.

I applied patches 1-33 to the pinctrl tree after I saw Bjorn was happy
and has applied the DTS changes.

Yours,
Linus Walleij