| Message ID | 20220727102140.6676-1-hui.liu@mediatek.com |
|---|---|
| Headers | show |
| Series | MediaTek pinctrl patch on mt8188 | expand |
On 27/07/2022 12:21, Hui Liu wrote: > From: "Hui.Liu" <hui.liu@mediatek.com> > > Add pinctrl function header file and binding document for mt8188. > > Signed-off-by: Hui.Liu <hui.liu@mediatek.com> > --- > .../pinctrl/mediatek,mt8188-pinctrl.yaml | 238 +++ > .../pinctrl/mediatek,mt8188-pinfunc.h | 1280 +++++++++++++++++ > 2 files changed, 1518 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml > create mode 100644 include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h > > diff --git a/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml > new file mode 100644 > index 000000000000..a9d5e9eec35d > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml > @@ -0,0 +1,238 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/pinctrl-mt8188.yaml# Does not look like you tested the bindings. Please run `make dt_binding_check` (see Documentation/devicetree/bindings/writing-schema.rst for instructions). Best regards, Krzysztof
On Wed, 27 Jul 2022 18:21:39 +0800, Hui Liu wrote: > From: "Hui.Liu" <hui.liu@mediatek.com> > > Add pinctrl function header file and binding document for mt8188. > > Signed-off-by: Hui.Liu <hui.liu@mediatek.com> > --- > .../pinctrl/mediatek,mt8188-pinctrl.yaml | 238 +++ > .../pinctrl/mediatek,mt8188-pinfunc.h | 1280 +++++++++++++++++ > 2 files changed, 1518 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml > create mode 100644 include/dt-bindings/pinctrl/mediatek,mt8188-pinfunc.h > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: ./Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/pinctrl/mediatek,mt8188-pinctrl.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi:bias-pull-up: More than one condition true in oneOf schema: {'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [200, 201, 202, 203, 204, 205, 206, 207]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [1000, 1500, 2000, 3000, 4000, 5000, 10000, 75000]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: spi0-pins:pins-spi-mi:bias-pull-down: More than one condition true in oneOf schema: {'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [200, 201, 202, 203, 204, 205, 206, 207]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [75000, 5000]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c0-pins:pins:bias-pull-down: More than one condition true in oneOf schema: {'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [200, 201, 202, 203, 204, 205, 206, 207]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [75000, 5000]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.example.dtb: pinctrl@10005000: i2c1-pins:pins:bias-pull-up: More than one condition true in oneOf schema: {'oneOf': [{'items': [{'items': [{'enum': [100, 101, 102, 103]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [200, 201, 202, 203, 204, 205, 206, 207]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}, {'items': [{'items': [{'enum': [1000, 1500, 2000, 3000, 4000, 5000, 10000, 75000]}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}], 'maxItems': 1, 'minItems': 1, 'type': 'array'}, {}]} From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/mediatek,mt8188-pinctrl.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.