From patchwork Sun Dec 5 11:34:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cosmin Tanislav X-Patchwork-Id: 520829 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D50C433EF for ; Sun, 5 Dec 2021 11:34:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233191AbhLELiJ (ORCPT ); Sun, 5 Dec 2021 06:38:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53596 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231898AbhLELiH (ORCPT ); Sun, 5 Dec 2021 06:38:07 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24BFCC061714; Sun, 5 Dec 2021 03:34:40 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id y12so30799726eda.12; Sun, 05 Dec 2021 03:34:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p+hc8SGeVlTgShp4uLd10IiihUeMxyVX+sQWwU94Zyc=; b=Zv9v2dZdzgaoi+pqRplp6TKIChKtSVfF8Po6fPDv7xOr58MkCDQeNBA6dkOpGh0HyS 38dSb0jrGHgbGxSo0e6LJ0sJRNqE+/OYZSZThPJpXXoB5mYr3isTIyfUk+JPp4wknfBz KGmvkmIpPj3mPaucHILCaxKHvRaEZVDixpSKP3EXdA4U1e+Vhd1hh20/fKuTq/OAxiIr sQ3fvC/7w4WXmOAexQI1/mxAbfp5krPX6TCq/vhh09YNSMwg1IeAkgtWiftZzM5bW/qj O+cqZuCPMqlW7L3mes/DhhdXFvouFvdIsCBW7KSL+KGoBE6PMl0fPVIhr9JMh5EiyZQV 05sw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=p+hc8SGeVlTgShp4uLd10IiihUeMxyVX+sQWwU94Zyc=; b=53xKjR4NzvmdLTJZ68ds3gBYpBlPbkjBOSlLM7v+RikYdzQBfbACRFKO6Jhm8QwN9x YKtnLbld3EWJwGXF1N6qdfFFmBazZZcS0HIVibZWNKiPzAh5nP1/NPua9bQq++b7U5ub A5E6q62KGKWdUTaGD0h4RgRG226iJ1NjnVA2sZ8vVynhCgw4dk3DeJXJkLYDWZTALK7/ 3m0qU4zPB27mvvCB2wqsv67MlhKNbckS2kpxsQSXu42kOfwHvQO49DchDDbAlH9OsLKh atAnxM/zMSAVoEkHVwR266zXo5NBBEL+OdB9jcZv0sPYTxBaXKZ5/EbW6hcUjbRVSHOA SZlA== X-Gm-Message-State: AOAM530XsqDNfJ5D+eFPbMwpInuJu5+J7Nc7mby0BWBUjHjdP7imUKEx 4a+N6fgji7TUntfvsp2w5RQ= X-Google-Smtp-Source: ABdhPJxGVU2a+sgwwExerx3PA/ljG7FH5/KzgTvHljwx7x+Ep2/EWnk0TQ/ITUSc+TvtO21M45lIMA== X-Received: by 2002:a17:907:dab:: with SMTP id go43mr36945139ejc.537.1638704078573; Sun, 05 Dec 2021 03:34:38 -0800 (PST) Received: from demon-pc.localdomain ([188.24.96.74]) by smtp.gmail.com with ESMTPSA id d1sm5878225edn.56.2021.12.05.03.34.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 05 Dec 2021 03:34:38 -0800 (PST) From: Cosmin Tanislav X-Google-Original-From: Cosmin Tanislav Cc: cosmin.tanislav@analog.com, demonsingur@gmail.com, Lars-Peter Clausen , Michael Hennerich , Rob Herring , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Linus Walleij , Bartosz Golaszewski , linux-gpio@vger.kernel.org Subject: [PATCH v10 0/3] Add AD74413R driver Date: Sun, 5 Dec 2021 13:34:23 +0200 Message-Id: <20211205113426.41486-1-cosmin.tanislav@analog.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 To: unlisted-recipients:; (no To-header on input) Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org V1 -> V2 * sign off using company email V2 -> V3 * replace gpo config firmware flag with flag specifying whether gpo is in comparator mode * create two separate gpiochips, one output-only gpiochip for GPO pins not in comparator mode and one input-only for the value of digital input channels * wire up all gpo functionalities using pinconf * keep number of characters per line under 80 * rework locking * do not invalidate other chip revisions * do not set indio device parent * print probe error for refin regulator * move conversion from range register value to range / offset / raw offset into separate function * module.h -> mod_devicetable.h * use generic firmware interface functions * add comment regarding cache alignment * add comment regarding ADC channels buffered read setup * un-inline comment regarding 100us delay for conversion start * inline return statements * remove assignments to val2 where not necessary * local_channels -> chans * index -> i * channel_config -> config * IIO_ALTVOLTAGE -> IIO_VOLTAGE * .info_mask_shared_by_type_available -> .info_mask_separate_available * remove unlikely probe error messages * use an array indexed by channel function for retrieving iio channels * count iio channels while parsing * move HART rate rejection outside of setter * move channel function validation outside of setter * use SPI messages for read and write * validate DAC code earlier * simplify switches to only handle existing iio channels * pass indio_dev into functions needing access to it * pass spi into devm_regmap_init * dt-bindings: sort compatibles * dt-bindings: remove driver word from description * dt-bindings: remove refin supply description * dt-bindings: specify channel function default value * dt-bindings: remove maxItems from scalar value V3 -> v4 * remove double gpo from macro name * reset at probe * config -> chip_info and store chip name inside chip info * cacheline align every DMA buffer * simplify generation of adc samples message by caching xfer, tx_buf and rx_buf * use mask itself for writing the value of channel enable and gpo data * move reg read and write transfers to the same buffers and use local variables for transfers * merge the two for loops handling gpio configuration * let firmware decide irq edge * remove INDIO_BUFFER_SOFTWARE already set by iio framework * do not set trigger device parent * return dev_err_probe for regulator error case * do not set cs_change to 0 when not needed * do not set spi device drvdata as it is not needed * fix bug regarding wrong channels being created for resistance input, digital input, and current input with hart * use voltage input channels spec for high impedance mode * put () around macro parameters * merge AD74413R_CHANNEL macro into its uses * remove unused switch case scope * inline return IIO_VAL_INT * use {get,put}_unaligned_be16 * use proper types for reg and val * move default case handling into switch statements * pass driver state into regmap functions * use genmask for generating a 16bit max value * alphanumeric order for part numbers * dt-bindings: remove $ref from ohms value V4 -> V5 * dt-bindings: include headers necessary * dt-bindings: add IRQ_TYPE_EDGE_FALLING to interrupt flags * dt-bindings: ohm -> ohms * dt-bindings: spi0 -> spi V5 -> V6 * fix warnings regarding overflows V6 -> V7 * remove extra cache-line alignment * adi,rsense-resistance-ohms -> shunt-resistor-micro-ohms * dt-bindings: add product page links V7 -> V8 * also check DAC code lower bound * fix checkpath --strict complaints * add comment regarding mutex lock usage * propagate error when converting adc result to resistance V8 -> V9 * fix spelling mistake * undo propagate error when converting adc result to resistance * return void from adc result to resistance function * limit max adc value when doing resistance calculation to avoid a potential division-by-zero case V9 -> V10 * pick up Reviewed-By tags * fix odd alignment in header * add dev_err_probe to irq request error path Cosmin Tanislav (3): iio: add addac subdirectory dt-bindings: iio: add AD74413R iio: addac: add AD74413R driver .../bindings/iio/addac/adi,ad74413r.yaml | 158 ++ MAINTAINERS | 9 + drivers/iio/Kconfig | 1 + drivers/iio/Makefile | 1 + drivers/iio/addac/Kconfig | 20 + drivers/iio/addac/Makefile | 7 + drivers/iio/addac/ad74413r.c | 1475 +++++++++++++++++ include/dt-bindings/iio/addac/adi,ad74413r.h | 21 + 8 files changed, 1692 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml create mode 100644 drivers/iio/addac/Kconfig create mode 100644 drivers/iio/addac/Makefile create mode 100644 drivers/iio/addac/ad74413r.c create mode 100644 include/dt-bindings/iio/addac/adi,ad74413r.h