mbox series

[v3,0/4] pinctrl: amd: debounce filter fixes

Message ID 20201105231912.69527-1-coiby.xu@gmail.com
Headers show
Series pinctrl: amd: debounce filter fixes | expand

Message

Coiby Xu Nov. 5, 2020, 11:19 p.m. UTC 
There are three fixes (and one improvement) that fix the debounce
filter issues in pinctrl-amd.

Changelog v3:
 - Explain why the driver mistakenly took the slightly deviated value
   of debounce timeout in the commit message (patch 2/4) [Andy Shevchenko]
 - Explain why other touchpads are affected by the issue of setting debounce
   filter in IRQ type setting in the commit message (patch 4/4)

Changelog v2:
 - Message-Id to Link and grammar fixes for commit messages [Andy Shevchenko]


Coiby Xu (4):
  pinctrl: amd: fix incorrect way to disable debounce filter
  pinctrl: amd: use higher precision for 512 RtcClk
  pinctrl: amd: print debounce filter info in debugfs
  pinctrl: amd: remove debounce filter setting in IRQ type setting

 drivers/pinctrl/pinctrl-amd.c | 56 +++++++++++++++++++++++++++--------
 1 file changed, 44 insertions(+), 12 deletions(-)

--
2.28.0

Comments

Hans de Goede Nov. 9, 2020, 1:50 p.m. UTC | #1 
Hi,

On 11/6/20 12:19 AM, Coiby Xu wrote:
> The correct way to disable debounce filter is to clear bit 5 and 6

> of the register.

> 

> Cc: Hans de Goede <hdegoede@redhat.com>

> Link: https://lore.kernel.org/linux-gpio/df2c008b-e7b5-4fdd-42ea-4d1c62b52139@redhat.com/

> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>


Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>


Regards,

Hans

> ---

>  drivers/pinctrl/pinctrl-amd.c | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

> 

> diff --git a/drivers/pinctrl/pinctrl-amd.c b/drivers/pinctrl/pinctrl-amd.c

> index 9a760f5cd7ed..d6b2b4bd337c 100644

> --- a/drivers/pinctrl/pinctrl-amd.c

> +++ b/drivers/pinctrl/pinctrl-amd.c

> @@ -166,14 +166,14 @@ static int amd_gpio_set_debounce(struct gpio_chip *gc, unsigned offset,

>  			pin_reg |= BIT(DB_TMR_OUT_UNIT_OFF);

>  			pin_reg |= BIT(DB_TMR_LARGE_OFF);

>  		} else {

> -			pin_reg &= ~DB_CNTRl_MASK;

> +			pin_reg &= ~(DB_CNTRl_MASK << DB_CNTRL_OFF);

>  			ret = -EINVAL;

>  		}

>  	} else {

>  		pin_reg &= ~BIT(DB_TMR_OUT_UNIT_OFF);

>  		pin_reg &= ~BIT(DB_TMR_LARGE_OFF);

>  		pin_reg &= ~DB_TMR_OUT_MASK;

> -		pin_reg &= ~DB_CNTRl_MASK;

> +		pin_reg &= ~(DB_CNTRl_MASK << DB_CNTRL_OFF);

>  	}

>  	writel(pin_reg, gpio_dev->base + offset * 4);

>  	raw_spin_unlock_irqrestore(&gpio_dev->lock, flags);

>
Linus Walleij Nov. 10, 2020, 1:18 p.m. UTC | #2 
On Fri, Nov 6, 2020 at 12:19 AM Coiby Xu <coiby.xu@gmail.com> wrote:

> The correct way to disable debounce filter is to clear bit 5 and 6

> of the register.

>

> Cc: Hans de Goede <hdegoede@redhat.com>

> Link: https://lore.kernel.org/linux-gpio/df2c008b-e7b5-4fdd-42ea-4d1c62b52139@redhat.com/

> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>


This patch applied for fixes and tagged for stable.

Yours,
Linus Walleij
Linus Walleij Nov. 10, 2020, 1:21 p.m. UTC | #3 
On Fri, Nov 6, 2020 at 12:19 AM Coiby Xu <coiby.xu@gmail.com> wrote:

> Print the status of debounce filter as follows,

> $ cat /sys/kernel/debug/gpio

> pin129          interrupt is disabled| interrupt is masked| disable wakeup in S0i3 state| disable wakeup in S3 state|

>  disable wakeup in S4/S5 state| input is high|   pull-up is disabled| Pull-down is disabled|   output is disabled| debouncing filter disabled|   0x50000

>                                                                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^

> pin130          interrupt is disabled| interrupt is masked| disable wakeup in S0i3 state| disable wakeup in S3 state|

>  disable wakeup in S4/S5 state| input is high|   pull-up is disabled| Pull-down is disabled|   output is disabled| debouncing filter (high) enabled| debouncing timeout is 124800 (us)| 0x503c8

>                                                                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

>

> Signed-off-by: Coiby Xu <coiby.xu@gmail.com>


Patch applied for the next kernel (v5.11).

Yours,
Linus Walleij