mbox series

[v4,0/3] pinctrl: Ingenic: Add support for SSI and I2S pins.

Message ID 20200913065836.12156-1-zhouyanjie@wanyeetech.com
Headers show
Series pinctrl: Ingenic: Add support for SSI and I2S pins. | expand

Message

Zhou Yanjie Sept. 13, 2020, 6:58 a.m. UTC
1.Add SSI pins support for JZ4770 and JZ4780.
2.Correct the pullup and pulldown parameters of JZ4780.
3.Add I2S pins support for JZ4780, X1000, X1500, and X1830.

v2->v3:
1.Add Paul Cercueil's Reviewed-by.
2.Fix bug about PE15's pull-up parameter.

v3->v4:
1.Add Paul Cercueil's Reviewed-by.
2.Fix typo.

周琰杰 (Zhou Yanjie) (3):
  pinctrl: Ingenic: Add SSI pins support for JZ4770 and JZ4780.
  pinctrl: Ingenic: Correct the pullup and pulldown parameters of
    JZ4780.
  pinctrl: Ingenic: Add I2S pins support for Ingenic SoCs.

 drivers/pinctrl/pinctrl-ingenic.c | 349 +++++++++++++++++++++++++++++++++++++-
 1 file changed, 347 insertions(+), 2 deletions(-)

Comments

Linus Walleij Sept. 29, 2020, 12:48 p.m. UTC | #1
On Sun, Sep 13, 2020 at 8:59 AM 周琰杰 (Zhou Yanjie)
<zhouyanjie@wanyeetech.com> wrote:

> 1.Add SSI pins support for JZ4770 and JZ4780.
> 2.Correct the pullup and pulldown parameters of JZ4780.
> 3.Add I2S pins support for JZ4780, X1000, X1500, and X1830.
>
> v2->v3:
> 1.Add Paul Cercueil's Reviewed-by.
> 2.Fix bug about PE15's pull-up parameter.

This v3 patch set applied!

Thank you so much for your hard work!

Yours,
Linus Walleij
Paul Cercueil Oct. 10, 2020, 7:10 p.m. UTC | #2
Hi Linus, Zhou,

The first patch is bogus. Half of the SSI pins are wrong (GPIO chip D/E 
start at 0x60/0x80 respectively).

Sorry for not catching that before.

-Paul


Le mar. 29 sept. 2020 à 14:48, Linus Walleij 
<linus.walleij@linaro.org> a écrit :
> On Sun, Sep 13, 2020 at 8:59 AM 周琰杰 (Zhou Yanjie)
> <zhouyanjie@wanyeetech.com> wrote:
> 
>>  1.Add SSI pins support for JZ4770 and JZ4780.
>>  2.Correct the pullup and pulldown parameters of JZ4780.
>>  3.Add I2S pins support for JZ4780, X1000, X1500, and X1830.
>> 
>>  v2->v3:
>>  1.Add Paul Cercueil's Reviewed-by.
>>  2.Fix bug about PE15's pull-up parameter.
> 
> This v3 patch set applied!
> 
> Thank you so much for your hard work!
> 
> Yours,
> Linus Walleij