From patchwork Thu May 30 02:06:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 800691 Received: from JPN01-OS0-obe.outbound.protection.outlook.com (mail-os0jpn01on2049.outbound.protection.outlook.com [40.107.113.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9AE21B966; Thu, 30 May 2024 02:06:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.113.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717034787; cv=fail; b=J54sopfUWtIpSqZYFYcWKO78Xpr2xCzsbcJiipSwyleHoSrzXI5lmB7t/Ehk/HBfD3JuMJBFG9Uw4epLx1fVwh10+kZnw0QzG+bfJ3xgodWtbRCt/DgxV5cocuJ3V0pQ2IGfm9ZGCr7dwDHw1KxiyIY8KIlpQuugBfo5HMguErE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1717034787; c=relaxed/simple; bh=QjQSyVQmTO0jU740IcMo+DjTRDV4O+cr/KDkiY2Iz3I=; h=Message-ID:From:Subject:To:In-Reply-To:References:Content-Type: Date:MIME-Version; b=SwXwJTGYHD3eubqBZk1Vrd/ABq4Ypz8+BWtMQeIeUMgzRoiQ5ANlnoPAN1BxA7R9Z8NNe5c1+y+q06L35h9+65IBzV7jfBd3U+9dSxjm/OyvBOKbPq5fhehkEeSAXSc1UtjN+DgMALoVPPWOx8YJ0deMiEDapj4X0d7nhWTcDbw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com; spf=pass smtp.mailfrom=renesas.com; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b=MktLtXW+; arc=fail smtp.client-ip=40.107.113.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=renesas.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=renesas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=renesas.com header.i=@renesas.com header.b="MktLtXW+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hQbMBu21rySj3PORydf+uwqovN0Na3Xo/wwsu6ymE6kzV6St9DSp+I3LZ9+zb9twpGhxUHzEeUWpuJMW2+lluS80qgK3n+eoG09Q87RgTPJDpoHALJ8AGDjR7b89nsTUNcxKcJSBWfKGffq6TXaC4pVm7p+6lYGocaljlHLWz9Mj+O7YD7uFLZezIT4f/NxdV3JTrU2wCMhSIP+CnkqAA+/w11kKPnE1IuU+BuvncZnksDDmPd07RhtbIykdkegrfUWM4rGvmwbhsR3SCmYV7x3lcNomGz8IoaitAc3WXE4zmm/woj00Lpmr6F9/1xV5SzKcHeuOl4XbMB9GUz+sqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Q3vqksv/GybRwRfvf5iD9mFwpkjoL6qLD9V40ien6ds=; b=RDuyzVpgiMMIcJI7t6njuFQ1u30vEnCepsgxj++7JCbIAC5yt8HuX19ec5E0lQs/QyFIi7L3duQztj3EMDvctN+2CXWpT876i8F8aKj97p7hkKFIK1LwkRmasJyY/2fy8pYFhZsb7d1J1Q1QeyhVIyklU70rAAcbeKFqk0p299kV9ekQp/Q8NrYWjIR9jGdq409TJOrsn3Nk5s3n0ln2GXk/XiocekS3UlOUHi1QvSmsiLOVQkVB3k0IZleN9X5F0pbqSQMCOiJTj23Ww7hRefpyuiG0dkiDBWwZimSdiutkgaYJOm2+3G/7CfVnP7ojSujrRp3Rps5qRCubyQJL5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Q3vqksv/GybRwRfvf5iD9mFwpkjoL6qLD9V40ien6ds=; b=MktLtXW+kERu0TJZ0xgVIv2U58Y1mtPN32S4upArIDTKlMwyCmT8huCol5n9DwB6wdykAjwnEqUhD66jAjAy78c70H/uJtBHhJBzmYHa6GgZPL5tofiLu+O1clgw6yCj5y4VpfpdK4QqDAmoXog+dg/SGEUO79s2txhDTpGHKJs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) by TYWPR01MB10240.jpnprd01.prod.outlook.com (2603:1096:400:1e5::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7633.21; Thu, 30 May 2024 02:06:22 +0000 Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11]) by TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11%4]) with mapi id 15.20.7633.018; Thu, 30 May 2024 02:06:22 +0000 Message-ID: <87bk4ooxya.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH v3 7/9] staging: media: atmel: use for_each_endpoint_of_node() User-Agent: Wanderlust/2.15.9 Emacs/29.3 Mule/6.0 To: "Lad Prabhakar" , Alexander Shishkin , Alexandre Belloni , Claudiu Beznea , Daniel Vetter , David Airlie , Eugen Hristev , Greg Kroah-Hartman , Helge Deller , Laurent Pinchart , Maarten Lankhorst , Mauro Carvalho Chehab , Maxime Ripard , Michal Simek , Nicolas Ferre , Rob Herring , Suzuki K Poulose , Thomas Zimmermann , Tomi Valkeinen , coresight@lists.linaro.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev In-Reply-To: <87le3soy08.wl-kuninori.morimoto.gx@renesas.com> References: <87le3soy08.wl-kuninori.morimoto.gx@renesas.com> Date: Thu, 30 May 2024 02:06:22 +0000 X-ClientProxiedBy: TY2PR02CA0057.apcprd02.prod.outlook.com (2603:1096:404:e2::21) To TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) Precedence: bulk X-Mailing-List: linux-fbdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB10914:EE_|TYWPR01MB10240:EE_ X-MS-Office365-Filtering-Correlation-Id: b346091e-4670-4687-7704-08dc804d1a5b X-LD-Processed: 53d82571-da19-47e4-9cb4-625a166a4a2a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|7416005|1800799015|52116005|366007|921011|38350700005; X-Microsoft-Antispam-Message-Info: kP/PvU/hdK+bTMlepqnj5JciKcfw6TtD9k09coo+DxivqqPc18WcNAB24ffUbOOPwhG5i5Ja6urBv8PaBQt5U+7OGmIpRummoAJdvJLI3WoiXzGsY/6/nXW6re70lh6KFkvwH21/DJiNakAKqHQDHTi9nCB9fsqXs63R6o+swj3hmZMItmrCfk9W1cwYncxWCpre6lifBP0E5BbIEZpDll2lClz6cXD7yd5ueqOq1PX1kc72QqdEv8NOF+DjiYZs7Dzk3MZgQDeGV2WZQ+qKwkdh98JZuHmuy207VeJC7wsNvhL4HUhMMxCCnNTJhHL+OxpaSdlmXNTSmui1pCvktDntSNt+PGzylYhfqG3/dokowLc3fmtE1jMvop3PQH98hPRrILCeU4A1N2qUcHpOL5VQt1Gc9zLNMzGDZ8zysjPZDS9/ZkE6BDXWTlbKwJgXok2UCcn+BRQKS/mnOOI/upaDt0G2LCGKtiRNzjv0rR+yrFaFvhRxw8qemRnWtiNxrorjRd6OsjjSttK4ddMQ0JEEzid2NnneYZbx+Ta0ZxszGI25eKCZF4MEZhn9GjH+/LGqCZCG1gPw58v4mgmLSlOsokOxOHp6B7SUmDhqLMWC2T1SPM5mlwCtvsUNgCC7+9jtn7rlzRa3AOgA7+WsU4muMKFlUD3/fOP9lZ2N+n85qZd3D628KrDsdUPeq0fbFdmdhz1lifvHhvJNIBT0oKE9xmVrDoPGyfRfuAjWsTdyNiGUSWp4BNdtvoCYVThdSwoJf1+2udPPGxWwomCy9DBAfLsj08uj+L04iZT6bDEud9NF3JleAGHjVGKZRTXaGyB8S8jeN4wIpKfA0pS4wHIA4c/+topORVpK6k26qrXaKCxiNk4G7JJEKaWyQMEmJGKchbq8oX32iMVjAX7yOai3Hn85Py0Z4zCQv2NpeB9l/Sw5NIt5PrmDpc4QVexEvvlQQRdJLYmpd+9VarEb22PaYJeAjycr59GFap1JcKkRAsM92/2fyYFnqN/FX3tFJJePAwxxST/viKQgNEGOKYEtY724V42sXz974KHLwfA1wURIuNn3wpl5ncs5W7DZ4Ksg87Gf+Aw3oSFK+U84uLtkLGMV0btlrgt7iTTNF0mSai05KSlar2t61FYylaXGwVwA58ElZPEGRATAV8HvK3g66iWodIxjGJN34MPLmsqu6PzD5OInI3vO41mFBsf5WAJPcXTh+z6zhhbseBXjkPwvoAp1nQNlVWS69DvK0YloPVgeLLlJcKMh7B+u9J4Z+0G8CHDCuqEOaPkIOwr/tcebegFdIdORfF5Pkyi2FkHLwLCHNSWnKUubfXYDdz0a4zOjoBTtJqqANJQEdMEVVQs9a5KBSfVQIl9RS7JMUZM= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB10914.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(7416005)(1800799015)(52116005)(366007)(921011)(38350700005); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: DoBipfDvMLpTVvlYAzeaoS2bHJyP/lELte+N3CZqkmYV5cU8daxC2DydTwFzLcJFhjmgWxPb/wPuHqlGjlpPloxfHcX4X6K6ScwjX4fSx0LDVOCyjNiMHltkKrk5DzzV89LrBCnI/OvUw1Xraza9lPBg9+pWfS1Sj5c3zPjPORgXeQi2WE3E2vC478WK7F3Y0WS02VrXveEZs0IIbiCZCFYEabuW+Ifu80QC48j6WO8ggLL4s2kdevWrjA/K7E3WapcOPFY9/8MhBYgVfd+tieNsjsvxuzCx2qqkncwb4E7tDRkULfO4T0K0sowzAun8szHoRrxcKgPkDsLUOedA+Qd9A90ZfU+kpOBJ16cqOYA699YiFSMBx4R9rKozJRsISb8KqOJYAOp/xyHrKPrCha78nQRvKC8vAhw6O3OJDgPEMThIMKlz/l0A+MnuGPnQcGZaI9UJX0nexQzjhwi19FZMm65EA9JSXO1jrcot8bHexMtei6M2xT/3jyR0Xd4hNeQTB4kjcSilh3axVD1YcDtdkhIY7ehM3ljD1NkT5DF60mVP64oe3QpgjscZObUaLOMBLX4QczMdvYD00mGNyM3ygDwc5J7iIemnnpKKHDWdYvG77TxwQUMBlWru/llwINfVUATp0CsCML1Q1beqGy/L4HU2s7MgLGQ71sD7TPF0Qlot1nu3UVAl9U5YF0K6yA+T9ngj5qE34BdStoQHANSA5YyBIp2JgopPR4RU+DWjakt+SkjWpdRQwa6YEWbwHKLJfmmYSqQzvMIQTZwx5HgXLOuL0Cv2s1RIpVYnM4Q5i+b4kTZ1s8cZMy71GW8Q9uwYyZ9YxAg321EYyTeMMKxbN8GhMNdWfyuD81VWbC6+igWGwMy3AQw0hKBGHoFkJ9+9qObFVcCnMuJ3Z3wR2RZ8Qlgr/6bvY4td2ikTJylsPS4p92OXqrK7F8Z9ZT/A5V+KHAzDdty0X5yml1dAKNXapdnOKYAQE9gjoFX81JX4ExmW5FGLPZ80pyrNele3psSzaQjxPae38rYawiAwOegSU2kUOYTuTBGG0dNp9GRqU1N9ANN/qbesqHRYl7ERVQ/mmHZNBwowVc9HHBhLZG4DIUsjFjmUiunkHkjA5nCxjyRvTP2eBW+DRy09Dn2kEknHgvpOQLH4gez217+ux0yoB8sKP39ThMrRH/c39ZlyDmkLt1eO8e62W3CLvoCVh7MxCIlcG1xPLVqmkvMhfdgCwQ1oy/gPoVpm+HnsjOroaXKErachRd3jKhS/MncE1gVhmzJF2SIXYdUoqs1Cp7X2836DdNJwrgHZH3KqTUT3RzdJ4GTrvWQGupiYDHHh8y5/AxG0Z5xd5NTzkNBZeMueDQSAHAEMZDTqrxUF1cBl4Z8osxwu22JeqIfGA9+2md+61OITccGHPJ9LW+kQtr2FiIRLpMM1l7qNfyMnfZUzMLcjDnWeG1so4MF7NECq84xxOB5jEF2kysPoAXRco7ewI21HbKNpToyj1JUVm3hl4M/KsZ6XydOma+vCePJHyVPN7RKpsCO/qF0MBQkUGnMDKZxWxlDtXfDFBJNjo9bOOcBnlcJrP2eOfP8TdWgdoOMgU/cbh0Xt8/Kua5ySd9phJBEsnnElmSzYzlRKRGA= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: b346091e-4670-4687-7704-08dc804d1a5b X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2024 02:06:22.3795 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2+ejKOmGF7XaIvLJjd+e5bKicvRwKSBHttSraQjDjWlQs9dBtQAJAvPfOJ+B3ZFsXbZpw0VjXi8hEMYTmAOmmhOQX12dJGdrXyjT+DCjqnTfw6ypAc0u7KmmQTuB4uvW X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYWPR01MB10240 We already have for_each_endpoint_of_node(), don't use of_graph_get_next_endpoint() directly. Replace it. Signed-off-by: Kuninori Morimoto Reviewed-by: Laurent Pinchart --- .../staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 8 ++------ .../staging/media/deprecated/atmel/atmel-sama7g5-isc.c | 8 ++------ 2 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c index 31b2b48085c59..3b28a232418a9 100644 --- a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c +++ b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c @@ -333,20 +333,16 @@ static const u32 isc_sama5d2_gamma_table[][GAMMA_ENTRIES] = { static int isc_parse_dt(struct device *dev, struct isc_device *isc) { struct device_node *np = dev->of_node; - struct device_node *epn = NULL; + struct device_node *epn; struct isc_subdev_entity *subdev_entity; unsigned int flags; int ret; INIT_LIST_HEAD(&isc->subdev_entities); - while (1) { + for_each_endpoint_of_node(np, epn) { struct v4l2_fwnode_endpoint v4l2_epn = { .bus_type = 0 }; - epn = of_graph_get_next_endpoint(np, epn); - if (!epn) - return 0; - ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(epn), &v4l2_epn); if (ret) { diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c index 020034f631f57..e559beb099f71 100644 --- a/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c +++ b/drivers/staging/media/deprecated/atmel/atmel-sama7g5-isc.c @@ -316,7 +316,7 @@ static const u32 isc_sama7g5_gamma_table[][GAMMA_ENTRIES] = { static int xisc_parse_dt(struct device *dev, struct isc_device *isc) { struct device_node *np = dev->of_node; - struct device_node *epn = NULL; + struct device_node *epn; struct isc_subdev_entity *subdev_entity; unsigned int flags; int ret; @@ -326,13 +326,9 @@ static int xisc_parse_dt(struct device *dev, struct isc_device *isc) mipi_mode = of_property_read_bool(np, "microchip,mipi-mode"); - while (1) { + for_each_endpoint_of_node(np, epn) { struct v4l2_fwnode_endpoint v4l2_epn = { .bus_type = 0 }; - epn = of_graph_get_next_endpoint(np, epn); - if (!epn) - return 0; - ret = v4l2_fwnode_endpoint_parse(of_fwnode_handle(epn), &v4l2_epn); if (ret) {