diff mbox series

[04/14] fbdev/cyber2000fb: Unexport symbols

Message ID 20250610105948.384540-5-tzimmermann@suse.de
State New
Headers show
Series fbdev: Fix warnings related to including <linux/export.h> | expand

Commit Message

Thomas Zimmermann June 10, 2025, 10:56 a.m. UTC 
Fix the compile-time warning

  drivers/video/fbdev/cyber2000fb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing

The affected symbols are not used outside of their module.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/video/fbdev/cyber2000fb.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Helge Deller June 10, 2025, 8:10 p.m. UTC | #1 
On 6/10/25 12:56, Thomas Zimmermann wrote:
> Fix the compile-time warning
> 
>    drivers/video/fbdev/cyber2000fb.c: warning: EXPORT_SYMBOL() is used, but #include <linux/export.h> is missing
> 
> The affected symbols are not used outside of their module.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
>   drivers/video/fbdev/cyber2000fb.c | 4 ----
>   1 file changed, 4 deletions(-)


Seems those functions were used for some capture card/tv driver
functionality in the past.
Maybe we should simply remove those functions today?

Helge

> 
> diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
> index 986760b90465..fcc565b2d98c 100644
> --- a/drivers/video/fbdev/cyber2000fb.c
> +++ b/drivers/video/fbdev/cyber2000fb.c
> @@ -1089,7 +1089,6 @@ void cyber2000fb_enable_extregs(struct cfb_info *cfb)
>   		cyber2000_grphw(EXT_FUNC_CTL, old, cfb);
>   	}
>   }
> -EXPORT_SYMBOL(cyber2000fb_enable_extregs);
>   
>   /*
>    * Disable access to the extended registers
> @@ -1109,7 +1108,6 @@ void cyber2000fb_disable_extregs(struct cfb_info *cfb)
>   	else
>   		cfb->func_use_count -= 1;
>   }
> -EXPORT_SYMBOL(cyber2000fb_disable_extregs);
>   
>   /*
>    * Attach a capture/tv driver to the core CyberX0X0 driver.
> @@ -1135,7 +1133,6 @@ int cyber2000fb_attach(struct cyberpro_info *info, int idx)
>   
>   	return int_cfb_info != NULL;
>   }
> -EXPORT_SYMBOL(cyber2000fb_attach);
>   
>   /*
>    * Detach a capture/tv driver from the core CyberX0X0 driver.
> @@ -1143,7 +1140,6 @@ EXPORT_SYMBOL(cyber2000fb_attach);
>   void cyber2000fb_detach(int idx)
>   {
>   }
> -EXPORT_SYMBOL(cyber2000fb_detach);
>   
>   #ifdef CONFIG_FB_CYBER2000_DDC
>
diff mbox series

Patch

diff --git a/drivers/video/fbdev/cyber2000fb.c b/drivers/video/fbdev/cyber2000fb.c
index 986760b90465..fcc565b2d98c 100644
--- a/drivers/video/fbdev/cyber2000fb.c
+++ b/drivers/video/fbdev/cyber2000fb.c
@@ -1089,7 +1089,6 @@  void cyber2000fb_enable_extregs(struct cfb_info *cfb)
 		cyber2000_grphw(EXT_FUNC_CTL, old, cfb);
 	}
 }
-EXPORT_SYMBOL(cyber2000fb_enable_extregs);
 
 /*
  * Disable access to the extended registers
@@ -1109,7 +1108,6 @@  void cyber2000fb_disable_extregs(struct cfb_info *cfb)
 	else
 		cfb->func_use_count -= 1;
 }
-EXPORT_SYMBOL(cyber2000fb_disable_extregs);
 
 /*
  * Attach a capture/tv driver to the core CyberX0X0 driver.
@@ -1135,7 +1133,6 @@  int cyber2000fb_attach(struct cyberpro_info *info, int idx)
 
 	return int_cfb_info != NULL;
 }
-EXPORT_SYMBOL(cyber2000fb_attach);
 
 /*
  * Detach a capture/tv driver from the core CyberX0X0 driver.
@@ -1143,7 +1140,6 @@  EXPORT_SYMBOL(cyber2000fb_attach);
 void cyber2000fb_detach(int idx)
 {
 }
-EXPORT_SYMBOL(cyber2000fb_detach);
 
 #ifdef CONFIG_FB_CYBER2000_DDC