mbox series

[v5,0/9] of: property: add of_graph_get_next_port/port_endpoint()

Message ID 87r0a06ja1.wl-kuninori.morimoto.gx@renesas.com
Headers show
Series of: property: add of_graph_get_next_port/port_endpoint() | expand

Message

Kuninori Morimoto Sept. 4, 2024, 6:10 a.m. UTC 
Hi Rob, Saravana, Tomi, Laurent, Sakari, Mark

This is v5 patch-set

Current Of-graph has "endpoint base" for loop, but doesn't have
"port base" loop. "endpoint base" loop only is not enough.
This patch-set add new "port base" for loop, and use it.

Unfortunately, new helper function need to call of_node_get()
if dts doesn't have "ports" node, so we can't replace existing
loop by new helper, because it is using "const".

I noticed that some developer posted the patch to ALSA ML and
its and [5/9][6/9] patch will conflict. I think it is better to
repost these to ALSA ML *after* main patches (= [1/9][2/9]) were
included to linus/master tree (?). (Mark, can you agree ?)
So, [5/9][6/9] wants "review" only here.

v4 -> v5
	- tidyup comments
	- [8/9]: parent NULL check was removed
	- [9/9]: use for_each_of_graph_port()

v3 -> v4
	- new for_each loop includes __free()
	 - comment indicates to use return_ptr() or no_free_ptr() if
	   it need to continue to use node
	 - each driver based on it
	- care "prev" leak on of_graph_get_next_ports()
	- of_graph_get_next_port_endpoint() indicates WARN() if port
	  has non-endpoint node
	- tidyup each git-log

v2 -> v3
	- return NULL if it it doesn't have ports / port
	- add visible comment on of_graph_get_next_ports()

v1 -> v2
	- add each Reviewed-by / Acked-by
	- tidyup/update Kernel Docs
	- use prev as parameter
	- update git-log explanation
	- remove extra changes



Kuninori Morimoto (9):
  of: property: add of_graph_get_next_port()
  of: property: add of_graph_get_next_port_endpoint()
  ASoC: test-component: use new of_graph functions
  ASoC: rcar_snd: use new of_graph functions
  ASoC: audio-graph-card: use new of_graph functions
  ASoC: audio-graph-card2: use new of_graph functions
  gpu: drm: omapdrm: use new of_graph functions
  fbdev: omapfb: use new of_graph functions
  media: xilinx-tpg: use new of_graph functions

 drivers/gpu/drm/omapdrm/dss/dpi.c             |   3 +-
 drivers/gpu/drm/omapdrm/dss/sdi.c             |   3 +-
 drivers/media/platform/xilinx/xilinx-tpg.c    |  13 +-
 drivers/of/property.c                         | 154 ++++++++++++++++++
 drivers/video/fbdev/omap2/omapfb/dss/dpi.c    |   3 +-
 drivers/video/fbdev/omap2/omapfb/dss/dss-of.c |  66 --------
 drivers/video/fbdev/omap2/omapfb/dss/dss.c    |  15 +-
 drivers/video/fbdev/omap2/omapfb/dss/sdi.c    |   3 +-
 include/linux/of_graph.h                      |  71 ++++++++
 include/video/omapfb_dss.h                    |   8 -
 sound/soc/generic/audio-graph-card.c          |  11 +-
 sound/soc/generic/audio-graph-card2.c         | 113 ++++++-------
 sound/soc/generic/test-component.c            |   3 +-
 sound/soc/sh/rcar/core.c                      |  21 +--
 14 files changed, 299 insertions(+), 188 deletions(-)

Comments

Kuninori Morimoto Sept. 4, 2024, 7:56 a.m. UTC | #1 
Hi

> Now we can use new port related functions for port parsing. Use it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> ---

I'm sorry, but this patch will get below warning

   drivers/media/platform/xilinx/xilinx-tpg.c: In function 'xtpg_parse_of':
>> drivers/media/platform/xilinx/xilinx-tpg.c:715:29: warning: unused variable 'port' [-Wunused-variable]

I will post v6 after review

Thank you for your help !!

Best regards
---
Kuninori Morimoto