| Message ID | 20250210-wip-bl-ad7606_add_backend_sw_mode-v4-0-160df18b1da7@baylibre.com |
|---|---|
| Headers | show |
| Series | add support for Software mode on AD7606's iio backend driver | expand |
On Mon, 10 Feb 2025 17:10:51 +0100, Angelo Dureghello wrote: > From: Guillaume Stols <gstols@baylibre.com> > > A new compatible is added to reflect the specialized version of the HDL. > We use the parallel interface to write the ADC's registers, and > accessing this interface requires to use ADI_AXI_REG_CONFIG_RD, > ADI_AXI_REG_CONFIG_WR and ADI_AXI_REG_CONFIG_CTRL in a custom fashion. > > Reviewed-by: Rob Herring (Arm) <robh@kernel.org> > Signed-off-by: Guillaume Stols <gstols@baylibre.com> > Co-developed-by: Angelo Dureghello <adureghello@baylibre.com> > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> > --- > .../devicetree/bindings/iio/adc/adi,axi-adc.yaml | 70 +++++++++++++++++++++- > 1 file changed, 69 insertions(+), 1 deletion(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.example.dtb: adc@0: pwm-names: ['convst1'] is too short from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250210-wip-bl-ad7606_add_backend_sw_mode-v4-1-160df18b1da7@baylibre.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 2/10/25 11:19 AM, Rob Herring (Arm) wrote: > > On Mon, 10 Feb 2025 17:10:51 +0100, Angelo Dureghello wrote: >> From: Guillaume Stols <gstols@baylibre.com> >> >> A new compatible is added to reflect the specialized version of the HDL. >> We use the parallel interface to write the ADC's registers, and >> accessing this interface requires to use ADI_AXI_REG_CONFIG_RD, >> ADI_AXI_REG_CONFIG_WR and ADI_AXI_REG_CONFIG_CTRL in a custom fashion. >> >> Reviewed-by: Rob Herring (Arm) <robh@kernel.org> >> Signed-off-by: Guillaume Stols <gstols@baylibre.com> >> Co-developed-by: Angelo Dureghello <adureghello@baylibre.com> >> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> >> --- >> .../devicetree/bindings/iio/adc/adi,axi-adc.yaml | 70 +++++++++++++++++++++- >> 1 file changed, 69 insertions(+), 1 deletion(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.example.dtb: adc@0: pwm-names: ['convst1'] is too short > from schema $id: http://devicetree.org/schemas/iio/adc/adi,ad7606.yaml# Caused by missing dependency from v3 that Jonathan already picked up. https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git/commit/?h=fixes-togreg&id=02ccd7e5d81af4ae20852fc1ad67e7d943fa5778 > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250210-wip-bl-ad7606_add_backend_sw_mode-v4-1-160df18b1da7@baylibre.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
On Mon, 10 Feb 2025 17:10:50 +0100 Angelo Dureghello <adureghello@baylibre.com> wrote: > The previous series added iio_backend mode, but the configuration for this > mode was only possible through GPIOs (Hardware mode). Here, we add support > for configuring the chip using its registers (Software mode). > > The bus access is based on Angelo's ad3552 implementation, that is we have > a particular compatible for the backend (here axi-adc) version supporting > the ad7606's register writing, and the ad7606 is defined as a child node > of the backend in the devicetree. Small changes are added to make the code > a bit more straightforward to understand, and more compact. > > Signed-off-by: Guillaume Stols <gstols@baylibre.com> > Co-developed-by: Angelo Dureghello <adureghello@baylibre.com> > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> Applied to the togreg branch of iio.git. Briefly pushed that out as testing to let 0-day take a first look. Thanks, Jonathan