| Message ID | 20240711052734.1273652-1-eahariha@linux.microsoft.com |
|---|---|
| Headers | show |
| Series | Make I2C terminology more inclusive for I2C Algobit and consumers | expand |
Hi Easwar, On Thu, Jul 11, 2024 at 05:27:31AM +0000, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, > fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that > the approved verbiage exists in the specification. > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Acked-by: Zhi Wang <zhiwang@kernel.org> > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > --- > drivers/gpu/drm/i915/display/dvo_ch7017.c | 14 ++++----- > drivers/gpu/drm/i915/display/dvo_ch7xxx.c | 18 +++++------ > drivers/gpu/drm/i915/display/dvo_ivch.c | 16 +++++----- > drivers/gpu/drm/i915/display/dvo_ns2501.c | 18 +++++------ > drivers/gpu/drm/i915/display/dvo_sil164.c | 18 +++++------ > drivers/gpu/drm/i915/display/dvo_tfp410.c | 18 +++++------ > drivers/gpu/drm/i915/display/intel_bios.c | 22 +++++++------- > .../gpu/drm/i915/display/intel_display_core.h | 2 +- > drivers/gpu/drm/i915/display/intel_dsi.h | 2 +- > drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++------- > drivers/gpu/drm/i915/display/intel_dvo.c | 14 ++++----- > drivers/gpu/drm/i915/display/intel_dvo_dev.h | 2 +- > drivers/gpu/drm/i915/display/intel_gmbus.c | 4 +-- > drivers/gpu/drm/i915/display/intel_sdvo.c | 30 +++++++++---------- > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 +-- > drivers/gpu/drm/i915/gvt/edid.c | 28 ++++++++--------- > drivers/gpu/drm/i915/gvt/edid.h | 4 +-- > drivers/gpu/drm/i915/gvt/opregion.c | 2 +- > 18 files changed, 118 insertions(+), 118 deletions(-) it's a complex/long patch and I want to make sure there are no subtle errors. I will submit another round of tests and if it convinces me, I will take it in. The failures you see[*] are definitely not related to this patch, but better safe safe safe than sorry sorry sorry :-) Thanks, Andi [*] https://patchwork.freedesktop.org/series/131867/
Hi Easwar, merged to drm-intel-next. Thanks! On Thu, Jul 11, 2024 at 05:27:31AM +0000, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, > fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that > the approved verbiage exists in the specification. > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> I realized after pushing that this had the tag: Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Not a big deal, but it's still a minor mistake. Andi
On 7/22/2024 5:50 AM, Andi Shyti wrote: > Hi Easwar, > > merged to drm-intel-next. Thanks! > > On Thu, Jul 11, 2024 at 05:27:31AM +0000, Easwar Hariharan wrote: >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" >> with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, >> fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that >> the approved verbiage exists in the specification. >> >> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > I realized after pushing that this had the tag: > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Not a big deal, but it's still a minor mistake. > > Andi Thank you for the merge, Andi! I'm missing what the mistake is, I added the tags as I got them. Was I supposed to drop the R-B when Rodrigo gave an A-B? Thanks, Easwar
Hi Easwar, On Mon, Jul 22, 2024 at 09:15:08AM -0700, Easwar Hariharan wrote: > On 7/22/2024 5:50 AM, Andi Shyti wrote: > > Hi Easwar, > > > > merged to drm-intel-next. Thanks! > > > > On Thu, Jul 11, 2024 at 05:27:31AM +0000, Easwar Hariharan wrote: > >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > >> with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, > >> fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that > >> the approved verbiage exists in the specification. > >> > >> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > I realized after pushing that this had the tag: > > > > Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > > > Not a big deal, but it's still a minor mistake. > > > > Andi > > Thank you for the merge, Andi! I'm missing what the mistake is, I added > the tags as I got them. Was I supposed to drop the R-B when Rodrigo gave > an A-B? Sorry, it's not yours, it's mine. I should have checked more carefully the tag section before pushing. You did everything right. The dim tool (drm maintianers tool) picked up all the tags added and I missed the double tag. This was more a message for Rodrigo, in case he wanted to fix it, but I guess no one will complain about. Thanks a lot for your work and effort! Andi
On 7/10/2024 10:27 PM, Easwar Hariharan wrote: > I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" > with more appropriate terms. Inspired by Wolfram's series to fix drivers/i2c/, > fix the terminology for users of I2C_ALGOBIT bitbanging interface, now that > the approved verbiage exists in the specification. > > Acked-by: Alex Deucher <alexander.deucher@amd.com> > Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com> > --- > .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 +++--- > drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 10 +++---- > drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 8 +++--- > drivers/gpu/drm/amd/amdgpu/atombios_i2c.h | 2 +- > drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 20 ++++++------- > .../gpu/drm/amd/display/dc/bios/bios_parser.c | 2 +- > .../drm/amd/display/dc/bios/bios_parser2.c | 2 +- > .../drm/amd/display/dc/core/dc_link_exports.c | 4 +-- > drivers/gpu/drm/amd/display/dc/dc.h | 2 +- > drivers/gpu/drm/amd/display/dc/dce/dce_i2c.c | 4 +-- > .../display/include/grph_object_ctrl_defs.h | 2 +- > drivers/gpu/drm/amd/include/atombios.h | 2 +- > drivers/gpu/drm/amd/include/atomfirmware.h | 26 ++++++++--------- > .../powerplay/hwmgr/vega20_processpptables.c | 4 +-- > .../amd/pm/powerplay/inc/smu11_driver_if.h | 2 +- > .../inc/pmfw_if/smu11_driver_if_arcturus.h | 2 +- > .../inc/pmfw_if/smu11_driver_if_navi10.h | 2 +- > .../pmfw_if/smu11_driver_if_sienna_cichlid.h | 2 +- > .../inc/pmfw_if/smu13_driver_if_aldebaran.h | 2 +- > .../inc/pmfw_if/smu13_driver_if_v13_0_0.h | 2 +- > .../inc/pmfw_if/smu13_driver_if_v13_0_7.h | 2 +- > .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 +-- > .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 8 +++--- > drivers/gpu/drm/radeon/atombios.h | 16 +++++------ > drivers/gpu/drm/radeon/atombios_i2c.c | 4 +-- > drivers/gpu/drm/radeon/radeon_combios.c | 28 +++++++++---------- > drivers/gpu/drm/radeon/radeon_i2c.c | 10 +++---- > drivers/gpu/drm/radeon/radeon_mode.h | 6 ++-- > 28 files changed, 93 insertions(+), 93 deletions(-) > Hi Alex, Christian, Xinhui, David, Daniel, others This is the only patch in the series not merged into a tree. Is something needed from me to move this forward? Thanks, Easwar
I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave" with more appropriate terms. Inspired by and following on to Wolfram's series to fix drivers/i2c/[1], fix the terminology for users of the I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists in the specification. Compile tested, no functionality changes intended Please chime in with your opinions and suggestions. Since v3 of this patch series, we have settled on inclusive terminology in the i2c subsystem with Wolfram and Andi in commits d77367fff7c0 ("docs: i2c: summary: document use of inclusive language") and 20738cb9fa7a ("docs: i2c: summary: be clearer with 'controller/target' and 'adapter/client' pairs") This series is based on v6.10-rc7 [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/ ---- changelog: v3->v4: - v3 link: https://lore.kernel.org/all/20240508234342.2927398-1-eahariha@linux.microsoft.com/ - Settle on inclusive terminology in the i2c subsystem with Wolfram in commits d77367fff7c0 ("docs: i2c: summary: document use of inclusive language") and 20738cb9fa7a ("docs: i2c: summary: be clearer with 'controller/target' and 'adapter/client' pairs") - Rebase onto v6.10-rc7 v2->v3: - v2 link: https://lore.kernel.org/all/20240503181333.2336999-1-eahariha@linux.microsoft.com/ - Drop drivers/media patches [Mauro] - Pick up Acked-by Alex (modulo typo correction, hope you don't mind) [amdgpu, radeon] - Pick up Acked-by Thomas [smscufx, viafb] - Revert eDP change in drm/i915 [Jani, Rodrigo, Andi] v1->v2: - v1 link: https://lore.kernel.org/all/20240430173812.1423757-1-eahariha@linux.microsoft.com/ - Switch to specification verbiage master->controller, slave->target, drop usage of host/client [Thomas] - Pick up Reviewed-bys and Acked-bys from Rodrigo, Zhi, and Thomas [gma500, i915] - Fix up some straggler master/slave terms in amdgpu, cx25821, ivtv, cx23885 v0->v1: - v0 link: https://lore.kernel.org/all/20240329170038.3863998-1-eahariha@linux.microsoft.com/ - Drop drivers/infiniband patches [Leon, Dennis] - Switch to specification verbiage master->controller, slave->target, drop usage of client [Andi, Ville, Jani, Christian] - Add I3C specification version in commit messages [Andi] - Pick up Reviewed-bys from Martin and Simon [sfc] - Drop i2c/treewide patch to make this series independent from Wolfram's ([1]) [Wolfram] - Split away drm/nouveau patch to allow expansion into non-I2C non-inclusive terms Easwar Hariharan (6): drm/amdgpu, drm/radeon: Make I2C terminology more inclusive drm/gma500: Make I2C terminology more inclusive drm/i915: Make I2C terminology more inclusive sfc: falcon: Make I2C terminology more inclusive fbdev/smscufx: Make I2C terminology more inclusive fbdev/viafb: Make I2C terminology more inclusive .../gpu/drm/amd/amdgpu/amdgpu_atomfirmware.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/amdgpu_i2c.c | 10 +++---- drivers/gpu/drm/amd/amdgpu/atombios_i2c.c | 8 ++--- drivers/gpu/drm/amd/amdgpu/atombios_i2c.h | 2 +- drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c | 20 ++++++------- .../gpu/drm/amd/display/dc/bios/bios_parser.c | 2 +- .../drm/amd/display/dc/bios/bios_parser2.c | 2 +- .../drm/amd/display/dc/core/dc_link_exports.c | 4 +-- drivers/gpu/drm/amd/display/dc/dc.h | 2 +- drivers/gpu/drm/amd/display/dc/dce/dce_i2c.c | 4 +-- .../display/include/grph_object_ctrl_defs.h | 2 +- drivers/gpu/drm/amd/include/atombios.h | 2 +- drivers/gpu/drm/amd/include/atomfirmware.h | 26 ++++++++-------- .../powerplay/hwmgr/vega20_processpptables.c | 4 +-- .../amd/pm/powerplay/inc/smu11_driver_if.h | 2 +- .../inc/pmfw_if/smu11_driver_if_arcturus.h | 2 +- .../inc/pmfw_if/smu11_driver_if_navi10.h | 2 +- .../pmfw_if/smu11_driver_if_sienna_cichlid.h | 2 +- .../inc/pmfw_if/smu13_driver_if_aldebaran.h | 2 +- .../inc/pmfw_if/smu13_driver_if_v13_0_0.h | 2 +- .../inc/pmfw_if/smu13_driver_if_v13_0_7.h | 2 +- .../gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 +-- .../amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 8 ++--- drivers/gpu/drm/gma500/cdv_intel_lvds.c | 2 +- drivers/gpu/drm/gma500/intel_bios.c | 22 +++++++------- drivers/gpu/drm/gma500/intel_bios.h | 4 +-- drivers/gpu/drm/gma500/intel_gmbus.c | 2 +- drivers/gpu/drm/gma500/psb_drv.h | 2 +- drivers/gpu/drm/gma500/psb_intel_drv.h | 2 +- drivers/gpu/drm/gma500/psb_intel_lvds.c | 4 +-- drivers/gpu/drm/gma500/psb_intel_sdvo.c | 26 ++++++++-------- drivers/gpu/drm/i915/display/dvo_ch7017.c | 14 ++++----- drivers/gpu/drm/i915/display/dvo_ch7xxx.c | 18 +++++------ drivers/gpu/drm/i915/display/dvo_ivch.c | 16 +++++----- drivers/gpu/drm/i915/display/dvo_ns2501.c | 18 +++++------ drivers/gpu/drm/i915/display/dvo_sil164.c | 18 +++++------ drivers/gpu/drm/i915/display/dvo_tfp410.c | 18 +++++------ drivers/gpu/drm/i915/display/intel_bios.c | 22 +++++++------- .../gpu/drm/i915/display/intel_display_core.h | 2 +- drivers/gpu/drm/i915/display/intel_dsi.h | 2 +- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++------- drivers/gpu/drm/i915/display/intel_dvo.c | 14 ++++----- drivers/gpu/drm/i915/display/intel_dvo_dev.h | 2 +- drivers/gpu/drm/i915/display/intel_gmbus.c | 4 +-- drivers/gpu/drm/i915/display/intel_sdvo.c | 30 +++++++++---------- drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 +-- drivers/gpu/drm/i915/gvt/edid.c | 28 ++++++++--------- drivers/gpu/drm/i915/gvt/edid.h | 4 +-- drivers/gpu/drm/i915/gvt/opregion.c | 2 +- drivers/gpu/drm/radeon/atombios.h | 16 +++++----- drivers/gpu/drm/radeon/atombios_i2c.c | 4 +-- drivers/gpu/drm/radeon/radeon_combios.c | 28 ++++++++--------- drivers/gpu/drm/radeon/radeon_i2c.c | 10 +++---- drivers/gpu/drm/radeon/radeon_mode.h | 6 ++-- drivers/net/ethernet/sfc/falcon/falcon.c | 2 +- drivers/video/fbdev/smscufx.c | 4 +-- drivers/video/fbdev/via/chip.h | 8 ++--- drivers/video/fbdev/via/dvi.c | 24 +++++++-------- drivers/video/fbdev/via/lcd.c | 6 ++-- drivers/video/fbdev/via/via_aux.h | 2 +- drivers/video/fbdev/via/via_i2c.c | 12 ++++---- drivers/video/fbdev/via/vt1636.c | 6 ++-- 62 files changed, 275 insertions(+), 275 deletions(-) base-commit: 256abd8e550ce977b728be79a74e1729438b4948