| Message ID | 20240326223825.4084412-1-arnd@kernel.org |
|---|---|
| Headers | show |
| Series | enabled -Wformat-truncation for clang | expand |
Hi Arnd, Thank you for the patch. On Tue, Mar 26, 2024 at 11:38:00PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The name of the overlay does not fit into the fixed-length field: > > drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 > > Make it short enough by changing the string. > > Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index eb2297b37504..d35d2cf99998 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) > */ > info->fix = sh_mobile_lcdc_overlay_fix; > snprintf(info->fix.id, sizeof(info->fix.id), > - "SH Mobile LCDC Overlay %u", ovl->index); > + "SHMobile ovl %u", ovl->index); > info->fix.smem_start = ovl->dma_handle; > info->fix.smem_len = ovl->fb_size; > info->fix.line_length = ovl->pitch;
On Tue, 26 Mar 2024 23:37:59 +0100 Arnd Bergmann wrote: > I hope that the patches can get picked up by platform maintainers > directly, so the final patch can go in later on. platform == subsystem? :)
On 3/26/24 23:38, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The name of the overlay does not fit into the fixed-length field: > > drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be truncated; specified size is 16, but format string expands to at least 25 > > Make it short enough by changing the string. > > Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> applied to fbdev git tree. Thanks! Helge > --- > drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c b/drivers/video/fbdev/sh_mobile_lcdcfb.c > index eb2297b37504..d35d2cf99998 100644 > --- a/drivers/video/fbdev/sh_mobile_lcdcfb.c > +++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c > @@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct sh_mobile_lcdc_overlay *ovl) > */ > info->fix = sh_mobile_lcdc_overlay_fix; > snprintf(info->fix.id, sizeof(info->fix.id), > - "SH Mobile LCDC Overlay %u", ovl->index); > + "SHMobile ovl %u", ovl->index); > info->fix.smem_start = ovl->dma_handle; > info->fix.smem_len = ovl->fb_size; > info->fix.line_length = ovl->pitch;
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 26 Mar 2024 23:37:59 +0100 you wrote: > From: Arnd Bergmann <arnd@arndb.de> > > With randconfig build testing, I found only eight files that produce > warnings with clang when -Wformat-truncation is enabled. This means > we can just turn it on by default rather than only enabling it for > "make W=1". > > [...] Here is the summary with links: - [2/9] enetc: avoid truncating error message https://git.kernel.org/netdev/net-next/c/9046d581ed58 - [3/9] qed: avoid truncating work queue length https://git.kernel.org/netdev/net-next/c/954fd908f177 - [4/9] mlx5: avoid truncating error message https://git.kernel.org/netdev/net-next/c/b324a960354b You are awesome, thank you!
On Tue, 26 Mar 2024 23:37:59 +0100, Arnd Bergmann wrote: > With randconfig build testing, I found only eight files that produce > warnings with clang when -Wformat-truncation is enabled. This means > we can just turn it on by default rather than only enabling it for > "make W=1". > > Unfortunately, gcc produces a lot more warnings when the option > is enabled, so it's not yet possible to turn it on both both > compilers. > > [...] Applied to 6.9/scsi-fixes, thanks! [7/9] scsi: mylex: fix sysfs buffer lengths https://git.kernel.org/mkp/scsi/c/1197c5b2099f
From: Arnd Bergmann <arnd@arndb.de> With randconfig build testing, I found only eight files that produce warnings with clang when -Wformat-truncation is enabled. This means we can just turn it on by default rather than only enabling it for "make W=1". Unfortunately, gcc produces a lot more warnings when the option is enabled, so it's not yet possible to turn it on both both compilers. I hope that the patches can get picked up by platform maintainers directly, so the final patch can go in later on. Arnd Arnd Bergmann (9): fbdev: shmobile: fix snprintf truncation enetc: avoid truncating error message qed: avoid truncating work queue length mlx5: avoid truncating error message surface3_power: avoid format string truncation warning Input: IMS: fix printf string overflow scsi: mylex: fix sysfs buffer lengths ALSA: aoa: avoid false-positive format truncation warning kbuild: enable -Wformat-truncation on clang drivers/input/misc/ims-pcu.c | 4 ++-- drivers/net/ethernet/freescale/enetc/enetc.c | 2 +- .../ethernet/mellanox/mlx5/core/esw/bridge.c | 2 +- drivers/net/ethernet/qlogic/qed/qed_main.c | 9 ++++--- drivers/platform/surface/surface3_power.c | 2 +- drivers/scsi/myrb.c | 20 ++++++++-------- drivers/scsi/myrs.c | 24 +++++++++---------- drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +- scripts/Makefile.extrawarn | 2 ++ sound/aoa/soundbus/i2sbus/core.c | 2 +- 10 files changed, 35 insertions(+), 34 deletions(-)