mbox series

[v2,0/3] video: Simplify Kconfig options

Message ID 20240118090721.7995-1-tzimmermann@suse.de
Headers show
Series video: Simplify Kconfig options | expand

Message

Thomas Zimmermann Jan. 18, 2024, 9:05 a.m. UTC
Replace CONFIG_VIDEO_CMDLINE and CONFIG_VIDEO_NOMODESET by the single
option CONFIG_VIDEO. Select the latter for DRM or fbdev. Both original
options used to be selected in most cases, so this change simplifies
the Kconfig rules.

Since commit ca6c080eef42 ("arch/parisc: Detect primary video device
from device instance") architecture helpers for fbdev do not longer
require fbdev in their implementation and could be used for non-fbdev
code as well. Eventually guarding them with CONFIG_VIDEO will make
them available to any subsystem.

v2:
	* support CONFIG_FB_CORE=m via IS_ENABLED() (kernel test robot)

Thomas Zimmermann (3):
  video/cmdline: Introduce CONFIG_VIDEO for video= parameter
  video/cmdline: Hide __video_get_options() behind CONFIG_FB_CORE
  video/nomodeset: Select nomodeset= parameter with CONFIG_VIDEO

 drivers/gpu/drm/Kconfig           |  3 +--
 drivers/staging/sm750fb/Kconfig   |  1 -
 drivers/video/Kconfig             |  5 +----
 drivers/video/Makefile            |  3 +--
 drivers/video/cmdline.c           |  2 ++
 drivers/video/fbdev/Kconfig       | 37 -------------------------------
 drivers/video/fbdev/core/Kconfig  |  2 +-
 drivers/video/fbdev/core/fbmem.c  |  2 --
 drivers/video/fbdev/geode/Kconfig |  3 ---
 include/linux/fb.h                |  7 ------
 include/video/cmdline.h           |  8 ++-----
 11 files changed, 8 insertions(+), 65 deletions(-)


base-commit: 05b317e8457c8e2bd1a797c9440ec07b7f341584

Comments

Daniel Vetter Jan. 18, 2024, 2:17 p.m. UTC | #1
On Thu, Jan 18, 2024 at 10:05:25AM +0100, Thomas Zimmermann wrote:
> Replace CONFIG_VIDEO_CMDLINE and CONFIG_VIDEO_NOMODESET by the single
> option CONFIG_VIDEO. Select the latter for DRM or fbdev. Both original
> options used to be selected in most cases, so this change simplifies
> the Kconfig rules.
> 
> Since commit ca6c080eef42 ("arch/parisc: Detect primary video device
> from device instance") architecture helpers for fbdev do not longer
> require fbdev in their implementation and could be used for non-fbdev
> code as well. Eventually guarding them with CONFIG_VIDEO will make
> them available to any subsystem.
> 
> v2:
> 	* support CONFIG_FB_CORE=m via IS_ENABLED() (kernel test robot)
> 
> Thomas Zimmermann (3):
>   video/cmdline: Introduce CONFIG_VIDEO for video= parameter
>   video/cmdline: Hide __video_get_options() behind CONFIG_FB_CORE
>   video/nomodeset: Select nomodeset= parameter with CONFIG_VIDEO

On the series:

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

> 
>  drivers/gpu/drm/Kconfig           |  3 +--
>  drivers/staging/sm750fb/Kconfig   |  1 -
>  drivers/video/Kconfig             |  5 +----
>  drivers/video/Makefile            |  3 +--
>  drivers/video/cmdline.c           |  2 ++
>  drivers/video/fbdev/Kconfig       | 37 -------------------------------
>  drivers/video/fbdev/core/Kconfig  |  2 +-
>  drivers/video/fbdev/core/fbmem.c  |  2 --
>  drivers/video/fbdev/geode/Kconfig |  3 ---
>  include/linux/fb.h                |  7 ------
>  include/video/cmdline.h           |  8 ++-----
>  11 files changed, 8 insertions(+), 65 deletions(-)
> 
> 
> base-commit: 05b317e8457c8e2bd1a797c9440ec07b7f341584
> -- 
> 2.43.0
>
Thomas Zimmermann Jan. 23, 2024, 9:23 a.m. UTC | #2
Hi

Am 18.01.24 um 15:17 schrieb Daniel Vetter:
> On Thu, Jan 18, 2024 at 10:05:25AM +0100, Thomas Zimmermann wrote:
>> Replace CONFIG_VIDEO_CMDLINE and CONFIG_VIDEO_NOMODESET by the single
>> option CONFIG_VIDEO. Select the latter for DRM or fbdev. Both original
>> options used to be selected in most cases, so this change simplifies
>> the Kconfig rules.
>>
>> Since commit ca6c080eef42 ("arch/parisc: Detect primary video device
>> from device instance") architecture helpers for fbdev do not longer
>> require fbdev in their implementation and could be used for non-fbdev
>> code as well. Eventually guarding them with CONFIG_VIDEO will make
>> them available to any subsystem.
>>
>> v2:
>> 	* support CONFIG_FB_CORE=m via IS_ENABLED() (kernel test robot)
>>
>> Thomas Zimmermann (3):
>>    video/cmdline: Introduce CONFIG_VIDEO for video= parameter
>>    video/cmdline: Hide __video_get_options() behind CONFIG_FB_CORE
>>    video/nomodeset: Select nomodeset= parameter with CONFIG_VIDEO
> 
> On the series:
> 
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>

Pushed to drm-misc-next. Thanks a lot. FYI there's a conflict with 
commit 689237ab37c5 ("fbdev/intelfb: Remove driver").

Best regards
Thomas

> 
>>
>>   drivers/gpu/drm/Kconfig           |  3 +--
>>   drivers/staging/sm750fb/Kconfig   |  1 -
>>   drivers/video/Kconfig             |  5 +----
>>   drivers/video/Makefile            |  3 +--
>>   drivers/video/cmdline.c           |  2 ++
>>   drivers/video/fbdev/Kconfig       | 37 -------------------------------
>>   drivers/video/fbdev/core/Kconfig  |  2 +-
>>   drivers/video/fbdev/core/fbmem.c  |  2 --
>>   drivers/video/fbdev/geode/Kconfig |  3 ---
>>   include/linux/fb.h                |  7 ------
>>   include/video/cmdline.h           |  8 ++-----
>>   11 files changed, 8 insertions(+), 65 deletions(-)
>>
>>
>> base-commit: 05b317e8457c8e2bd1a797c9440ec07b7f341584
>> -- 
>> 2.43.0
>>
>