From patchwork Mon Jan 31 05:43:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: arshad hussain X-Patchwork-Id: 539463 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F09AAC433EF for ; Mon, 31 Jan 2022 05:43:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232311AbiAaFnw (ORCPT ); Mon, 31 Jan 2022 00:43:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56768 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229711AbiAaFnv (ORCPT ); Mon, 31 Jan 2022 00:43:51 -0500 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A5ED3C061714 for ; Sun, 30 Jan 2022 21:43:50 -0800 (PST) Received: by mail-io1-xd34.google.com with SMTP id n17so15344930iod.4 for ; Sun, 30 Jan 2022 21:43:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:from:date:message-id:subject:to:cc; bh=dSQA6YIC7NS85JzEAYysawlupOe+DbrucpjQ8TclmuQ=; b=qAdZgPGtXl7a9V0MGC8i/n12XE91DUALNaJBk1lholx+SBndnpAfCoKkV0i5QgrvMO 06heFF5Ysd8OiScmVKu/B7N0Lw2CQZRr2Rrg11S+4EVF1HeCaz5HMbFUkngBXJgFd4qG /+7NqGHuBjVNAT9R1VGrSeGqVAvyoVoKDyW0QxlioAR419TgHkh2LQflTN4yVMeXVLbX E8wFnHzOc/XyxtbRAjAuumNHIdy9yed5idEx4gKB87b5116Zw/FJdAzbD1cW82pBEHRG ovAMs/bspQXDDzytHdvBWCPvH/IZixYvhpcmwwjADn70kv5cM2PAsk4ANE/+754GMGL4 Mf9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=dSQA6YIC7NS85JzEAYysawlupOe+DbrucpjQ8TclmuQ=; b=ddOLYl4OJH2snPiYlZF1/jiv6TjmkpyTyiwND04ydGVpNY05PV++BflVtzETkpKTqN Y/rBDq/js2TKiL7TEkykmD72K/1sGduQRm7qsGryadDS5TL1CGzlMGNGdDfymeijJaB6 WSKY9QcWvkW6wZMJT/VYIQfABizzOKfYkO96/bstIUowDsv0TweN5PdB+byIZAf4CpQW wQd0rx/6Yeg/dzEZ8QdpnWEx9bDaXOwDb9EO3UuIopNDD0kPMmbpGP4Q1wm1fagBmCrj gr+zmKb0/sEoN4qb8RIbhxQJBjsjak4itjT0H2ECGDC8HB4wrbB9a6eQnxVXSEnQQHjq Q1cg== X-Gm-Message-State: AOAM531blWrDL0DvykkC9HIxX4BKcFu9fAcAK3zDqe5+bX3qc0WjkdII LOx83d+fal1ciLIi3SeBCQBSQcB984g+nItxGCw= X-Google-Smtp-Source: ABdhPJwdWtiQ5604IMAsGu3kpMehnGDCmlF3keMyqV+En4dVenpZ8TxoyIdmIUph5fjWt28mjraA1KcKHhh/56id97E= X-Received: by 2002:a05:6602:1652:: with SMTP id y18mr10380361iow.187.1643607829926; Sun, 30 Jan 2022 21:43:49 -0800 (PST) MIME-Version: 1.0 From: arshad hussain Date: Mon, 31 Jan 2022 11:13:39 +0530 Message-ID: Subject: [PATCH] efi: Move error message to warning To: Ard Biesheuvel , linux-efi@vger.kernel.org Cc: Husein Bahrainwala Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Error message "...kernel image not aligned on 64k boundary" does not seem to be a real error as it does not cause any functional issue or stops the system from booting or working. Move this "error" to "warning" as this error is not handled at the moment. Also, watching "warn" message instead of "ERROR" calms the end-user. Cc: Ard Biesheuvel Cc: linux-efi@vger.kernel.org Signed-off-by: Arshad Hussain Signed-off-by: Husein Bahrainwala --- drivers/firmware/efi/libstub/arm64-stub.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) kernel_memsize = kernel_size + (_end - _edata); diff --git a/drivers/firmware/efi/libstub/arm64-stub.c b/drivers/firmware/efi/libstub/arm64-stub.c index 2363fee92..5ed09be49 100644 --- a/drivers/firmware/efi/libstub/arm64-stub.c +++ b/drivers/firmware/efi/libstub/arm64-stub.c @@ -120,8 +120,8 @@ efi_status_t handle_kernel_image(unsigned long *image_addr, efi_err("FIRMWARE BUG: efi_loaded_image_t::image_base has bogus value\n"); if (!IS_ALIGNED((u64)_text, EFI_KIMG_ALIGN)) - efi_err("FIRMWARE BUG: kernel image not aligned on %ldk boundary\n", - EFI_KIMG_ALIGN >> 10); + efi_warn("FIRMWARE BUG: kernel image not aligned on %ldk boundary\n", + EFI_KIMG_ALIGN >> 10); kernel_size = _edata - _text;