| Message ID | 20220105235012.2497118-2-eric.snowberg@oracle.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v9,1/8] integrity: Fix warning about missing prototypes | expand |
On Wed, Jan 05, 2022 at 06:50:05PM -0500, Eric Snowberg wrote: > make W=1 generates the following warning in keyring_handler.c > > security/integrity/platform_certs/keyring_handler.c:71:30: warning: no previous prototype for get_handler_for_db [-Wmissing-prototypes] > __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type) > ^~~~~~~~~~~~~~~~~~ > security/integrity/platform_certs/keyring_handler.c:82:30: warning: no previous prototype for get_handler_for_dbx [-Wmissing-prototypes] > __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type) > ^~~~~~~~~~~~~~~~~~~ > Add the missing prototypes by including keyring_handler.h. > > Reported-by: kernel test robot <lkp@intel.com> > Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com> > Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> > --- > v7: Initial version > v8: Code unmodified from v7 added Mimi's Reviewed-by > v9: Unmodified from v8 > --- > security/integrity/platform_certs/keyring_handler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/security/integrity/platform_certs/keyring_handler.c b/security/integrity/platform_certs/keyring_handler.c > index 5604bd57c990..e9791be98fd9 100644 > --- a/security/integrity/platform_certs/keyring_handler.c > +++ b/security/integrity/platform_certs/keyring_handler.c > @@ -9,6 +9,7 @@ > #include <keys/asymmetric-type.h> > #include <keys/system_keyring.h> > #include "../integrity.h" > +#include "keyring_handler.h" > > static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID; > static efi_guid_t efi_cert_x509_sha256_guid __initdata = > -- > 2.18.4 > Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> BR, Jarkko
diff --git a/security/integrity/platform_certs/keyring_handler.c b/security/integrity/platform_certs/keyring_handler.c index 5604bd57c990..e9791be98fd9 100644 --- a/security/integrity/platform_certs/keyring_handler.c +++ b/security/integrity/platform_certs/keyring_handler.c @@ -9,6 +9,7 @@ #include <keys/asymmetric-type.h> #include <keys/system_keyring.h> #include "../integrity.h" +#include "keyring_handler.h" static efi_guid_t efi_cert_x509_guid __initdata = EFI_CERT_X509_GUID; static efi_guid_t efi_cert_x509_sha256_guid __initdata =
make W=1 generates the following warning in keyring_handler.c security/integrity/platform_certs/keyring_handler.c:71:30: warning: no previous prototype for get_handler_for_db [-Wmissing-prototypes] __init efi_element_handler_t get_handler_for_db(const efi_guid_t *sig_type) ^~~~~~~~~~~~~~~~~~ security/integrity/platform_certs/keyring_handler.c:82:30: warning: no previous prototype for get_handler_for_dbx [-Wmissing-prototypes] __init efi_element_handler_t get_handler_for_dbx(const efi_guid_t *sig_type) ^~~~~~~~~~~~~~~~~~~ Add the missing prototypes by including keyring_handler.h. Reported-by: kernel test robot <lkp@intel.com> Signed-off-by: Eric Snowberg <eric.snowberg@oracle.com> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com> --- v7: Initial version v8: Code unmodified from v7 added Mimi's Reviewed-by v9: Unmodified from v8 --- security/integrity/platform_certs/keyring_handler.c | 1 + 1 file changed, 1 insertion(+)