From patchwork Wed Oct 23 17:31:58 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 177338 Delivered-To: patch@linaro.org Received: by 2002:a92:409a:0:0:0:0:0 with SMTP id d26csp1040291ill; Wed, 23 Oct 2019 10:32:08 -0700 (PDT) X-Google-Smtp-Source: APXvYqwO2iF4wny1dcFT/Mm5AiAl5Thxh1ERDS9AnRt3rsNwmgyM8jw+lFAAH8Hcv5DbsOP/i01z X-Received: by 2002:a50:bac2:: with SMTP id x60mr38400207ede.96.1571851928655; Wed, 23 Oct 2019 10:32:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1571851928; cv=none; d=google.com; s=arc-20160816; b=x0XKDNLKwG77r9qyKn97kvCw41+6imO7r4ft16FkhdCam8rvSdoygKatRR/LQUaApH /9s/PLF38NLooCNu/Hy9/7b6FpQUMzF1pzSsslHB96NAyw8KVMZVM+2mlnkhsiYnqBd9 C4Q/n81qc3AiYhx0OAo9XZdwnaasg2mlV3ZN0Ou8vltPUA470T4kq9ykhkNPl4kfDCpT LCi903qPj16TpViDTpWLTympGJQXc6pP9Aqa+hx3bmhIOC0Acuc5hZGhujQooBP3lwCC 99x5nbTcjdG1u+AF0SCo/qF1FrX7uL4kQxsjTpwEYQosdnKTmFAzn7KX4qrr5ZfIyOZE 3vJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=wkSWabqYVL066Xoh2VEh6KAZRi4MksvH/vrykc5mNu8=; b=nqPXQKAjzy/em3wn6gSwLs+N8WmnkjdsfxsrwWhkeQFYsIh3omwYiyVD/W+xoj12iw 6EjW/jlk6qgIZYTeBAwB1dq4F6Fw3ecnKrTywHU4uqAjBFSyX6II+LnaMnuSlf+NH7dr y6KqwJFZrNlbLgOvnFhujdI5h2RQYuPBWDfy1cupKg7mZ4onUxIGzWo+9Zd1YDB2NYaM /9NbwhdbAKXb18eFopt8enPxKJzO2gtTMNdydb2DPurReysrZPcobSj1VVKFWYpB/pc6 Wf9aOLMeGII2wLLwcVduEK4Bu6t+MEd4P518wWvJ54ukmzJQShDEek/+vkLoV0EL/VwD 9Efg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CgvSGucE; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z44si6691527edb.418.2019.10.23.10.32.08; Wed, 23 Oct 2019 10:32:08 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=CgvSGucE; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729947AbfJWRcG (ORCPT + 3 others); Wed, 23 Oct 2019 13:32:06 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:41484 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729871AbfJWRcF (ORCPT ); Wed, 23 Oct 2019 13:32:05 -0400 Received: by mail-wr1-f66.google.com with SMTP id p4so23019856wrm.8 for ; Wed, 23 Oct 2019 10:32:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wkSWabqYVL066Xoh2VEh6KAZRi4MksvH/vrykc5mNu8=; b=CgvSGucEXePDgb8HdjupEKmoCsfnrmGoc0SxZhaKnsPQEzyPYUcSQFwcJnbR0krN8q VX72j5JlYGgnGcQm/oQQJ/ljNtlO6cDakEe+QRyytOLgpzuq66qzM+4QvHSzgodKPxwn vVGkk/HhJXGSojQj5WKh3I8K6mofh1N3nPF8TbIIazVdOWWFCjGFBq2MAEwDI7VX52TG N2IiLk5LnzGwvso2360v8V3/W8mMJdOErj2q7OQSLoluHuypaUfiwBhkB02iR8Ipb1Zc hrEcPwSM+UGTS54oreMCu45yPBRz6RpSGxjSJcGrqv3XGl71gi1jOfU76YejZT6qNZO+ z8AA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wkSWabqYVL066Xoh2VEh6KAZRi4MksvH/vrykc5mNu8=; b=gSSf7k6n6OXcI91SQ18cuOjcxELItQJa4AbQxeKAtekZmjbitSad0L5g0Oqalnrt63 6U9mxczJ5sI5jbLQkyvvjmV8JDFJ9xyScawfGPXWl90yqFMOEXiV5Ls9DhgOcmD0UorV lP8MMoRES9Nxksc13eyAKxvT5ub5Y9UyGdg7hVgfbVrdyPNr4wWiuwKY+1QnkhibNvkQ 1pDD1VPkqgxY2v6ZeWqS65nVXK5CK4n1l8wFA0jr8pU0WAnnLBpzEEbfm5WEKNUzu08d VFLdMaIo9R7fZOKz9bmiCYdgvhAQ/BHAu9Z+FCiP1dxcQHL6/P0u5R+fX+/gXEsdgB5i f6UA== X-Gm-Message-State: APjAAAUGxyGANkqASuVasKk4k+gokXHyJ4g8jpL8bDK6ooenJtlqNeb7 ts4wm1m9YgBle019uitWjhgkzIIFQYqkyZPb X-Received: by 2002:adf:ee10:: with SMTP id y16mr9429013wrn.67.1571851923689; Wed, 23 Oct 2019 10:32:03 -0700 (PDT) Received: from e123331-lin.home (lfbn-mar-1-643-104.w90-118.abo.wanadoo.fr. [90.118.215.104]) by smtp.gmail.com with ESMTPSA id f7sm14900374wre.68.2019.10.23.10.32.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 10:32:02 -0700 (PDT) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner Cc: Jerry Snitselaar , Ard Biesheuvel , linux-kernel@vger.kernel.org Subject: [PATCH 2/5] efi/tpm: return -EINVAL when determining tpm final events log size fails Date: Wed, 23 Oct 2019 19:31:58 +0200 Message-Id: <20191023173201.6607-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20191023173201.6607-1-ard.biesheuvel@linaro.org> References: <20191023173201.6607-1-ard.biesheuvel@linaro.org> X-ARM-No-Footer: FoSSMail Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Jerry Snitselaar Currently nothing checks the return value of efi_tpm_eventlog_init, but in case that changes in the future make sure an error is returned when it fails to determine the tpm final events log size. Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after ...") Reviewed-by: Jarkko Sakkinen Suggested-by: Dan Carpenter Signed-off-by: Jerry Snitselaar Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/tpm.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c index ebd7977653a8..31f9f0e369b9 100644 --- a/drivers/firmware/efi/tpm.c +++ b/drivers/firmware/efi/tpm.c @@ -88,6 +88,7 @@ int __init efi_tpm_eventlog_init(void) if (tbl_size < 0) { pr_err(FW_BUG "Failed to parse event in TPM Final Events Log\n"); + ret = -EINVAL; goto out_calc; }