From patchwork Thu Jan 31 11:51:45 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 157140 Delivered-To: patch@linaro.org Received: by 2002:a02:48:0:0:0:0:0 with SMTP id 69csp7111402jaa; Thu, 31 Jan 2019 03:51:57 -0800 (PST) X-Google-Smtp-Source: ALg8bN7tRPj4Ku9c+WCP8M/Gt/N4cukDNIO82a16GzB7M4pZyLNPvSY5BlqbYwjOgTrRA2ggiTMB X-Received: by 2002:a17:902:82c2:: with SMTP id u2mr34433761plz.110.1548935517739; Thu, 31 Jan 2019 03:51:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548935517; cv=none; d=google.com; s=arc-20160816; b=QJnYkM0YWMyyP4irUAvupGmzWkbfMyFJo1FCV4XautYVfsDvBnJdBztA0e19xeTKaw Hx8PqP+4gW7/ig4Gn+ROvR5p8ldkm+AKbXCrKvyfudBTdiMus3+02D/aWcOEbTE0yOcz PUbm2cev0RMjvh3zdXnuwGe5vDuIJvai+3cp2lmZabcTyokUvPuzD39e2dgJa3IGs+SZ 9QV4uFszogZivH7VzBHQfnhXywETPOY45224ZokoVstrTHWLNAucpxu5Su8915gcBsRw 1Bv1T/+v+xB5/k7CYemCE02qhThnMXjl8KamiLlgPYK+dFIAdEG83gdQpRTKsb1fNlOo u4QQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=wbMPzpn8NfRgi7RFPH4XE4+uwdPNc56zI0O9bxK6Lg4=; b=ra2KJYo7OqFXwXqG8aTvwQmYBqK+bbqtEQITm48NAZTPOCKJXn/eStxOP2IXdH4HH2 zako3nty4xSjeU9jkpwoJX4Hctpymulgk0GhSenfLr5IH4wJI7QIpPb9e6boJWmN2VMC mp+evSVfpK9DxpdacsxxUNrtBXY7Y/5YHJr+tW0hfuBXLp4Pv7T9pbTPSVluZ2Qbvsh1 bzPouyImowHICr2A7U6//MuFpmbcWKKiu+zUwRIR8DcM0SzSwLOKhQDCqEWiCUhuX325 nYgXnEO9OuKlfpTazQfKuDZnX+60b+ihaKPIgGwPeDJZRS/DhmSBQu8r+j223zNrKMOn a7rw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jnV6OeKi; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z67si4322247pfb.268.2019.01.31.03.51.57; Thu, 31 Jan 2019 03:51:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=jnV6OeKi; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728138AbfAaLv5 (ORCPT + 3 others); Thu, 31 Jan 2019 06:51:57 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43324 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726863AbfAaLv5 (ORCPT ); Thu, 31 Jan 2019 06:51:57 -0500 Received: by mail-wr1-f66.google.com with SMTP id r10so2912975wrs.10 for ; Thu, 31 Jan 2019 03:51:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wbMPzpn8NfRgi7RFPH4XE4+uwdPNc56zI0O9bxK6Lg4=; b=jnV6OeKi40I3j9lndUeZXwG6TGAcis1nStHp2Ah/zfxLsgeEkthu7OQfjT2jDkwrxS QWA3sYMkEycGAwfZi+j0GNoJqFXNvqPqsQS+2tbQBM0FWCv66j28D/7a1wsM1WkkuMSb 7dcA9ozZf5FFaTlq/f1zFqrCLHVr8rAIDptC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wbMPzpn8NfRgi7RFPH4XE4+uwdPNc56zI0O9bxK6Lg4=; b=W7bkfgLWPbZ0DyC49rdAnxeX1jFIkZf89zQSKWjzfy6ZNsrg7LX8dmJ9gkDkh0IuR0 ZEYYXbI2U3F9WbwIHDfqwg6gA2SxU1dBhJgR/DghRT0nvLkEoyaZ5alIoLqiAuZp/z+5 ZfyOWKmsyiAVdRb6Cy0teiEKISOfeTkT9tZU84hnIgV9CTvydrnARwM4AOM+EOcAxJTz 24YCpSOD2NOWm2ymNB+Y1GxOcLK6EjiCRf8Cp3Jby6maxkChTJDZeKEojANix9ksrpa7 /xKOADX4ZGkFHXlNhPizc8DbVI52AhPB2U3gddBEzm/CKHJBpUWfFBQmPmIcb/dDZ8Jv 1d5w== X-Gm-Message-State: AJcUukcYiWs18NBIApxjR97lrP+BkksmpT5P4D9mEG4XS6ZoSbx6lifp DbdLTzS3lpz8y4CN9Z+uUyw6VyGGOH4= X-Received: by 2002:adf:e891:: with SMTP id d17mr36704197wrm.140.1548935513681; Thu, 31 Jan 2019 03:51:53 -0800 (PST) Received: from localhost.localdomain (aputeaux-684-1-39-7.w90-86.abo.wanadoo.fr. [90.86.94.7]) by smtp.gmail.com with ESMTPSA id w10sm5807714wmb.1.2019.01.31.03.51.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 03:51:52 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, x86@kernel.org, Ard Biesheuvel , corbet@lwn.net, leif.lindholm@linaro.org, graeme.gregory@linaro.org, mingo@redhat.com, tglx@linutronix.de, linux-doc@vger.kernel.org, agraf@suse.de, pjones@redhat.com Subject: [PATCH v3 2/2] efi: x86: convert x86 EFI earlyprintk into generic earlycon implementation Date: Thu, 31 Jan 2019 12:51:45 +0100 Message-Id: <20190131115145.4634-3-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190131115145.4634-1-ard.biesheuvel@linaro.org> References: <20190131115145.4634-1-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Move the x86 EFI earlyprintk implementation to a shared location under drivers/firmware and tweak it slightly so we can expose it as an earlycon implementation (which is generic) rather than earlyprintk (which is only implemented for a few architectures) This also involves switching to write-combine mappings by default (which is required on ARM since device mappings lack memory semantics, and so memcpy/memset may not be used on them), and adding support for shared memory framebuffers on cache coherent non-x86 systems (which do not tolerate mismatched attributes) Note that 32-bit ARM does not populate its struct screen_info early enough for earlycon=efifb to work, nor is its early_memremap operational early enough, so it is disabled there. Itanium has its own asm/early_ioremap.h header which does not declare early_memremap_prot (and it never implemented earlyprintk=efi in the first place) so let's just disable it there as well. Reviewed-by: Alexander Graf Signed-off-by: Ard Biesheuvel --- Documentation/admin-guide/kernel-parameters.txt | 8 +- arch/x86/Kconfig.debug | 10 -- arch/x86/include/asm/efi.h | 1 - arch/x86/kernel/early_printk.c | 4 - arch/x86/platform/efi/Makefile | 1 - drivers/firmware/efi/Kconfig | 6 + drivers/firmware/efi/Makefile | 1 + arch/x86/platform/efi/early_printk.c => drivers/firmware/efi/earlycon.c | 130 ++++++++------------ 8 files changed, 63 insertions(+), 98 deletions(-) -- 2.20.1 diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt index b799bcf67d7b..76dd3baa31e0 100644 --- a/Documentation/admin-guide/kernel-parameters.txt +++ b/Documentation/admin-guide/kernel-parameters.txt @@ -1073,9 +1073,15 @@ specified address. The serial port must already be setup and configured. Options are not yet supported. + efifb,[options] + Start an early, unaccelerated console on the EFI + memory mapped framebuffer (if available). On cache + coherent non-x86 systems that use system memory for + the framebuffer, pass the 'ram' option so that it is + mapped with the correct attributes. + earlyprintk= [X86,SH,ARM,M68k,S390] earlyprintk=vga - earlyprintk=efi earlyprintk=sclp earlyprintk=xen earlyprintk=serial[,ttySn[,baudrate]] diff --git a/arch/x86/Kconfig.debug b/arch/x86/Kconfig.debug index 0723dff17e6c..15d0fbe27872 100644 --- a/arch/x86/Kconfig.debug +++ b/arch/x86/Kconfig.debug @@ -40,16 +40,6 @@ config EARLY_PRINTK_DBGP with klogd/syslogd or the X server. You should normally say N here, unless you want to debug such a crash. You need usb debug device. -config EARLY_PRINTK_EFI - bool "Early printk via the EFI framebuffer" - depends on EFI && EARLY_PRINTK - select FONT_SUPPORT - ---help--- - Write kernel log output directly into the EFI framebuffer. - - This is useful for kernel debugging when your machine crashes very - early before the console code is initialized. - config EARLY_PRINTK_USB_XDBC bool "Early printk via the xHCI debug port" depends on EARLY_PRINTK && PCI diff --git a/arch/x86/include/asm/efi.h b/arch/x86/include/asm/efi.h index a37378f986ec..08ebb2270d87 100644 --- a/arch/x86/include/asm/efi.h +++ b/arch/x86/include/asm/efi.h @@ -170,7 +170,6 @@ static inline bool efi_runtime_supported(void) return false; } -extern struct console early_efi_console; extern void parse_efi_setup(u64 phys_addr, u32 data_len); extern void efifb_setup_from_dmi(struct screen_info *si, const char *opt); diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c index 374a52fa5296..9b33904251a9 100644 --- a/arch/x86/kernel/early_printk.c +++ b/arch/x86/kernel/early_printk.c @@ -388,10 +388,6 @@ static int __init setup_early_printk(char *buf) if (!strncmp(buf, "xen", 3)) early_console_register(&xenboot_console, keep); #endif -#ifdef CONFIG_EARLY_PRINTK_EFI - if (!strncmp(buf, "efi", 3)) - early_console_register(&early_efi_console, keep); -#endif #ifdef CONFIG_EARLY_PRINTK_USB_XDBC if (!strncmp(buf, "xdbc", 4)) early_xdbc_parse_parameter(buf + 4); diff --git a/arch/x86/platform/efi/Makefile b/arch/x86/platform/efi/Makefile index e4dc3862d423..fe29f3f5d384 100644 --- a/arch/x86/platform/efi/Makefile +++ b/arch/x86/platform/efi/Makefile @@ -3,5 +3,4 @@ OBJECT_FILES_NON_STANDARD_efi_thunk_$(BITS).o := y OBJECT_FILES_NON_STANDARD_efi_stub_$(BITS).o := y obj-$(CONFIG_EFI) += quirks.o efi.o efi_$(BITS).o efi_stub_$(BITS).o -obj-$(CONFIG_EARLY_PRINTK_EFI) += early_printk.o obj-$(CONFIG_EFI_MIXED) += efi_thunk_$(BITS).o diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig index 89110dfc7127..190be0b1d109 100644 --- a/drivers/firmware/efi/Kconfig +++ b/drivers/firmware/efi/Kconfig @@ -198,3 +198,9 @@ config EFI_DEV_PATH_PARSER bool depends on ACPI default n + +config EFI_EARLYCON + def_bool y + depends on SERIAL_EARLYCON && !ARM && !IA64 + select FONT_SUPPORT + select ARCH_USE_MEMREMAP_PROT diff --git a/drivers/firmware/efi/Makefile b/drivers/firmware/efi/Makefile index 5f9f5039de50..d2d0d2030620 100644 --- a/drivers/firmware/efi/Makefile +++ b/drivers/firmware/efi/Makefile @@ -30,5 +30,6 @@ arm-obj-$(CONFIG_EFI) := arm-init.o arm-runtime.o obj-$(CONFIG_ARM) += $(arm-obj-y) obj-$(CONFIG_ARM64) += $(arm-obj-y) obj-$(CONFIG_EFI_CAPSULE_LOADER) += capsule-loader.o +obj-$(CONFIG_EFI_EARLYCON) += earlycon.o obj-$(CONFIG_UEFI_CPER_ARM) += cper-arm.o obj-$(CONFIG_UEFI_CPER_X86) += cper-x86.o diff --git a/arch/x86/platform/efi/early_printk.c b/drivers/firmware/efi/earlycon.c similarity index 45% rename from arch/x86/platform/efi/early_printk.c rename to drivers/firmware/efi/earlycon.c index 7138bc7a265c..163d8204b190 100644 --- a/arch/x86/platform/efi/early_printk.c +++ b/drivers/firmware/efi/earlycon.c @@ -10,104 +10,68 @@ #include #include #include -#include +#include +#include + +#include static const struct font_desc *font; static u32 efi_x, efi_y; -static void *efi_fb; -static bool early_efi_keep; - -/* - * efi earlyprintk need use early_ioremap to map the framebuffer. - * But early_ioremap is not usable for earlyprintk=efi,keep, ioremap should - * be used instead. ioremap will be available after paging_init() which is - * earlier than initcall callbacks. Thus adding this early initcall function - * early_efi_map_fb to map the whole efi framebuffer. - */ -static __init int early_efi_map_fb(void) -{ - u64 base, size; +static u64 fb_base; +static pgprot_t fb_prot; - if (!early_efi_keep) - return 0; - - base = boot_params.screen_info.lfb_base; - if (boot_params.screen_info.capabilities & VIDEO_CAPABILITY_64BIT_BASE) - base |= (u64)boot_params.screen_info.ext_lfb_base << 32; - size = boot_params.screen_info.lfb_size; - efi_fb = ioremap(base, size); - - return efi_fb ? 0 : -ENOMEM; -} -early_initcall(early_efi_map_fb); - -/* - * early_efi_map maps efi framebuffer region [start, start + len -1] - * In case earlyprintk=efi,keep we have the whole framebuffer mapped already - * so just return the offset efi_fb + start. - */ -static __ref void *early_efi_map(unsigned long start, unsigned long len) +static __ref void *efi_earlycon_map(unsigned long start, unsigned long len) { - u64 base; - - base = boot_params.screen_info.lfb_base; - if (boot_params.screen_info.capabilities & VIDEO_CAPABILITY_64BIT_BASE) - base |= (u64)boot_params.screen_info.ext_lfb_base << 32; - - if (efi_fb) - return (efi_fb + start); - else - return early_ioremap(base + start, len); + return early_memremap_prot(fb_base + start, len, pgprot_val(fb_prot)); } -static __ref void early_efi_unmap(void *addr, unsigned long len) +static __ref void efi_earlycon_unmap(void *addr, unsigned long len) { - if (!efi_fb) - early_iounmap(addr, len); + early_memunmap(addr, len); } -static void early_efi_clear_scanline(unsigned int y) +static void efi_earlycon_clear_scanline(unsigned int y) { unsigned long *dst; u16 len; - len = boot_params.screen_info.lfb_linelength; - dst = early_efi_map(y*len, len); + len = screen_info.lfb_linelength; + dst = efi_earlycon_map(y*len, len); if (!dst) return; memset(dst, 0, len); - early_efi_unmap(dst, len); + efi_earlycon_unmap(dst, len); } -static void early_efi_scroll_up(void) +static void efi_earlycon_scroll_up(void) { unsigned long *dst, *src; u16 len; u32 i, height; - len = boot_params.screen_info.lfb_linelength; - height = boot_params.screen_info.lfb_height; + len = screen_info.lfb_linelength; + height = screen_info.lfb_height; for (i = 0; i < height - font->height; i++) { - dst = early_efi_map(i*len, len); + dst = efi_earlycon_map(i*len, len); if (!dst) return; - src = early_efi_map((i + font->height) * len, len); + src = efi_earlycon_map((i + font->height) * len, len); if (!src) { - early_efi_unmap(dst, len); + efi_earlycon_unmap(dst, len); return; } memmove(dst, src, len); - early_efi_unmap(src, len); - early_efi_unmap(dst, len); + efi_earlycon_unmap(src, len); + efi_earlycon_unmap(dst, len); } } -static void early_efi_write_char(u32 *dst, unsigned char c, unsigned int h) +static void efi_earlycon_write_char(u32 *dst, unsigned char c, unsigned int h) { const u32 color_black = 0x00000000; const u32 color_white = 0x00ffffff; @@ -128,14 +92,14 @@ static void early_efi_write_char(u32 *dst, unsigned char c, unsigned int h) } static void -early_efi_write(struct console *con, const char *str, unsigned int num) +efi_earlycon_write(struct console *con, const char *str, unsigned int num) { struct screen_info *si; unsigned int len; const char *s; void *dst; - si = &boot_params.screen_info; + si = &screen_info; len = si->lfb_linelength; while (num) { @@ -155,7 +119,7 @@ early_efi_write(struct console *con, const char *str, unsigned int num) for (h = 0; h < font->height; h++) { unsigned int n, x; - dst = early_efi_map((efi_y + h) * len, len); + dst = efi_earlycon_map((efi_y + h) * len, len); if (!dst) return; @@ -164,12 +128,12 @@ early_efi_write(struct console *con, const char *str, unsigned int num) x = efi_x; while (n-- > 0) { - early_efi_write_char(dst + x*4, *s, h); + efi_earlycon_write_char(dst + x*4, *s, h); x += font->width; s++; } - early_efi_unmap(dst, len); + efi_earlycon_unmap(dst, len); } num -= count; @@ -192,26 +156,39 @@ early_efi_write(struct console *con, const char *str, unsigned int num) u32 i; efi_y -= font->height; - early_efi_scroll_up(); + efi_earlycon_scroll_up(); for (i = 0; i < font->height; i++) - early_efi_clear_scanline(efi_y + i); + efi_earlycon_clear_scanline(efi_y + i); } } } -static __init int early_efi_setup(struct console *con, char *options) +static int __init efi_earlycon_setup(struct earlycon_device *device, + const char *opt) { struct screen_info *si; u16 xres, yres; u32 i; - si = &boot_params.screen_info; + if (screen_info.orig_video_isVGA != VIDEO_TYPE_EFI) + return -ENODEV; + + fb_base = screen_info.lfb_base; + if (screen_info.capabilities & VIDEO_CAPABILITY_64BIT_BASE) + fb_base |= (u64)screen_info.ext_lfb_base << 32; + + if (opt && !strcmp(opt, "ram")) + fb_prot = PAGE_KERNEL; + else + fb_prot = pgprot_writecombine(PAGE_KERNEL); + + si = &screen_info; xres = si->lfb_width; yres = si->lfb_height; /* - * early_efi_write_char() implicitly assumes a framebuffer with + * efi_earlycon_write_char() implicitly assumes a framebuffer with * 32-bits per pixel. */ if (si->lfb_depth != 32) @@ -223,18 +200,9 @@ static __init int early_efi_setup(struct console *con, char *options) efi_y = rounddown(yres, font->height) - font->height; for (i = 0; i < (yres - efi_y) / font->height; i++) - early_efi_scroll_up(); + efi_earlycon_scroll_up(); - /* early_console_register will unset CON_BOOT in case ,keep */ - if (!(con->flags & CON_BOOT)) - early_efi_keep = true; + device->con->write = efi_earlycon_write; return 0; } - -struct console early_efi_console = { - .name = "earlyefi", - .write = early_efi_write, - .setup = early_efi_setup, - .flags = CON_PRINTBUFFER, - .index = -1, -}; +EARLYCON_DECLARE(efifb, efi_earlycon_setup);