From patchwork Wed Nov 14 17:55:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 151106 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp5992647ljp; Wed, 14 Nov 2018 09:56:01 -0800 (PST) X-Google-Smtp-Source: AJdET5ddOGsvpu4Z7N/skdU5ndwCS8aCg/HY4ELkqWg2DhPQIFmOEQ6wS7NT6wrHAOGmJkMjuFOM X-Received: by 2002:a63:134f:: with SMTP id 15mr2639213pgt.19.1542218161214; Wed, 14 Nov 2018 09:56:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542218161; cv=none; d=google.com; s=arc-20160816; b=EwtXifnz/LN2MVSzk7Pppx2AACxRhz+QYm7XvUdKacZ2UservQ0ol0heWu+7H5jCoV 4y0plwXd53nH4qD6IfY0P/F7dhkOMXvau2DVZWmAfjRaTjEZR/f2loBS4PjpyYb51Io6 4NZ1/8uYSxcWwH11UvqdgKRFfz9BnpVSA6TMkG+7aUxDVgx+Rt3BpVd2LjYQulC1zNs3 3qeIPBqlCIUzBXHb9sOIN9dzi+7Zl1TiBFqbAYUEIu3rgJOKYnxCmQ/Nj8wVseg1FVJ5 FfYHVJRR6HOvlS3LY+TBzdBFNKTLYL8KBLezNCSx4Qa+otNGFHx8UtYnf/ou3Nug0xPF +jzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=tnZwtrfeIUnwSLpePAskWrTsX9/DkfDA/SpLBYEMRCI=; b=qBWhgWp87uDsf0TFLkuiuq7YZlxxgDGFd4f2cgAx7e/aTWRyYEvuzylWsLd0dtZRdT LSonw0hpZ/7vlxuhmaz3KhVf6p6NB2UmlDBy+nFrpvEnfv3GN8Sn+D733TQJAJDb696J 5/3TbMNRRB/vo4gMfrDKR7Yk37gsgMAeyIztzWBLcP1mJf8ppJQ2OLT37EWvT/ND1rYl pHvQvf3I+7U8w2dmwEnCfm1TajwNsLb5Xdg7sZwL9oh2N9DDu0J0bEihZ4DoN4See8yi k6qj3VT/TotjuABTn4nnc0goS4yaXOff+r4o3TbIzkUQ5FjK+0uiPfRr3xAFbkKGARmC z7gA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Etkmskss; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14-v6si14251570plr.93.2018.11.14.09.56.01; Wed, 14 Nov 2018 09:56:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Etkmskss; spf=pass (google.com: best guess record for domain of linux-efi-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-efi-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727576AbeKOEAJ (ORCPT + 3 others); Wed, 14 Nov 2018 23:00:09 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:39651 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731710AbeKOEAJ (ORCPT ); Wed, 14 Nov 2018 23:00:09 -0500 Received: by mail-pf1-f194.google.com with SMTP id c72so3599013pfc.6 for ; Wed, 14 Nov 2018 09:55:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=tnZwtrfeIUnwSLpePAskWrTsX9/DkfDA/SpLBYEMRCI=; b=EtkmskssHmg/ybwGqTO6Q8uNrMj7Ek+1vALJlR+v9S1NCcWRFFg9ZhTfmcRwOG7Rom T/YRErv3HhlCx8wb4dwXsXjzt/dfUlYPDLDpn0Pwk0qrwmgs4nsAO8D6u4v3Ls27DP3Y B+GSAs+M0qoMAyB8PTZoRK7rqPK7sPOY7ZPUY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=tnZwtrfeIUnwSLpePAskWrTsX9/DkfDA/SpLBYEMRCI=; b=SCp1u23YZwZzlVp/kEJmbH6OQ2qkWi0C7blR+mVDtZhjtIrXnlqj373YoWILtgXBS/ sYqWFseQLMZRZ2Gm3mU/8aOoW9a1BWGpOhdtgVupd27/cRlFIW5q+8x8v420GO3Z2w+Y vU7537jUS/yAmsrfoEJk8oKyQKQ2sOQXCCOcnLOyH88r/jNT5l+o4x+5OJgkKprSuQOj LqXqGxELe7C3Ba/vQuyPG6oIYierLiozHdm7l9rVN3Xo6fDJXZfZdO7f2x6TQ/h2K7w1 yQ6fGU7SHjIQdDtC1EdhututUanvGNEiXiHCZ3vK+Kvk+Dirjg4tL8UCPx19R91cLQOY 9W8g== X-Gm-Message-State: AGRZ1gJKx3QjQL2IIx/YXb+wPwMX8CvbK8lm9s68je9cNAYde7Y4ghlk D0eV6ifUiopkYlbzz74lk64YDQ7CUJvZIg== X-Received: by 2002:a63:2a4a:: with SMTP id q71mr2649533pgq.374.1542218157974; Wed, 14 Nov 2018 09:55:57 -0800 (PST) Received: from mba13.psav.com ([64.114.255.97]) by smtp.gmail.com with ESMTPSA id i2-v6sm21301738pgq.35.2018.11.14.09.55.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 14 Nov 2018 09:55:57 -0800 (PST) From: Ard Biesheuvel To: linux-efi@vger.kernel.org, Ingo Molnar , Thomas Gleixner Cc: Waiman Long , Ard Biesheuvel , linux-kernel@vger.kernel.org Subject: [PATCH 1/5] efi: Fix debugobjects warning on efi_rts_work Date: Wed, 14 Nov 2018 09:55:40 -0800 Message-Id: <20181114175544.12860-2-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20181114175544.12860-1-ard.biesheuvel@linaro.org> References: <20181114175544.12860-1-ard.biesheuvel@linaro.org> Sender: linux-efi-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org From: Waiman Long The commit 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") converted efi_rts_work from an auto variable to a global variable. However, when submitting the work, INIT_WORK_ONSTACK() was still used causing the following complaint from debugobjects: ODEBUG: object 00000000ed27b500 is NOT on stack 00000000c7d38760, but annotated. Change the macro to just INIT_WORK() to eliminate the warning. Fixes: 9dbbedaa6171 ("efi: Make efi_rts_work accessible to efi page fault handler") Signed-off-by: Waiman Long Acked-by: Sai Praneeth Prakhya Signed-off-by: Ard Biesheuvel --- drivers/firmware/efi/runtime-wrappers.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/firmware/efi/runtime-wrappers.c b/drivers/firmware/efi/runtime-wrappers.c index a19d845bdb06..8903b9ccfc2b 100644 --- a/drivers/firmware/efi/runtime-wrappers.c +++ b/drivers/firmware/efi/runtime-wrappers.c @@ -67,7 +67,7 @@ struct efi_runtime_work efi_rts_work; } \ \ init_completion(&efi_rts_work.efi_rts_comp); \ - INIT_WORK_ONSTACK(&efi_rts_work.work, efi_call_rts); \ + INIT_WORK(&efi_rts_work.work, efi_call_rts); \ efi_rts_work.arg1 = _arg1; \ efi_rts_work.arg2 = _arg2; \ efi_rts_work.arg3 = _arg3; \