From patchwork Mon Sep 5 15:24:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jia He X-Patchwork-Id: 602871 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50C6ECAAD5 for ; Mon, 5 Sep 2022 15:25:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238761AbiIEPZb (ORCPT ); Mon, 5 Sep 2022 11:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59710 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238879AbiIEPZS (ORCPT ); Mon, 5 Sep 2022 11:25:18 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B9D2F13FA8; Mon, 5 Sep 2022 08:25:04 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E1CF1ED1; Mon, 5 Sep 2022 08:25:09 -0700 (PDT) Received: from entos-ampere-02.shanghai.arm.com (unknown [10.169.212.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 324A43F534; Mon, 5 Sep 2022 08:24:56 -0700 (PDT) From: Jia He To: Len Brown , James Morse , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , Robert Richter , Robert Moore , Qiuxu Zhuo , Yazen Ghannam , Jan Luebbe , Khuong Dinh , Kani Toshi Cc: Ard Biesheuvel , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org, "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , linux-efi@vger.kernel.org, nd@arm.com, Jia He Subject: [PATCH v5 0/8] Make ghes_edac a proper module Date: Mon, 5 Sep 2022 15:24:31 +0000 Message-Id: <20220905152439.77770-1-justin.he@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org Commit dc4e8c07e9e2 ("ACPI: APEI: explicit init of HEST and GHES in apci_init()") introduced a bug that ghes_edac_register() would be invoked before edac_init(). Because at that time, the bus "edac" hasn't been even registered, this created sysfs /devices/mc0 instead of /sys/devices/system/edac/mc/mc0 on an Ampere eMag server. The proper solution is to make ghes_edac a proper module. Changelog: v5: - add the review-by from Toshi for patch 04 and 06 - refine the commit msg - remove the unconditional set of ghes_edac_force_enable on Arm v4: https://lore.kernel.org/lkml/20220831074027.13849-6-justin.he@arm.com/ - move the kernel boot option to ghes module parameter - collapse th ghes_present and ghes_edac_preferred into one patch v3: https://lore.kernel.org/lkml/20220822154048.188253-1-justin.he@arm.com/ - refine the commit logs - introduce ghes preferred and present flag (by Toshi) - move force_load to setup parameter - add the ghes_edac_preferred() check for x86/Arm edac drivers v2: https://lore.kernel.org/lkml/20220817143458.335938-1-justin.he@arm.com/ - add acked-by tag of Patch 1 from Ard - split the notifier patch - add 2 patch to get regular drivers selected when ghes edac is not loaded - fix an errno in igen6 driver - add a patch to fix the sparse warning of ghes - refine the commit logs v1: https://lore.kernel.org/lkml/20220811091713.10427-1-justin.he@arm.com/ Jia He (8): efi/cper: export several helpers for ghes_edac to use EDAC/ghes: Add a notifier for reporting memory errors EDAC:ghes: Move ghes_edac.force_load to ghes module parameter ghes: Introduce a helper ghes_edac_preferred() EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes EDAC: Add the ghes_edac_preferred check for chipset-specific edac drivers apei/ghes: Use unrcu_pointer for cmpxchg EDAC/igen6: Return consistent errno when another edac driver is enabled drivers/acpi/apei/ghes.c | 82 +++++++++++++++++++++++++++++++--- drivers/edac/Kconfig | 4 +- drivers/edac/amd64_edac.c | 3 ++ drivers/edac/armada_xp_edac.c | 3 ++ drivers/edac/edac_module.h | 1 + drivers/edac/ghes_edac.c | 78 ++++++++++++++++++++------------ drivers/edac/i10nm_base.c | 3 ++ drivers/edac/igen6_edac.c | 5 ++- drivers/edac/layerscape_edac.c | 3 ++ drivers/edac/pnd2_edac.c | 3 ++ drivers/edac/sb_edac.c | 3 ++ drivers/edac/skx_base.c | 3 ++ drivers/edac/thunderx_edac.c | 3 ++ drivers/edac/xgene_edac.c | 3 ++ drivers/firmware/efi/cper.c | 3 ++ include/acpi/apei.h | 2 + include/acpi/ghes.h | 36 +++++---------- 17 files changed, 175 insertions(+), 63 deletions(-) Reviewed-by: Toshi Kani