mbox series

[RFC,0/2] Quirk to handle Dell BIOS

Message ID 20200912175105.2085299-1-nivedita@alum.mit.edu
Headers show
Series Quirk to handle Dell BIOS | expand

Message

Arvind Sankar Sept. 12, 2020, 5:51 p.m. UTC
I coded up the quirk to see what it looks like.

First patch is the quirk itself, and the second one is a slightly
rejiggered version of the dumping code for testing.

Jacobo, can you check if this fixes the efi stub boot?

Thanks.

Arvind Sankar (2):
  efi/x86: Add a quirk to support command line arguments on Dell EFI firmware
  efi/libstub: Dump command line before/after conversion

 .../firmware/efi/libstub/efi-stub-helper.c    | 139 +++++++++++++++++-
 drivers/firmware/efi/libstub/efistub.h        |  31 ++++
 drivers/firmware/efi/libstub/file.c           |   5 +-
 3 files changed, 173 insertions(+), 2 deletions(-)

Comments

Jacobo Pantoja Sept. 14, 2020, 3:59 p.m. UTC | #1
On Sat, 12 Sep 2020 at 19:51, Arvind Sankar <nivedita@alum.mit.edu> wrote:
>

> I coded up the quirk to see what it looks like.

>

> First patch is the quirk itself, and the second one is a slightly

> rejiggered version of the dumping code for testing.

>

> Jacobo, can you check if this fixes the efi stub boot?


I tested the patch and works perfectly. I also tested in a non-Dell
machine, and it
also works properly.

I simplified a bit the cmdline so that it fits on the screen during testing.

This is the output of the Dell machine with the helper patch also applied:
https://ibb.co/HdDh6HK

And this is the output of the non-Dell machine:
https://ibb.co/whh1g9D

It seems that both are properly parsed.

I've also tested (just in case) the patch alone, without the helper
debug text, and it
works properly in both machines as well, as expected.

>

> Thanks.

>

> Arvind Sankar (2):

>   efi/x86: Add a quirk to support command line arguments on Dell EFI firmware

>   efi/libstub: Dump command line before/after conversion

>

>  .../firmware/efi/libstub/efi-stub-helper.c    | 139 +++++++++++++++++-

>  drivers/firmware/efi/libstub/efistub.h        |  31 ++++

>  drivers/firmware/efi/libstub/file.c           |   5 +-

>  3 files changed, 173 insertions(+), 2 deletions(-)

>

> --

> 2.26.2

>