diff mbox series

[v2,5/5] arm64: dts: meson: g12b: w400: fix PHY deassert timing requirements

Message ID a899168379ce425b35eea4a369504fd75977bd71.1606828668.git.stefan@agner.ch
State Superseded
Headers show
Series [v2,1/5] arm64: dts: meson: g12b: odroid-n2: fix PHY deassert timing requirements | expand

Commit Message

Stefan Agner Dec. 1, 2020, 1:21 p.m. UTC
According to the datasheet (Rev. 1.9) the RTL8211F requires at least
72ms "for internal circuits settling time" before accessing the PHY
egisters. On similar boards with the same PHY this fixes an issue where
Ethernet link would not come up when using ip link set down/up.

Fixes: 2cd2310fca4c ("arm64: dts: meson-g12b-ugoos-am6: add initial device-tree")
Signed-off-by: Stefan Agner <stefan@agner.ch>
---
 arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Martin Blumenstingl Dec. 5, 2020, 1:14 p.m. UTC | #1
On Tue, Dec 1, 2020 at 2:21 PM Stefan Agner <stefan@agner.ch> wrote:
>

> According to the datasheet (Rev. 1.9) the RTL8211F requires at least

> 72ms "for internal circuits settling time" before accessing the PHY

> egisters. On similar boards with the same PHY this fixes an issue where

> Ethernet link would not come up when using ip link set down/up.

>

> Fixes: 2cd2310fca4c ("arm64: dts: meson-g12b-ugoos-am6: add initial device-tree")

> Signed-off-by: Stefan Agner <stefan@agner.ch>

with the "registers" typo above fixed:
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
index 2802ddbb83ac..feb088504740 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12b-w400.dtsi
@@ -264,7 +264,7 @@  external_phy: ethernet-phy@0 {
 		max-speed = <1000>;
 
 		reset-assert-us = <10000>;
-		reset-deassert-us = <30000>;
+		reset-deassert-us = <80000>;
 		reset-gpios = <&gpio GPIOZ_15 (GPIO_ACTIVE_LOW | GPIO_OPEN_DRAIN)>;
 
 		interrupt-parent = <&gpio_intc>;