From patchwork Wed Oct 1 12:53:18 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Likely X-Patchwork-Id: 38233 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f197.google.com (mail-lb0-f197.google.com [209.85.217.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5FBF320549 for ; Wed, 1 Oct 2014 12:53:45 +0000 (UTC) Received: by mail-lb0-f197.google.com with SMTP id p9sf551203lbv.4 for ; Wed, 01 Oct 2014 05:53:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:mime-version:from:date:message-id :subject:to:sender:precedence:list-id:x-original-sender :x-original-authentication-results:mailing-list:list-post:list-help :list-archive:list-unsubscribe:content-type; bh=gsAqEgBds47R2cvPd70SM/NqWve5ACpginRedwzKtOM=; b=dCZSeDpmC0yfRt0mQoUiEFGcugb3MgixFTlSjLsN1jiwk5pJQuM89yLBji/E4qhx+a +Ad3iBjOppwRPyCZn69qNFFNOziq/1tI4jzF4jVo2EhHAe7M/d7QAjSiiSzJLBCVMJ79 olgB5H1DcVhHY8vnP5zk6IeDXLyj6FS6p64l6xhUs2f0dm4o3R3zEIcaNPhBJysEweK/ kMlzpSU2/X2R4pO0jgaRCfulSsvM9ugAlrSqyx3M/J5XzznZKLgZJCnqNxF1VmwV8VhP uAlhoMgT5FPgRP3tCy+F+hyeF8Eu2iN9pdsBdnXXA00nr9YsyzeB49tTwJMskUiiqUpj E3Lw== X-Gm-Message-State: ALoCoQltv8zfFY6WjhogeQmLBrFWOpSCSlBZRil8kKXCNwdmkxS3fTgdngYY7V2q71erl25y4JBS X-Received: by 10.112.225.41 with SMTP id rh9mr4900179lbc.5.1412168023924; Wed, 01 Oct 2014 05:53:43 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.207.107 with SMTP id lv11ls154376lac.14.gmail; Wed, 01 Oct 2014 05:53:43 -0700 (PDT) X-Received: by 10.152.23.199 with SMTP id o7mr55453892laf.26.1412168023778; Wed, 01 Oct 2014 05:53:43 -0700 (PDT) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com [209.85.215.54]) by mx.google.com with ESMTPS id dy7si1581924lac.28.2014.10.01.05.53.43 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 01 Oct 2014 05:53:43 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) client-ip=209.85.215.54; Received: by mail-la0-f54.google.com with SMTP id gm9so239689lab.41 for ; Wed, 01 Oct 2014 05:53:43 -0700 (PDT) X-Received: by 10.112.163.103 with SMTP id yh7mr51984244lbb.73.1412168023610; Wed, 01 Oct 2014 05:53:43 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.130.169 with SMTP id of9csp522986lbb; Wed, 1 Oct 2014 05:53:42 -0700 (PDT) X-Received: by 10.68.247.137 with SMTP id ye9mr78549048pbc.69.1412168022136; Wed, 01 Oct 2014 05:53:42 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si798206pdj.106.2014.10.01.05.53.41 for ; Wed, 01 Oct 2014 05:53:42 -0700 (PDT) Received-SPF: none (google.com: devicetree-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208AbaJAMxk (ORCPT + 5 others); Wed, 1 Oct 2014 08:53:40 -0400 Received: from mail-ig0-f169.google.com ([209.85.213.169]:44873 "EHLO mail-ig0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750768AbaJAMxj (ORCPT ); Wed, 1 Oct 2014 08:53:39 -0400 Received: by mail-ig0-f169.google.com with SMTP id uq10so186120igb.0 for ; Wed, 01 Oct 2014 05:53:39 -0700 (PDT) X-Received: by 10.50.73.67 with SMTP id j3mr19623807igv.22.1412168019041; Wed, 01 Oct 2014 05:53:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.64.58.42 with HTTP; Wed, 1 Oct 2014 05:53:18 -0700 (PDT) From: Grant Likely Date: Wed, 1 Oct 2014 13:53:18 +0100 Message-ID: Subject: Bug in selftest code To: Gaurav Minocha , "devicetree@vger.kernel.org" Sender: devicetree-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: devicetree@vger.kernel.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: grant.likely@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , Hi Gaurav, I found a bug in the selftest code today. If you apply this patch: The I get the following oops on boot. The code doesn't properly handle more than one root node to be added. I've not tried to debug it yet. ### dt-test ### end of selftest - 91 passed, 0 failed Unable to handle kernel NULL pointer dereference at virtual address 0000001c pgd = c0004000 [0000001c] *pgd=00000000 Internal error: Oops: 17 [#1] ARM Modules linked in: CPU: 0 PID: 1 Comm: swapper Not tainted 3.17.0-rc7+ #40 task: c782bb20 ti: c782c000 task.ti: c782c000 PC is at detach_node_and_children+0x8/0x4c LR is at of_selftest+0x15e8/0x1644 pc : [] lr : [] psr: 20000013 sp : c782de78 ip : 00000065 fp : 00000000 r10: c03a1b90 r9 : c03a1b90 r8 : c032e19c r7 : c0471a54 r6 : 00000000 r5 : c714afdc r4 : 00000000 r3 : 0000006e r2 : 0000006c r1 : c03bdbaf r0 : 00000000 Flags: nzCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment kernel Control: 00093177 Table: 07114000 DAC: 00000017 Process swapper (pid: 1, stack limit = 0xc782c1c0) Stack: (0xc782de78 to 0xc782e000) de60: 00000000 c042208c de80: c782de90 c039961e 0000000c c7148000 c7148d80 00000001 0000000f 00000002 dea0: 0000000c 0000000c c7138c00 c0420aa4 00000000 c782c000 00000000 c01ade54 dec0: c0471678 c782def0 c0458ce0 c042f4b0 00000007 c04278f0 c0439b38 c0439b38 dee0: c7138c00 c0458ce0 c0420aa4 00000000 c782c000 c0008aa0 c0448ce0 c039b300 df00: c045e76c c784e100 c0314000 00000032 00000000 00000000 00000000 c00dc5a8 df20: 00000000 c784e160 c7ffc9ec c03223c0 0000005e c0034b90 c03ea090 00000007 df40: c7ffc9fc 00000007 00000000 c042f4b0 00000007 c04278f0 c0458ce0 c0409514 df60: 0000005e c04278f8 00000000 c0409c90 00000007 00000007 c0409514 00000000 df80: 00000000 00000000 00000000 c030adbc 00000000 00000000 00000000 00000000 dfa0: 00000000 c030adc4 00000000 c0013fd0 00000000 00000000 00000000 00000000 dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [] (detach_node_and_children) from [] (of_selftest+0x15e8/0x1644) [] (of_selftest) from [] (do_one_initcall+0x80/0x1c8) [] (do_one_initcall) from [] (kernel_init_freeable+0xec/0x1b4) [] (kernel_init_freeable) from [] (kernel_init+0x8/0xec) [] (kernel_init) from [] (ret_from_fork+0x14/0x24) Code: c032dfac c03be438 e92d4010 e1a04000 (e590001c) ---[ end trace a8fecae0e53fc1be ]--- Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b --- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/of/testcase-data/testcases.dts b/drivers/of/testcase-data/testcases.dts index 219ef9324e9c..9dd482c02357 100644 --- a/drivers/of/testcase-data/testcases.dts +++ b/drivers/of/testcase-data/testcases.dts @@ -8,6 +8,8 @@ }; }; }; + another-node{ + }; }; #include "tests-phandle.dtsi" #include "tests-interrupts.dtsi"