From patchwork Sun Dec 26 19:59:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sander Vanheule X-Patchwork-Id: 528196 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D851C433EF for ; Sun, 26 Dec 2021 20:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229461AbhLZUCi (ORCPT ); Sun, 26 Dec 2021 15:02:38 -0500 Received: from polaris.svanheule.net ([84.16.241.116]:57508 "EHLO polaris.svanheule.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232494AbhLZT7f (ORCPT ); Sun, 26 Dec 2021 14:59:35 -0500 Received: from terra.local.svanheule.net (unknown [IPv6:2a02:a03f:eafe:c901:201f:9f28:b747:b33a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sander@svanheule.net) by polaris.svanheule.net (Postfix) with ESMTPSA id 5E791288173; Sun, 26 Dec 2021 20:59:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=svanheule.net; s=mail1707; t=1640548773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TpkkGK1HUml0mP08FJk1cHUKfwB7mgaDR1xVUUyYboc=; b=oFY52azimID0jDwssKlYBy6MiKluyiVyekTFxgy0s2+e/jPE2wT/JGogsiTXkimdkCxJ73 xdLLtcPD2SEmIGI4ej/Lh8QaskHjDroZn5PrboUt6GfaL2GEhnwjRRhQRRL7oBVpr7fevg MdKd6eNXk3qjlESiLFnznG10dH+UFtjBS/wZPNYA/7lyN2dpVYu3KL4IO5O2GNC0yrpcu4 zP6cCZApCUwWsoLngT9Xd3K0p8O5Oz3zpjx70NhxDE7Np3rm6bF+r397WYxKh1J4zDRsgD 0fYZlpQoL6ZiEHjEku2AQgEO7iqPuD06h/yfBJYfOPNT3N1i79EfONe4FPXtAA== From: Sander Vanheule To: Thomas Gleixner , Marc Zyngier , Rob Herring , devicetree@vger.kernel.org Cc: Birger Koblitz , Bert Vermeulen , John Crispin , linux-kernel@vger.kernel.org, Sander Vanheule Subject: [RFC PATCH v2 1/5] irqchip/realtek-rtl: map control data to virq Date: Sun, 26 Dec 2021 20:59:24 +0100 Message-Id: <6a853e21eb3edee268c8f99429673b89dd1517c5.1640548009.git.sander@svanheule.net> X-Mailer: git-send-email 2.33.1 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org The driver assigned the irqchip and irq handler to the hardware irq, instead of the virq. This is incorrect, and only worked because these irq numbers happened to be the same on the devices used for testing the original driver. Fixes: 9f3a0f34b84a ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller") Signed-off-by: Sander Vanheule --- drivers/irqchip/irq-realtek-rtl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c index fd9f275592d2..d6788dd93c7b 100644 --- a/drivers/irqchip/irq-realtek-rtl.c +++ b/drivers/irqchip/irq-realtek-rtl.c @@ -62,7 +62,7 @@ static struct irq_chip realtek_ictl_irq = { static int intc_map(struct irq_domain *d, unsigned int irq, irq_hw_number_t hw) { - irq_set_chip_and_handler(hw, &realtek_ictl_irq, handle_level_irq); + irq_set_chip_and_handler(irq, &realtek_ictl_irq, handle_level_irq); return 0; }