From patchwork Fri Jul 3 14:33:51 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "kernelci.org bot" X-Patchwork-Id: 230289 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2449453ilg; Fri, 3 Jul 2020 07:33:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwnggcxhZYRP/Y0zG3ZEEUD0QidfaiWjVf4m+oQBJ6SkLabgCaQssf3j0CFuSXmaQJk7mZ+ X-Received: by 2002:aa7:d58c:: with SMTP id r12mr43073576edq.160.1593786835388; Fri, 03 Jul 2020 07:33:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593786835; cv=none; d=google.com; s=arc-20160816; b=HsfaVe42H7KMlHVaxq8U7i21w3TtSnzQUQOjNBI88IoylftRqmphBProJOrKU+7HKd UkywRqM8LgqkfnnVx9t4Jj2YOPKKFCvq23nj4h0wzKYqRXdOzrjOybOhf7Ue7o5lxhmC L0U6zBlam7o11KEJcXE62AbFAeFrWIZfsHG7cv3nvLMo/AoRGuAtX/wxxhzDSrtM9P8V BFX6djMGcoDV4voGOuDEhq6ClFUWigVilW2XVlqTtOsV9t0LKLP46yo8SQM3W9LxnYS/ k2IE2StVbTkyUD2dA+GXBW8dA1vQnv/bWSX7v6tbLX+gXIIORlWARauw+EzcBx7D7iCG zLtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:from:to:subject :content-transfer-encoding:mime-version:date:message-id :dkim-signature; bh=7WvGi3ZWzZ6amDsfHb5k51P9HzBmGi89bs5PYzy6Mxs=; b=jDK1juud1h2H3QWa/KZwHQnGSrsn7sOqveeJV/27Ps9iwqLXLUGjgyCjjNtDYazMOe OqFWgOO1aevvS1YfemGkY31GNJaHQvA1wjim5QVJenGjUY88AHd/JlNywJtNVMyxv0+0 LEEyhvfkD/9qs2fgS3IjWckdQxiSMu2EqCD8D+5DrSawfmsQO3re29ISlV7B1s7utzQX g3PXb9hPoVpJfdFfAvQv76lQZAZkJ2jjoqt5uarSXfFP3DgfiWrTaSfEoSqDELUT3cH9 GyofWRaEkHtb6ObSa68vtlTpXfh2jK2bgfwk4f7O4/+wOGuINZWTpbZYYWAdj1/cm2Gt GttQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=GgtgWYLM; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id d16si7573747ejp.131.2020.07.03.07.33.55; Fri, 03 Jul 2020 07:33:55 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernelci-org.20150623.gappssmtp.com header.s=20150623 header.b=GgtgWYLM; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbgGCOdy (ORCPT + 6 others); Fri, 3 Jul 2020 10:33:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43748 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726534AbgGCOdx (ORCPT ); Fri, 3 Jul 2020 10:33:53 -0400 Received: from mail-pg1-x541.google.com (mail-pg1-x541.google.com [IPv6:2607:f8b0:4864:20::541]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58DF8C08C5DD for ; Fri, 3 Jul 2020 07:33:53 -0700 (PDT) Received: by mail-pg1-x541.google.com with SMTP id j19so8319904pgm.11 for ; Fri, 03 Jul 2020 07:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernelci-org.20150623.gappssmtp.com; s=20150623; h=message-id:date:mime-version:content-transfer-encoding:subject:to :from:cc; bh=7WvGi3ZWzZ6amDsfHb5k51P9HzBmGi89bs5PYzy6Mxs=; b=GgtgWYLMzWh/a1jUS92H1aJ8rur1vg3pPP3+hotqIpRbf6wmlBBTBVNkzuhadRfrAP EIcu/7/BoazS/XZNK6VRhlctZYSCnCRJz5TlsyP0G+lHmdKhavNz6KMOdlclRsQrXvF3 mx+J6Nkeugr+wThh5bhv1nDNarfuL/22Mrwd2Y0oci3aCWDJ90wCqrPxDB7nlW462I8S oRlVeBUgwZiEWijL3iQtpLCyEIuugAv/0ZoHqhbeLhRjM+mTLGBRrEQ7M/FZg6fECxLz vhHSjkAJJ+Fyu8gn3+CfdA8ed5QeSwQBPWAeyJeKuavWY7TO/MzqRdMdevuWpAezNYH7 1ybA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:date:mime-version :content-transfer-encoding:subject:to:from:cc; bh=7WvGi3ZWzZ6amDsfHb5k51P9HzBmGi89bs5PYzy6Mxs=; b=jAdvs12YyCZFjoMEwH7yV+GjVaVNg0cDE6kBuuUyiyckamncHcPqsB13V2rjhobKXQ /o5rFxx6OJnd2mGgZmzhkJEKnUi8lSn67VJR7C+OU9c5MWACxZxNJGTVyhAelPkN0yQW 4bxsSCUwa8tKBZbe465TeLw/vckm8hl0weHGZfjd/TocQJh69ZF9MOIOFE3TfdukildU 5j+W61nq1T144r+HCy1KJDAVQCzZGCu3CS5rsmKS+FY52zaYs2C9TYyvsQV1zqkLbQtG 7FFBVMFaEMyxvkHAmORgrARRZ6W78hzXLj/eXHjZQCP7nVsf6BaCe59SDrKQ+MW4f8Lg 94kQ== X-Gm-Message-State: AOAM532ekuaxI4ZmoCXef3Vm86qvHaP0VN2pMvruGpTWwtoGUwSjHhFp onED79bIyGOgiP/qkB2ZlSrRUA== X-Received: by 2002:a63:564e:: with SMTP id g14mr28984034pgm.326.1593786832715; Fri, 03 Jul 2020 07:33:52 -0700 (PDT) Received: from kernelci-production.internal.cloudapp.net ([52.250.1.28]) by smtp.gmail.com with ESMTPSA id r16sm11607347pfh.64.2020.07.03.07.33.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 07:33:51 -0700 (PDT) Message-ID: <5eff41cf.1c69fb81.f3c05.e990@mx.google.com> Date: Fri, 03 Jul 2020 07:33:51 -0700 (PDT) MIME-Version: 1.0 X-Kernelci-Kernel: v5.8-rc3-82-gcdd3bb54332f X-Kernelci-Report-Type: bisect X-Kernelci-Tree: mainline X-Kernelci-Branch: master X-Kernelci-Lab-Name: lab-cip Subject: mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 To: kernelci-results@groups.io, gtucker@collabora.com, Andre Przywara , Sudeep Holla From: "kernelci.org bot" Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Rob Herring , Liviu Dudau , linux-arm-kernel@lists.infradead.org, Lorenzo Pieralisi Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the problem may be somewhere else. * * * * If you do send a fix, please include this trailer: * * Reported-by: "kernelci.org bot" * * * * Hope this helps! * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15 Summary: Start: cdd3bb54332f Merge tag 'm68knommu-for-v5.8-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu Plain log: https://storage.kernelci.org/mainline/master/v5.8-rc3-82-gcdd3bb54332f/arm/vexpress_defconfig/gcc-8/lab-cip/baseline-vexpress-v2p-ca15-tc1.txt HTML log: https://storage.kernelci.org/mainline/master/v5.8-rc3-82-gcdd3bb54332f/arm/vexpress_defconfig/gcc-8/lab-cip/baseline-vexpress-v2p-ca15-tc1.html Result: 38ac46002d1d arm: dts: vexpress: Move mcc node back into motherboard node Checks: revert: PASS verify: PASS Parameters: Tree: mainline URL: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git Branch: master Target: qemu_arm-vexpress-a15 CPU arch: arm Lab: lab-cip Compiler: gcc-8 Config: vexpress_defconfig Test case: baseline.dmesg.crit Breaking commit found: ------------------------------------------------------------------------------- commit 38ac46002d1df5707566a73486452851341028d2 Author: Andre Przywara Date: Wed Jun 3 17:22:37 2020 +0100 arm: dts: vexpress: Move mcc node back into motherboard node Commit d9258898ad49 ("arm64: dts: arm: vexpress: Move fixed devices out of bus node") moved the "mcc" DT node into the root node, because it does not have any children using "reg" properties, so does violate some dtc checks about "simple-bus" nodes. However this broke the vexpress config-bus code, which walks up the device tree to find the first node with an "arm,vexpress,site" property. This gave the wrong result (matching the root node instead of the motherboard node), so broke the clocks and some other devices for VExpress boards. Move the whole node back into its original position. This re-introduces the dtc warning, but is conceptually the right thing to do. The dtc warning seems to be overzealous here, there are discussions on fixing or relaxing this check instead. Link: https://lore.kernel.org/r/20200603162237.16319-1-andre.przywara@arm.com Fixes: d9258898ad49 ("arm64: dts: vexpress: Move fixed devices out of bus node") Reported-and-tested-by: Guenter Roeck Signed-off-by: Andre Przywara Signed-off-by: Sudeep Holla ------------------------------------------------------------------------------- Git bisection log: ------------------------------------------------------------------------------- git bisect start # good: [719fdd32921fb7e3208db8832d32ae1c2d68900f] afs: Fix storage of cell names git bisect good 719fdd32921fb7e3208db8832d32ae1c2d68900f # bad: [cdd3bb54332f82295ed90cd0c09c78cd0c0ee822] Merge tag 'm68knommu-for-v5.8-rc4' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu git bisect bad cdd3bb54332f82295ed90cd0c09c78cd0c0ee822 # bad: [f7db192b2d71ea42627a32349d59a5f99f2aafcc] Merge tag 'arm-omap-fixes-5.8-1' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc git bisect bad f7db192b2d71ea42627a32349d59a5f99f2aafcc # good: [ae71d4bf0074a81cc04255c96e3de0a49b1d95fa] Merge tag 'perf-urgent-2020-06-28' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip git bisect good ae71d4bf0074a81cc04255c96e3de0a49b1d95fa # good: [d528945d7762be94beca4c111bb95dcc9a9f39c0] Merge tag 'omap-for-v5.8/fixes-rc1-signed' of git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap into arm/omap-fixes git bisect good d528945d7762be94beca4c111bb95dcc9a9f39c0 # bad: [2596ce4b4ded685b67fed407aed2bfe6ebcc39cb] Merge tag 'arm-soc/for-5.8/drivers-fixes' of https://github.com/Broadcom/stblinux into arm/fixes git bisect bad 2596ce4b4ded685b67fed407aed2bfe6ebcc39cb # bad: [0f77ce26ebcf6ea384421d2dd47b924b83649692] Revert "ARM: sti: Implement dummy L2 cache's write_sec" git bisect bad 0f77ce26ebcf6ea384421d2dd47b924b83649692 # bad: [d68ec1644dd546851d651787a638aead32a60a6f] Merge tag 'juno-fix-5.8' of git://git.kernel.org/pub/scm/linux/kernel/git/sudeep.holla/linux into arm/fixes git bisect bad d68ec1644dd546851d651787a638aead32a60a6f # bad: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node git bisect bad 38ac46002d1df5707566a73486452851341028d2 # first bad commit: [38ac46002d1df5707566a73486452851341028d2] arm: dts: vexpress: Move mcc node back into motherboard node ------------------------------------------------------------------------------- diff --git a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi index e6308fb76183..a88ee5294d35 100644 --- a/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi +++ b/arch/arm/boot/dts/vexpress-v2m-rs1.dtsi @@ -100,79 +100,6 @@ }; }; - mcc { - compatible = "arm,vexpress,config-bus"; - arm,vexpress,config-bridge = <&v2m_sysreg>; - - oscclk0 { - /* MCC static memory clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 0>; - freq-range = <25000000 60000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk0"; - }; - - v2m_oscclk1: oscclk1 { - /* CLCD clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 1>; - freq-range = <23750000 65000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk1"; - }; - - v2m_oscclk2: oscclk2 { - /* IO FPGA peripheral clock */ - compatible = "arm,vexpress-osc"; - arm,vexpress-sysreg,func = <1 2>; - freq-range = <24000000 24000000>; - #clock-cells = <0>; - clock-output-names = "v2m:oscclk2"; - }; - - volt-vio { - /* Logic level voltage */ - compatible = "arm,vexpress-volt"; - arm,vexpress-sysreg,func = <2 0>; - regulator-name = "VIO"; - regulator-always-on; - label = "VIO"; - }; - - temp-mcc { - /* MCC internal operating temperature */ - compatible = "arm,vexpress-temp"; - arm,vexpress-sysreg,func = <4 0>; - label = "MCC"; - }; - - reset { - compatible = "arm,vexpress-reset"; - arm,vexpress-sysreg,func = <5 0>; - }; - - muxfpga { - compatible = "arm,vexpress-muxfpga"; - arm,vexpress-sysreg,func = <7 0>; - }; - - shutdown { - compatible = "arm,vexpress-shutdown"; - arm,vexpress-sysreg,func = <8 0>; - }; - - reboot { - compatible = "arm,vexpress-reboot"; - arm,vexpress-sysreg,func = <9 0>; - }; - - dvimode { - compatible = "arm,vexpress-dvimode"; - arm,vexpress-sysreg,func = <11 0>; - }; - }; - bus@8000000 { motherboard-bus { model = "V2M-P1"; @@ -435,6 +362,79 @@ }; }; }; + + mcc { + compatible = "arm,vexpress,config-bus"; + arm,vexpress,config-bridge = <&v2m_sysreg>; + + oscclk0 { + /* MCC static memory clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 0>; + freq-range = <25000000 60000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk0"; + }; + + v2m_oscclk1: oscclk1 { + /* CLCD clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 1>; + freq-range = <23750000 65000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk1"; + }; + + v2m_oscclk2: oscclk2 { + /* IO FPGA peripheral clock */ + compatible = "arm,vexpress-osc"; + arm,vexpress-sysreg,func = <1 2>; + freq-range = <24000000 24000000>; + #clock-cells = <0>; + clock-output-names = "v2m:oscclk2"; + }; + + volt-vio { + /* Logic level voltage */ + compatible = "arm,vexpress-volt"; + arm,vexpress-sysreg,func = <2 0>; + regulator-name = "VIO"; + regulator-always-on; + label = "VIO"; + }; + + temp-mcc { + /* MCC internal operating temperature */ + compatible = "arm,vexpress-temp"; + arm,vexpress-sysreg,func = <4 0>; + label = "MCC"; + }; + + reset { + compatible = "arm,vexpress-reset"; + arm,vexpress-sysreg,func = <5 0>; + }; + + muxfpga { + compatible = "arm,vexpress-muxfpga"; + arm,vexpress-sysreg,func = <7 0>; + }; + + shutdown { + compatible = "arm,vexpress-shutdown"; + arm,vexpress-sysreg,func = <8 0>; + }; + + reboot { + compatible = "arm,vexpress-reboot"; + arm,vexpress-sysreg,func = <9 0>; + }; + + dvimode { + compatible = "arm,vexpress-dvimode"; + arm,vexpress-sysreg,func = <11 0>; + }; + }; }; }; };