| Message ID | 20231222094548.54103-2-william.qiu@starfivetech.com |
|---|---|
| State | Accepted |
| Commit | 2529085831b01fcd02ff58ab4e2596d3b31bcf80 |
| Headers | show |
| Series | StarFive's Pulse Width Modulation driver support | expand |
Hello William, On Fri, Dec 22, 2023 at 05:45:45PM +0800, William Qiu wrote: > Add bindings for OpenCores PWM Controller. > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > Reviewed-by: Hal Feng <hal.feng@starfivetech.com> > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Looks fine to me. I'll assume you reiterate the series for patch #2 and so I will mark this patch as deferred in patchwork. Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
Hello Conor, On Thu, Jan 04, 2024 at 11:43:13PM +0100, Uwe Kleine-König wrote: > On Fri, Dec 22, 2023 at 05:45:45PM +0800, William Qiu wrote: > > Add bindings for OpenCores PWM Controller. > > > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > > Reviewed-by: Hal Feng <hal.feng@starfivetech.com> > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > Looks fine to me. I'll assume you reiterate the series for patch #2 and > so I will mark this patch as deferred in patchwork. > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> If you want, pick this patch up that it goes along with the dts changes. To make this formal: Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Best regards Uwe
On Mon, Jan 08, 2024 at 10:03:49PM +0100, Uwe Kleine-König wrote: > Hello Conor, > > On Thu, Jan 04, 2024 at 11:43:13PM +0100, Uwe Kleine-König wrote: > > On Fri, Dec 22, 2023 at 05:45:45PM +0800, William Qiu wrote: > > > Add bindings for OpenCores PWM Controller. > > > > > > Signed-off-by: William Qiu <william.qiu@starfivetech.com> > > > Reviewed-by: Hal Feng <hal.feng@starfivetech.com> > > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > > > > Looks fine to me. I'll assume you reiterate the series for patch #2 and > > so I will mark this patch as deferred in patchwork. > > > > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > > If you want, pick this patch up that it goes along with the dts changes. > > To make this formal: > > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Cool. I'll do that after the merge window closes :) Thanks!
diff --git a/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml new file mode 100644 index 000000000000..0b85dd861dfd --- /dev/null +++ b/Documentation/devicetree/bindings/pwm/opencores,pwm.yaml @@ -0,0 +1,55 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/pwm/opencores,pwm.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: OpenCores PWM controller + +maintainers: + - William Qiu <william.qiu@starfivetech.com> + +description: + The OpenCores PTC ip core contains a PWM controller. When operating in PWM + mode, the PTC core generates binary signal with user-programmable low and + high periods. All PTC counters and registers are 32-bit. + +allOf: + - $ref: pwm.yaml# + +properties: + compatible: + items: + - enum: + - starfive,jh7100-pwm + - starfive,jh7110-pwm + - const: opencores,pwm-v1 + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + resets: + maxItems: 1 + + "#pwm-cells": + const: 3 + +required: + - compatible + - reg + - clocks + +additionalProperties: false + +examples: + - | + pwm@12490000 { + compatible = "starfive,jh7110-pwm", "opencores,pwm-v1"; + reg = <0x12490000 0x10000>; + clocks = <&clkgen 181>; + resets = <&rstgen 109>; + #pwm-cells = <3>; + };