| Message ID | 20231216162639.125215-5-knaerzche@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add HDMI support for RK3128 | expand |
Hi, On Sat, Dec 16, 2023 at 05:26:15PM +0100, Alex Bee wrote: > From: Maxime Ripard <mripard@kernel.org> > > The mode_fixup implementation doesn't do anything, so we can simply > remove it. > > Signed-off-by: Maxime Ripard <mripard@kernel.org> > Tested-by: Alex Bee <knaerzche@gmail.com> Generally speaking, when you're sending patches you should always have your SoB. That is true for the commit you authored, but also for the commits you applied and are sending on the author's behalf. This applies to all the other patches Maxime
diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index 345253e033c5..0b1740b38c7b 100644 --- a/drivers/gpu/drm/rockchip/inno_hdmi.c +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c @@ -517,13 +517,6 @@ static void inno_hdmi_encoder_disable(struct drm_encoder *encoder) inno_hdmi_set_pwr_mode(hdmi, LOWER_PWR); } -static bool inno_hdmi_encoder_mode_fixup(struct drm_encoder *encoder, - const struct drm_display_mode *mode, - struct drm_display_mode *adj_mode) -{ - return true; -} - static int inno_hdmi_encoder_atomic_check(struct drm_encoder *encoder, struct drm_crtc_state *crtc_state, @@ -540,7 +533,6 @@ inno_hdmi_encoder_atomic_check(struct drm_encoder *encoder, static struct drm_encoder_helper_funcs inno_hdmi_encoder_helper_funcs = { .enable = inno_hdmi_encoder_enable, .disable = inno_hdmi_encoder_disable, - .mode_fixup = inno_hdmi_encoder_mode_fixup, .mode_set = inno_hdmi_encoder_mode_set, .atomic_check = inno_hdmi_encoder_atomic_check, };