| Message ID | 20230131140345.6193-2-quic_youghand@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/2] dt: bindings: add dt entry for XO calibration support | expand |
On Tue, Jan 31, 2023 at 07:02:16PM +0100, Krzysztof Kozlowski wrote: > On 31/01/2023 15:03, Youghandhar Chintala wrote: > > Add dt binding to get XO calibration data support for Wi-Fi RF clock. > > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). > Hint: dt-bindings: net: qcom,ath11k: > > > > > Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com> > > --- > > .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > > index f7cf135aa37f..205ee949daba 100644 > > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml > > @@ -41,6 +41,10 @@ properties: > > * reg > > * reg-names > > > > + xo-cal-data: > > + description: > > + XO cal offset to be configured in XO trim register > > Missing type. I also do not understand what's this and why some register > offset should be stored in DT. Please give us some justification why > this is suitable for DT. I think that's a voltage offset or something, but you are right, we shouldn't have to guess. It needs a vendor prefix, too. Rob
diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml index f7cf135aa37f..205ee949daba 100644 --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k.yaml @@ -41,6 +41,10 @@ properties: * reg * reg-names + xo-cal-data: + description: + XO cal offset to be configured in XO trim register + qcom,ath11k-calibration-variant: $ref: /schemas/types.yaml#/definitions/string description:
Add dt binding to get XO calibration data support for Wi-Fi RF clock. Signed-off-by: Youghandhar Chintala <quic_youghand@quicinc.com> --- .../devicetree/bindings/net/wireless/qcom,ath11k.yaml | 4 ++++ 1 file changed, 4 insertions(+)