diff mbox series

[1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema

Message ID 20221224154255.43499-1-krzysztof.kozlowski@linaro.org
State Accepted
Commit 496b308f0988f3fb610073e125da8ef8065b334f
Headers show
Series [1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema | expand

Commit Message

Krzysztof Kozlowski Dec. 24, 2022, 3:42 p.m. UTC
The node names should be generic and the bindings expect "bus" for
simple-bus nodes:

  msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Konrad Dybcio Dec. 27, 2022, 11:22 a.m. UTC | #1
On 24.12.2022 16:42, Krzysztof Kozlowski wrote:
> The node names should be generic and the bindings expect "bus" for
> simple-bus nodes:
> 
>   msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/msm8996.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> index c53018ca81d7..cf2f5b74a4c2 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
> @@ -1814,7 +1814,7 @@ spmi_bus: spmi@400f000 {
>  			#interrupt-cells = <4>;
>  		};
>  
> -		agnoc@0 {
> +		bus@0 {
>  			power-domains = <&gcc AGGRE0_NOC_GDSC>;
>  			compatible = "simple-pm-bus";
Mind sending a separate patch to move compatible up on this one?

Konrad
>  			#address-cells = <1>;
Bjorn Andersson Dec. 29, 2022, 5:23 p.m. UTC | #2
On Sat, 24 Dec 2022 16:42:51 +0100, Krzysztof Kozlowski wrote:
> The node names should be generic and the bindings expect "bus" for
> simple-bus nodes:
> 
>   msm8996-mtp.dtb: agnoc@0: $nodename:0: 'agnoc@0' does not match '^bus(@[0-9a-f]+)?$'
> 
> 

Applied, thanks!

[1/5] arm64: dts: qcom: msm8996: align bus node names with DT schema
      commit: 496b308f0988f3fb610073e125da8ef8065b334f
[3/5] arm64: dts: qcom: sm8250: drop unused clock-frequency from va-macro
      commit: 42db0f72f7a8c33501a55537ac90557a665a56f8
[4/5] arm64: dts: qcom: sm8450: re-order GCC clocks
      commit: 539a9923683c79e6925dd69a2e2534ec197361c7
[5/5] arm64: dts: qcom: use generic node name for CS35L41 speaker
      commit: 9e8e9be6c499d3dfa408b7306004c4b981622ff1

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi
index c53018ca81d7..cf2f5b74a4c2 100644
--- a/arch/arm64/boot/dts/qcom/msm8996.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi
@@ -1814,7 +1814,7 @@  spmi_bus: spmi@400f000 {
 			#interrupt-cells = <4>;
 		};
 
-		agnoc@0 {
+		bus@0 {
 			power-domains = <&gcc AGGRE0_NOC_GDSC>;
 			compatible = "simple-pm-bus";
 			#address-cells = <1>;