diff mbox series

[PATCHv6,4/7] dt-bindings: arm: rockchip: add initial rk3588 boards

Message ID 20221214182247.79824-5-sebastian.reichel@collabora.com
State Superseded
Headers show
Series None | expand

Commit Message

Sebastian Reichel Dec. 14, 2022, 6:22 p.m. UTC 
Add DT binding documentation for the Rockchip RK3588 EVB1,
Radxa Rock 5 Model A and B.

Co-Developed-by: Christopher Obbard <chris.obbard@collabora.com>
Signed-off-by: Christopher Obbard <chris.obbard@collabora.com>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
---
 .../devicetree/bindings/arm/rockchip.yaml         | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

Comments

Sebastian Reichel Jan. 7, 2023, 12:28 a.m. UTC | #1 
Hi Chris,

On Thu, Jan 05, 2023 at 07:20:19PM +0000, Christopher Obbard wrote:
> > +      - description: Radxa Rock 5 Model A
> > +        items:
> > +          - const: radxa,rock-5a
> > +          - const: rockchip,rk3588s
> > +
> > +      - description: Radxa Rock 5 Model B
> 
> Hi Sebastian,
> 
> To better match other boards from this vendor (e.g. RADXA ROCK 4)
> 
> would it be best to capitalise this (and obviously the model field in
> the respective DTS patches) the same?
> 
> So it would become "Radxa ROCK 5A" and "Radxa ROCK 5B".
> 
> It's also capitalised this way on the documentation website [1].
> 
> (I think the vendor has specifically dropped the Pi reference from
> these boards, but I don't know why)
> 
> Thanks!
> Chris
> 
> [1]: https://wiki.radxa.com/Rock5/5B

The current format has been requested by Radxa:

https://lore.kernel.org/all/892CB3E963AEF095+eaed7498-2324-9476-6a24-f940d62adb74@radxa.com/

Greetings,

-- Sebastian
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index c6c69a4e3777..49d442afe67f 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -620,6 +620,16 @@  properties:
           - const: radxa,rock3a
           - const: rockchip,rk3568
 
+      - description: Radxa Rock 5 Model A
+        items:
+          - const: radxa,rock-5a
+          - const: rockchip,rk3588s
+
+      - description: Radxa Rock 5 Model B
+        items:
+          - const: radxa,rock-5b
+          - const: rockchip,rk3588
+
       - description: Rikomagic MK808 v1
         items:
           - const: rikomagic,mk808
@@ -704,6 +714,11 @@  properties:
           - const: rockchip,rk3399-sapphire-excavator
           - const: rockchip,rk3399
 
+      - description: Rockchip RK3588 Evaluation board
+        items:
+          - const: rockchip,rk3588-evb1-v10
+          - const: rockchip,rk3588
+
       - description: Rockchip RV1108 Evaluation board
         items:
           - const: rockchip,rv1108-evb