| Message ID | 20221014221138.7552-2-quic_molvera@quicinc.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add base device tree files for QDU1000/QRU1000 | expand |
On 14/10/2022 18:11, Melody Olvera wrote: > Document the QDU1000 and QRU1000 SoC bindings and the boards that use > them. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml > index 1b5ac6b02bc5..3370a50644a6 100644 > --- a/Documentation/devicetree/bindings/arm/qcom.yaml > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml > @@ -40,6 +40,8 @@ description: | > msm8996 > msm8998 > qcs404 > + qdu1000 > + qru1000 > sa8155p > sa8540p > sc7180 > @@ -76,6 +78,7 @@ description: | > mtp > qrd > sbc > + x100 > > The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor> > where the minor number may be omitted when it's zero, i.e. v1.0 is the same > @@ -493,6 +496,19 @@ properties: > - const: google,pompom-sku0 > - const: qcom,sc7180 > > + - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform > + - items: > + - enum: > + - qcom,qdu1000-idp > + - qcom,qdu1000-x100 > + - const: qcom,qdu1000 > + > + - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform > + - items: > + - enum: > + -qcom,qru1000-idp > + - const: qcom,qru1000 This is still wrong order. All entries are ordered by SoC compatible. So this should go before sc7180, not after. > + > - description: Google Quackingstick (newest rev) > items: > - const: google,quackingstick-sku1537 Best regards, Krzysztof
On Fri, 14 Oct 2022 15:11:36 -0700, Melody Olvera wrote: > Document the QDU1000 and QRU1000 SoC bindings and the boards that use > them. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/arm/qcom.yaml:496:18: [error] syntax error: mapping values are not allowed here (syntax) dtschema/dtc warnings/errors: make[1]: *** Deleting file 'Documentation/devicetree/bindings/arm/qcom.example.dts' Documentation/devicetree/bindings/arm/qcom.yaml:496:18: mapping values are not allowed in this context make[1]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/arm/qcom.example.dts] Error 1 make[1]: *** Waiting for unfinished jobs.... ./Documentation/devicetree/bindings/arm/qcom.yaml:496:18: mapping values are not allowed in this context /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/arm/qcom.yaml: ignoring, error parsing file make: *** [Makefile:1420: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml index 1b5ac6b02bc5..3370a50644a6 100644 --- a/Documentation/devicetree/bindings/arm/qcom.yaml +++ b/Documentation/devicetree/bindings/arm/qcom.yaml @@ -40,6 +40,8 @@ description: | msm8996 msm8998 qcs404 + qdu1000 + qru1000 sa8155p sa8540p sc7180 @@ -76,6 +78,7 @@ description: | mtp qrd sbc + x100 The 'soc_version' and 'board_version' elements take the form of v<Major>.<Minor> where the minor number may be omitted when it's zero, i.e. v1.0 is the same @@ -493,6 +496,19 @@ properties: - const: google,pompom-sku0 - const: qcom,sc7180 + - description: Qualcomm Technologies, Inc. Distributed Unit 1000 platform + - items: + - enum: + - qcom,qdu1000-idp + - qcom,qdu1000-x100 + - const: qcom,qdu1000 + + - description: Qualcomm Technologies, Inc. Radio Unit 1000 platform + - items: + - enum: + -qcom,qru1000-idp + - const: qcom,qru1000 + - description: Google Quackingstick (newest rev) items: - const: google,quackingstick-sku1537
Document the QDU1000 and QRU1000 SoC bindings and the boards that use them. Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> --- Documentation/devicetree/bindings/arm/qcom.yaml | 16 ++++++++++++++++ 1 file changed, 16 insertions(+)