From patchwork Fri Dec 31 16:19:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 529578 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C10FC43219 for ; Fri, 31 Dec 2021 16:20:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231309AbhLaQUW (ORCPT ); Fri, 31 Dec 2021 11:20:22 -0500 Received: from smtp-relay-internal-0.canonical.com ([185.125.188.122]:54860 "EHLO smtp-relay-internal-0.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231274AbhLaQUS (ORCPT ); Fri, 31 Dec 2021 11:20:18 -0500 Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 18D423F32C for ; Fri, 31 Dec 2021 16:20:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1640967618; bh=DIlpbupBLlvhME495ccC/GJjqZBKtEWGWE9M06bGn4s=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=EgvEvMFwqyPDclxi6dUUzLMtzSpQQwoFGQ79OenrDABCkX9kfbXoDBXaXiPjZrX/4 Sf/kpgNECKU+ShgXQZIlVuyXHAEECs/6ch7kkuCEUJO1+FeR54qV538td4inBbcnB1 MZmv0E5OexUVYyBPhkxsuzp8Y8fLSCtzThDArqAHLl7KymoaBD8r8+zw0QU4qayBaW MpeA2xBTszKD6AeA0ruFi3/YFhZwNx1UzqsO9yM/Wh5iaHC4O0Wj8pLLQd0mN514cG ctpGGChcuTLnfZy7l7sscqCzknotUZ17dEf4lmT5CqfXus3VdyTNr2CCtvgcr47fgU Lwb0mfurUmsAA== Received: by mail-lj1-f200.google.com with SMTP id v19-20020a2e87d3000000b0022dbe4687f1so6707350ljj.7 for ; Fri, 31 Dec 2021 08:20:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DIlpbupBLlvhME495ccC/GJjqZBKtEWGWE9M06bGn4s=; b=4efdzYgvu4Dt1NN0RDpIfVl1SQ14J88zVe8RYKNwg+IF/l54OFCZ9d55epvD99XQpB 7hJTtYgBxNxD//ocZ50nDklvIRbsQfb6Qzg8bDYID6JedOX+xnN2CQaKfBYbGL1k0lL0 Td1UCCsTDCLn9zWhm2yfg/mvVaMAQ03PCv9ey4ZNMKKtJVJTLgRxfAQsQJShOn0ZCaU+ +Un4FuQAb0xooUJPvHnr9kILuJIhqG4ZzpS30B7teIsVcg0/VyItNfF11jxGw3zvvjoD jVBUqRxC9L/nCRRkN8L8+uaK4qlGi0yrvqa4eQycsJDoSlLIeE5FuAQJ21V2WTyIcIOR n/ZA== X-Gm-Message-State: AOAM530UzFgvL1RPg0/bs83Zufs+tp8pJ7/Ha5qbBi4lSGSaUGzLbcPe qaHtbu2Ib4qX80oh3iNv32e6bvnlpkhb6P4Dyd8jyht/inbC7QoVUeRmBvi+zuNeGcbxfW3CI+A JJQFdqlQWHa+V6q7xo638Aj1XSammvK9vx70JCtk= X-Received: by 2002:ac2:5297:: with SMTP id q23mr29964315lfm.192.1640967616486; Fri, 31 Dec 2021 08:20:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyJodevQXJIyAk4xZjnM+a51+YZ8a29g7tEjVrvpL5Dgq1KqQho2kvWsuAvQ/9Y8hwXYpClJw== X-Received: by 2002:ac2:5297:: with SMTP id q23mr29964305lfm.192.1640967616316; Fri, 31 Dec 2021 08:20:16 -0800 (PST) Received: from krzk-bin.lan (89-77-68-124.dynamic.chello.pl. [89.77.68.124]) by smtp.gmail.com with ESMTPSA id bx10sm2817607ljb.3.2021.12.31.08.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Dec 2021 08:20:15 -0800 (PST) From: Krzysztof Kozlowski To: Tomasz Figa , Krzysztof Kozlowski , Sylwester Nawrocki , Linus Walleij , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Marek Szyprowski , Sylwester Nawrocki , Sam Protsenko , Chanho Park Subject: [PATCH 02/24] pinctrl: samsung: accept GPIO bank nodes with a suffix Date: Fri, 31 Dec 2021 17:19:08 +0100 Message-Id: <20211231161930.256733-3-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> References: <20211231161930.256733-1-krzysztof.kozlowski@canonical.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Existing dt-bindings expected that each GPIO/pin bank within pin controller has its own node with name matching the bank (e.g. gpa0, gpx2) and "gpio-controller" property. The node name is then used for matching between driver data and DTS. Newly introduced dtschema expects to have nodes ending with "-gpio-bank" suffix, so rewrite bank-devicetree matching to look for old and new style of naming. Signed-off-by: Krzysztof Kozlowski --- drivers/pinctrl/samsung/pinctrl-samsung.c | 57 ++++++++++++++++++----- 1 file changed, 45 insertions(+), 12 deletions(-) diff --git a/drivers/pinctrl/samsung/pinctrl-samsung.c b/drivers/pinctrl/samsung/pinctrl-samsung.c index f2864a7869b3..561853df8ef7 100644 --- a/drivers/pinctrl/samsung/pinctrl-samsung.c +++ b/drivers/pinctrl/samsung/pinctrl-samsung.c @@ -1011,13 +1011,56 @@ static void samsung_banks_of_node_put(struct samsung_pinctrl_drv_data *d) of_node_put(bank->of_node); } +/* + * Iterate over all driver pin banks to find one matching the name of node, + * skipping optional "-gpio" node suffix. When found, assign node to the bank. + */ +static void samsung_banks_of_node_get(struct device *dev, + struct samsung_pinctrl_drv_data *d, + struct device_node *node) +{ + const char *suffix = "-gpio-bank"; + struct samsung_pin_bank *bank; + struct device_node *child; + /* Pin bank names are up to 4 characters */ + char node_name[20]; + unsigned int i; + size_t len; + + bank = d->pin_banks; + for (i = 0; i < d->nr_banks; ++i, ++bank) { + strscpy(node_name, bank->name, sizeof(node_name)); + len = strlcat(node_name, suffix, sizeof(node_name)); + if (len == sizeof(sizeof(node_name))) { + dev_err(dev, "Too long pin bank name '%s', ignoring\n", + bank->name); + continue; + } + + for_each_child_of_node(node, child) { + if (!of_find_property(child, "gpio-controller", NULL)) + continue; + if (of_node_name_eq(child, node_name)) + break; + else if (of_node_name_eq(child, bank->name)) + break; + } + + if (child) + bank->of_node = child; + else + dev_warn(dev, "Missing node for bank %s - invalid DTB\n", + bank->name); + /* child reference dropped in samsung_drop_banks_of_node() */ + } +} + /* retrieve the soc specific data */ static const struct samsung_pin_ctrl * samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d, struct platform_device *pdev) { struct device_node *node = pdev->dev.of_node; - struct device_node *np; const struct samsung_pin_bank_data *bdata; const struct samsung_pin_ctrl *ctrl; struct samsung_pin_bank *bank; @@ -1081,17 +1124,7 @@ samsung_pinctrl_get_soc_data(struct samsung_pinctrl_drv_data *d, */ d->virt_base = virt_base[0]; - for_each_child_of_node(node, np) { - if (!of_find_property(np, "gpio-controller", NULL)) - continue; - bank = d->pin_banks; - for (i = 0; i < d->nr_banks; ++i, ++bank) { - if (of_node_name_eq(np, bank->name)) { - bank->of_node = np; - break; - } - } - } + samsung_banks_of_node_get(&pdev->dev, d, node); d->pin_base = pin_base; pin_base += d->nr_pins;