| Message ID | 20210829223752.2748091-3-mnhagan88@gmail.com |
|---|---|
| State | Accepted |
| Commit | 38f8111369f318a538e9d4d89d8e48030c22fb40 |
| Headers | show |
| Series | [v2,1/5] ARM: dts: NSP: Add bcm958623hr board name to dts | expand |
On Sun, 29 Aug 2021 22:37:49 +0000, Matthew Hagan <mnhagan88@gmail.com> wrote: > While functional, the mdio-mux-mmioreg binding does not conform to > Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml in that an > mdio-mux compatible is also required. Without this the following output > is observed when running dtbs_check: > > mdio-mux@32000: compatible: ['mdio-mux-mmioreg'] is too short > > This change brings conformance to this requirement and corresponds > likewise to Rafal Milecki's change to the BCM5301x platform[1]. > > [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/ > > Signed-off-by: Matthew Hagan <mnhagan88@gmail.com> > --- Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks! -- Florian
diff --git a/arch/arm/boot/dts/bcm-nsp.dtsi b/arch/arm/boot/dts/bcm-nsp.dtsi index 6f2ccd059e73..180827500f25 100644 --- a/arch/arm/boot/dts/bcm-nsp.dtsi +++ b/arch/arm/boot/dts/bcm-nsp.dtsi @@ -371,7 +371,7 @@ mdio: mdio@32000 { }; mdio-mux@32000 { - compatible = "mdio-mux-mmioreg"; + compatible = "mdio-mux-mmioreg", "mdio-mux"; reg = <0x32000 0x4>; mux-mask = <0x200>; #address-cells = <1>; diff --git a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi index 8860f2fefc63..57d0c5eb9749 100644 --- a/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi +++ b/arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi @@ -72,7 +72,7 @@ led-5 { }; mdio-mii-mux { - compatible = "mdio-mux-mmioreg"; + compatible = "mdio-mux-mmioreg", "mdio-mux"; reg = <0x1803f1c0 0x4>; mux-mask = <0x2000>; mdio-parent-bus = <&mdio_ext>;
While functional, the mdio-mux-mmioreg binding does not conform to Documentation/devicetree/bindings/net/mdio-mux-mmioreg.yaml in that an mdio-mux compatible is also required. Without this the following output is observed when running dtbs_check: mdio-mux@32000: compatible: ['mdio-mux-mmioreg'] is too short This change brings conformance to this requirement and corresponds likewise to Rafal Milecki's change to the BCM5301x platform[1]. [1] https://lore.kernel.org/linux-arm-kernel/20210822191256.3715003-1-f.fainelli@gmail.com/T/ Signed-off-by: Matthew Hagan <mnhagan88@gmail.com> --- arch/arm/boot/dts/bcm-nsp.dtsi | 2 +- arch/arm/boot/dts/bcm958625-meraki-alamo.dtsi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)