| Message ID | 20210820190346.18550-5-p.yadav@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | Rx mode support for Cadence DPHY | expand |
Hi Pratyush, Thank you for the patch. On Sat, Aug 21, 2021 at 12:33:44AM +0530, Pratyush Yadav wrote: > The clocks are not used by the DPHY when used in Rx mode so make them > optional. > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > Acked-by: Rob Herring <robh@kernel.org> > > --- > > (no changes since v3) > > Changes in v3: > - Add Rob's Ack. > > Changes in v2: > - Re-order subject prefixes. > > Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > index b90a58773bf2..3bb5be05e825 100644 > --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > @@ -33,8 +33,6 @@ properties: > required: > - compatible > - reg > - - clocks > - - clock-names Could you turn this into a conditional requirement based on the compat string, as the clocks are needed in the TX case ? > - "#phy-cells" > > additionalProperties: false -- Regards, Laurent Pinchart
On 23/08/21 04:40AM, Laurent Pinchart wrote: > Hi Pratyush, > > Thank you for the patch. > > On Sat, Aug 21, 2021 at 12:33:44AM +0530, Pratyush Yadav wrote: > > The clocks are not used by the DPHY when used in Rx mode so make them > > optional. > > > > Signed-off-by: Pratyush Yadav <p.yadav@ti.com> > > Acked-by: Rob Herring <robh@kernel.org> > > > > --- > > > > (no changes since v3) > > > > Changes in v3: > > - Add Rob's Ack. > > > > Changes in v2: > > - Re-order subject prefixes. > > > > Documentation/devicetree/bindings/phy/cdns,dphy.yaml | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > > index b90a58773bf2..3bb5be05e825 100644 > > --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > > +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml > > @@ -33,8 +33,6 @@ properties: > > required: > > - compatible > > - reg > > - - clocks > > - - clock-names > > Could you turn this into a conditional requirement based on the compat > string, as the clocks are needed in the TX case ? Ok, will do. > > > - "#phy-cells" > > > > additionalProperties: false > > -- > Regards, > > Laurent Pinchart -- Regards, Pratyush Yadav Texas Instruments Inc.
diff --git a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml index b90a58773bf2..3bb5be05e825 100644 --- a/Documentation/devicetree/bindings/phy/cdns,dphy.yaml +++ b/Documentation/devicetree/bindings/phy/cdns,dphy.yaml @@ -33,8 +33,6 @@ properties: required: - compatible - reg - - clocks - - clock-names - "#phy-cells" additionalProperties: false