| Message ID | 20210803125411.28066-13-srinivas.kandagatla@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | ASoC: qcom: Add AudioReach support | expand |
On Tue, Aug 03, 2021 at 01:54:03PM +0100, Srinivas Kandagatla wrote: > + enum: > + - qcom,q6afe-clocks > + - qcom,q6prm-clocks Again, what do these mean? One of the goals with DT bindings documentation is to be able to relate hardware to bindings.
Thanks Mark for the review, On 04/08/2021 19:02, Mark Brown wrote: > On Tue, Aug 03, 2021 at 01:54:03PM +0100, Srinivas Kandagatla wrote: > >> + enum: >> + - qcom,q6afe-clocks >> + - qcom,q6prm-clocks > > Again, what do these mean? One of the goals with DT bindings > documentation is to be able to relate hardware to bindings. > Old Elite QDSP framework has service called "Audio Front End" aka q6afe which is responsible for managing the LPASS Audio clocks. So We endup with "qcom,q6afe-clocks" in the past to represent this. With New AudioReach framework this functionality is now managed by "Proxy Resource Manager" aka q6prm. I will rename "qcom,q6prm-clocks" to "qcom,q6prm-lpass-clocks" to be more explicit about the hardware LPASS (Low Power Audio Sub System)IP here. --srini
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-clocks.yaml b/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-clocks.yaml index 03ab7451eb1c..c4814ae00712 100644 --- a/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-clocks.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,q6dsp-audio-clocks.yaml @@ -14,7 +14,9 @@ description: | properties: compatible: - const: qcom,q6afe-clocks + enum: + - qcom,q6afe-clocks + - qcom,q6prm-clocks reg: maxItems: 1 @@ -53,3 +55,20 @@ examples: }; }; }; + + - | + #include <dt-bindings/soc/qcom,gpr.h> + gpr { + #address-cells = <1>; + #size-cells = <0>; + gpr-service@2 { + reg = <GPR_PRM_MODULE_IID>; + #address-cells = <1>; + #size-cells = <0>; + q6prmcc@2 { + compatible = "qcom,q6prm-clocks"; + reg = <2>; + #clock-cells = <2>; + }; + }; + };
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> --- .../sound/qcom,q6dsp-audio-clocks.yaml | 21 ++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) -- 2.21.0