diff mbox series

[v3,1/7] dt-bindings: clock: qcom,dispcc-sm8x50: add mmcx power domain

Message ID 20210709173202.667820-2-dmitry.baryshkov@linaro.org
State Superseded
Headers show
Series clk: qcom: use power-domain for sm8250's clock controllers | expand

Commit Message

Dmitry Baryshkov July 9, 2021, 5:31 p.m. UTC
On sm8250 dispcc requires MMCX power domain to be powered up before
clock controller's registers become available. For now sm8250 was using
external regulator driven by the power domain to describe this
relationship. Switch into specifying power-domain and required opp-state
directly.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

---
 .../devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml      | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.30.2

Comments

Bjorn Andersson July 9, 2021, 6:54 p.m. UTC | #1
On Fri 09 Jul 12:31 CDT 2021, Dmitry Baryshkov wrote:

> On sm8250 dispcc requires MMCX power domain to be powered up before

> clock controller's registers become available. For now sm8250 was using

> external regulator driven by the power domain to describe this

> relationship. Switch into specifying power-domain and required opp-state

> directly.

> 


Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>


Regards,
Bjorn

> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

> ---

>  .../devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml      | 7 +++++++

>  1 file changed, 7 insertions(+)

> 

> diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml

> index 0cdf53f41f84..d5c4fed56b6e 100644

> --- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml

> +++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml

> @@ -55,6 +55,11 @@ properties:

>    reg:

>      maxItems: 1

>  

> +  power-domains:

> +    description:

> +      A phandle and PM domain specifier for the MMCX power domain.

> +    maxItems: 1

> +

>  required:

>    - compatible

>    - reg

> @@ -69,6 +74,7 @@ additionalProperties: false

>  examples:

>    - |

>      #include <dt-bindings/clock/qcom,rpmh.h>

> +    #include <dt-bindings/power/qcom-rpmpd.h>

>      clock-controller@af00000 {

>        compatible = "qcom,sm8250-dispcc";

>        reg = <0x0af00000 0x10000>;

> @@ -89,5 +95,6 @@ examples:

>        #clock-cells = <1>;

>        #reset-cells = <1>;

>        #power-domain-cells = <1>;

> +      power-domains = <&rpmhpd SM8250_MMCX>;

>      };

>  ...

> -- 

> 2.30.2

>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
index 0cdf53f41f84..d5c4fed56b6e 100644
--- a/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,dispcc-sm8x50.yaml
@@ -55,6 +55,11 @@  properties:
   reg:
     maxItems: 1
 
+  power-domains:
+    description:
+      A phandle and PM domain specifier for the MMCX power domain.
+    maxItems: 1
+
 required:
   - compatible
   - reg
@@ -69,6 +74,7 @@  additionalProperties: false
 examples:
   - |
     #include <dt-bindings/clock/qcom,rpmh.h>
+    #include <dt-bindings/power/qcom-rpmpd.h>
     clock-controller@af00000 {
       compatible = "qcom,sm8250-dispcc";
       reg = <0x0af00000 0x10000>;
@@ -89,5 +95,6 @@  examples:
       #clock-cells = <1>;
       #reset-cells = <1>;
       #power-domain-cells = <1>;
+      power-domains = <&rpmhpd SM8250_MMCX>;
     };
 ...