From patchwork Thu Mar 18 10:40:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 403972 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp357068jai; Thu, 18 Mar 2021 03:42:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyiqTdAgFrW9tLWqGOhUZuzltMJbYNfMaSW+eQaAnZRghN84CWwq0V/8rrYi5e8IE9bJsiR X-Received: by 2002:a17:907:2661:: with SMTP id ci1mr39575874ejc.403.1616064126577; Thu, 18 Mar 2021 03:42:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1616064126; cv=none; d=google.com; s=arc-20160816; b=BECUEz9EnpDnkbge9SW2prCL+2DrIFS1SjnFG9c9wFroeH9EQjx3/sekz2luWxv1/c 6Wls3AMLtQEqCCawc5o1mspDZDfIQpf+y2HKeMKkDuUbFtGW/XYsZNAdIfHgmJhhnbmv 4YFSxZ1oRnLWXSziOFj9pZuGvgic86ujK/H2Jfz12BN43bnU2rUdTqvD/1aXozRC/UMl bcignzFlnyfv0c0IqHLBEuqgoY4amSGpX1iAefsMBrE4Gep9KO4E+fhPkkCI+xKP7T2O O/eYT35varGOTCLOwTalV6/l1H1DZcurI9LPU0wZ15LvrY0LpDGscYJzlEv+4vA9vGjN dEbQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=p93RSQraOmdRnXpBn6AdELj34NhQouUv0hXIunYHDbU=; b=Yl3o7RnGB9j5CkoaOybzhziVuetn98qo5xgu5A6YMrTktUfqf91IgWkmQBVl3j/4gT p6rH+ZuOU0IBKVfZp7014WMCpWu5QSFkVwH/2DxXsijIQf7xzyIiowWdY+RBKOAzwNdR Z6m0Z5bDdUi+kYD71i9kYc/ROkHaMFRHQsgQLRVIKonXhqATW6fEnqoxQcU0FbFkqdgE Nod4W9Bh5a9RWYN6ouhRqU6zZci7TgAuLBtyL7ue4IplPkPT2SNROYLgglmdF1ld4+eL a/1Js4wVCSy7ddhW5oX8fCqMZ9vfONGnVP230G45cMPMCJ5xRc8LoQBQsqlfRDSLUHZe +ytQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rO8Z4QIM; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z22si1279805edx.180.2021.03.18.03.42.06; Thu, 18 Mar 2021 03:42:06 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rO8Z4QIM; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbhCRKle (ORCPT + 6 others); Thu, 18 Mar 2021 06:41:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230260AbhCRKlB (ORCPT ); Thu, 18 Mar 2021 06:41:01 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C30B0C06174A for ; Thu, 18 Mar 2021 03:40:51 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id a132-20020a1c668a0000b029010f141fe7c2so2880772wmc.0 for ; Thu, 18 Mar 2021 03:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=p93RSQraOmdRnXpBn6AdELj34NhQouUv0hXIunYHDbU=; b=rO8Z4QIM1BizCvyGUPP8TY5VqNFZM8Vtqw56fkZnF7B95OJSVNgMK+BKygDffOJkpn YAjoTpAYUFF9DlpyryfL20qh+5X7p3YnkjPp8e+UU9kGv8TcG8bg/ABwhqiEJZHzkaxW qqTSmn+zBqQ8BOUSmmiGmrYP5gnHGTr+B1yJ3qBNS81fIPocdKG6j957kbdkZp3CkY+f JVtoQ3KkVkofgujrLhV/1pRxdowN9V6MQc5g3+0nrnw0yFiuBOSy9oUbCpJIveYLIxv0 5NUA7qq3IgPYSNaUgRVH6914CYTeGScMvvnRyhkkFal7QIh8LqVGvzac8th/NRdjet/V uuQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=p93RSQraOmdRnXpBn6AdELj34NhQouUv0hXIunYHDbU=; b=WnPY1B/B27iTcbksBNxBK+Rq8s0UQwtHL4kCG3NJE7piqbTHP0l56pfE+u1hFjsasJ /gXB9f7KUBBWeubGK/uaLHRX2Hl/A8VoNwmfOgPG3cxv4FcHFhs6m2C/pEhNxJTnG3t3 PPcSEq9JYY4ccDMgQuTJ+Vfr5GyNqazvrou3v1AyfNcZo57kj6pCG2QyItw7bpzBw+vC 0zVQTHdWsDwWHMyQCd8P5XmgI7wnfNSEZ45UZlD+adwD7OqVBAPFMMq/hzXcEG4HgaBV suuThw4Wd08fjYosa6wrIL/nOz79RF81OBQEZo6BvFCH5o5b2BV22BajlM+OcYNc2TkW yUsw== X-Gm-Message-State: AOAM531ygQ8iaUFQ92ynUFHa0bF6qH5QTM07EHbhJM5iXFnw+Y21yqt3 71994UqH8ugrplQ4iFQrWUIe7g== X-Received: by 2002:a05:600c:608:: with SMTP id o8mr3096483wmm.42.1616064050494; Thu, 18 Mar 2021 03:40:50 -0700 (PDT) Received: from dell.default ([91.110.221.194]) by smtp.gmail.com with ESMTPSA id z1sm2426033wru.95.2021.03.18.03.40.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Mar 2021 03:40:50 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Rob Herring , Frank Rowand , benh@kernel.crashing.org, devicetree@vger.kernel.org Subject: [PATCH 07/10] of: fdt: Demote kernel-doc abuses and fix function naming Date: Thu, 18 Mar 2021 10:40:33 +0000 Message-Id: <20210318104036.3175910-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210318104036.3175910-1-lee.jones@linaro.org> References: <20210318104036.3175910-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/of/fdt.c:478: warning: Function parameter or member 'node' not described in '__reserved_mem_reserve_reg' drivers/of/fdt.c:478: warning: Function parameter or member 'uname' not described in '__reserved_mem_reserve_reg' drivers/of/fdt.c:525: warning: Function parameter or member 'node' not described in '__reserved_mem_check_root' drivers/of/fdt.c:547: warning: Function parameter or member 'node' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: Function parameter or member 'uname' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: Function parameter or member 'depth' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: Function parameter or member 'data' not described in '__fdt_scan_reserved_mem' drivers/of/fdt.c:547: warning: expecting prototype for fdt_scan_reserved_mem(). Prototype was for __fdt_scan_reserved_mem() instead drivers/of/fdt.c:663: warning: Function parameter or member 'parent' not described in 'of_scan_flat_dt_subnodes' drivers/of/fdt.c:708: warning: Function parameter or member 'node' not described in 'of_get_flat_dt_prop' drivers/of/fdt.c:708: warning: Function parameter or member 'name' not described in 'of_get_flat_dt_prop' drivers/of/fdt.c:708: warning: Function parameter or member 'size' not described in 'of_get_flat_dt_prop' drivers/of/fdt.c:758: warning: Function parameter or member 'node' not described in 'of_flat_dt_match' drivers/of/fdt.c:758: warning: Function parameter or member 'compat' not described in 'of_flat_dt_match' drivers/of/fdt.c:778: warning: Function parameter or member 'node' not described in 'of_get_flat_dt_phandle' drivers/of/fdt.c:778: warning: expecting prototype for of_get_flat_dt_prop(). Prototype was for of_get_flat_dt_phandle() instead drivers/of/fdt.c:955: warning: Function parameter or member 'node' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:955: warning: Function parameter or member 'uname' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:955: warning: Function parameter or member 'depth' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:955: warning: Function parameter or member 'data' not described in 'early_init_dt_scan_root' drivers/of/fdt.c:991: warning: Function parameter or member 'node' not described in 'early_init_dt_scan_memory' drivers/of/fdt.c:991: warning: Function parameter or member 'uname' not described in 'early_init_dt_scan_memory' drivers/of/fdt.c:991: warning: Function parameter or member 'depth' not described in 'early_init_dt_scan_memory' drivers/of/fdt.c:991: warning: Function parameter or member 'data' not described in 'early_init_dt_scan_memory' Cc: Rob Herring Cc: Frank Rowand Cc: benh@kernel.crashing.org Cc: devicetree@vger.kernel.org Signed-off-by: Lee Jones --- drivers/of/fdt.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) -- 2.27.0 diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c index dcc1dd96911a9..4d6d195e089aa 100644 --- a/drivers/of/fdt.c +++ b/drivers/of/fdt.c @@ -470,7 +470,7 @@ void *initial_boot_params __ro_after_init; static u32 of_fdt_crc32; -/** +/* * __reserved_mem_reserve_reg() - reserve all memory described in 'reg' property */ static int __init __reserved_mem_reserve_reg(unsigned long node, @@ -516,7 +516,7 @@ static int __init __reserved_mem_reserve_reg(unsigned long node, return 0; } -/** +/* * __reserved_mem_check_root() - check if #size-cells, #address-cells provided * in /reserved-memory matches the values supported by the current implementation, * also check if ranges property has been provided @@ -539,8 +539,8 @@ static int __init __reserved_mem_check_root(unsigned long node) return 0; } -/** - * fdt_scan_reserved_mem() - scan a single FDT node for reserved memory +/* + * __fdt_scan_reserved_mem() - scan a single FDT node for reserved memory */ static int __init __fdt_scan_reserved_mem(unsigned long node, const char *uname, int depth, void *data) @@ -650,6 +650,7 @@ int __init of_scan_flat_dt(int (*it)(unsigned long node, /** * of_scan_flat_dt_subnodes - scan sub-nodes of a node call callback on each. + * @parent: parent node * @it: callback function * @data: context data pointer * @@ -689,7 +690,7 @@ int __init of_get_flat_dt_subnode_by_name(unsigned long node, const char *uname) return fdt_subnode_offset(initial_boot_params, node, uname); } -/** +/* * of_get_flat_dt_root - find the root node in the flat blob */ unsigned long __init of_get_flat_dt_root(void) @@ -697,7 +698,7 @@ unsigned long __init of_get_flat_dt_root(void) return 0; } -/** +/* * of_get_flat_dt_prop - Given a node in the flat blob, return the property ptr * * This function can be used within scan_flattened_dt callback to get @@ -751,7 +752,7 @@ int __init of_flat_dt_is_compatible(unsigned long node, const char *compat) return of_fdt_is_compatible(initial_boot_params, node, compat); } -/** +/* * of_flat_dt_match - Return true if node matches a list of compatible values */ static int __init of_flat_dt_match(unsigned long node, const char *const *compat) @@ -771,8 +772,8 @@ static int __init of_flat_dt_match(unsigned long node, const char *const *compat return score; } -/** - * of_get_flat_dt_prop - Given a node in the flat blob, return the phandle +/* + * of_get_flat_dt_phandle - Given a node in the flat blob, return the phandle */ uint32_t __init of_get_flat_dt_phandle(unsigned long node) { @@ -947,7 +948,7 @@ int __init early_init_dt_scan_chosen_stdout(void) } #endif -/** +/* * early_init_dt_scan_root - fetch the top level address and size cells */ int __init early_init_dt_scan_root(unsigned long node, const char *uname, @@ -983,7 +984,7 @@ u64 __init dt_mem_next_cell(int s, const __be32 **cellp) return of_read_number(p, s); } -/** +/* * early_init_dt_scan_memory - Look for and parse memory nodes */ int __init early_init_dt_scan_memory(unsigned long node, const char *uname,