From patchwork Tue Mar 16 21:08:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 403413 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER, INCLUDES_PATCH, MAILING_LIST_MULTI, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F0CCC433E6 for ; Tue, 16 Mar 2021 21:09:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 48AF464F64 for ; Tue, 16 Mar 2021 21:09:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231713AbhCPVJV (ORCPT ); Tue, 16 Mar 2021 17:09:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbhCPVJC (ORCPT ); Tue, 16 Mar 2021 17:09:02 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 93352C061762 for ; Tue, 16 Mar 2021 14:09:02 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id l2so23465400pgb.1 for ; Tue, 16 Mar 2021 14:09:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=h3nGRIVAZ8p8oH1+FLMCV0ztlq3vh7E/c3Mkltgxfig=; b=At7nxtTZi0r6E/hJAVN5l/dmCfxqOqkm3CirquJCcbKRpxNEj0UlA5R04342G4ZGjg kj2dlf4h7ZIt8YPErpECIjgVtEWlTsoP7vnhaK1z+6SgXoIUci+gdClvaxnPSRnQ6b0X qid///YOVCa2O4AGOuVeqknyZaDXXF+sgX+Jc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=h3nGRIVAZ8p8oH1+FLMCV0ztlq3vh7E/c3Mkltgxfig=; b=bfJJcL2Rpp81M7/sDYHkAlDW9M0MYe92OYgJxSDO9kED4ECji3trRu8xHR56lL929V OE0QT9/r51xMQSeX5Q4S/KkEwUHoMOcHsLQfLvk0avrN45F4JxYuKFVngxQCrD2iMm6I 9ff7a0h4lV0cvD2ixyh0wSHY7Hes2AVC7WhUQtBE4BBDXjyGwqSAgXNeGm1GwmoQxnQz zICQbsUVOUt8yPpmfQp8fvVGFSSLTm7Ya92kAidJOigDgcO87efzrgBhFJ2OAraHk41v Y5wqGtuaAtH9czaWytmi5Agm2dwmkDysnx8CNTck+Xd6mBgGhV1LqRtNKl2YozTfDhmD chjg== X-Gm-Message-State: AOAM532otWAaS0UhPGmWeFVaHjycImbsZyuphOmWTeHcud392uh+czk3 A1uSeo9vqNlDjTeXL6fOBbv74Q== X-Google-Smtp-Source: ABdhPJx+sDl3T3tfWxKBS3KMgRQuF3wDhkFfazknzXEMfmOKK8tHUBXu5QUQSZhXOidpHjnVGnihHA== X-Received: by 2002:a63:f311:: with SMTP id l17mr1405391pgh.349.1615928942134; Tue, 16 Mar 2021 14:09:02 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:84d6:7fd1:d469:351f]) by smtp.gmail.com with ESMTPSA id 192sm17358072pfa.122.2021.03.16.14.09.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 Mar 2021 14:09:01 -0700 (PDT) From: Douglas Anderson To: Bjorn Andersson , Rob Herring , Thierry Reding , Sam Ravnborg Cc: robdclark@chromium.org, Daniel Vetter , dri-devel@lists.freedesktop.org, David Airlie , devicetree@vger.kernel.org, swboyd@chromium.org, linux-arm-msm@vger.kernel.org, Steev Klimaszewski , eballetbo@gmail.com, Andy Gross , Linus Walleij , drinkcat@chromium.org, Douglas Anderson , linux-kernel@vger.kernel.org Subject: [RFC PATCH 2/3] drm/panel: panel-simple: Add the panel on sc7180-trogdor-pompom Date: Tue, 16 Mar 2021 14:08:20 -0700 Message-Id: <20210316140707.RFC.2.Ie81e36b66aadc4afe29eb6ae9126177b811c381e@changeid> X-Mailer: git-send-email 2.31.0.rc2.261.g7f71774620-goog In-Reply-To: <20210316140707.RFC.1.I3a21995726282f1e9fcb70da5eb96f19ed96634f@changeid> References: <20210316140707.RFC.1.I3a21995726282f1e9fcb70da5eb96f19ed96634f@changeid> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This adds an entry to simple panel for the timings of a panel that might be attached to the board sc7180-trogdor-pompom. As talked about in the previous patch ("dt-bindings: display: simple: Add the panel on sc7180-trogdor-pompom") any number of panels might be attached. These panels might have different timings or even different resolutions. When we see a pompom panel we'll use some conservative power sequence timings that can work with any of the panels that will be attached. All the rest of the details about the panel can be found by read its EDID. NOTE: if we wanted to optimize things a bit we could figure out which of the panels was actually attached and perhaps reduce some of the timings by a tiny bit if it was a panel that we recognized. I won't attempt this right now but it could be a nice future optimization, epsecially getting rid of the 200 ms "enable delay" imposed by the Starry panel. Signed-off-by: Douglas Anderson --- For overall discussion about the idea of defining a generic panel at the board level, please respond in the bindings patch so we can keep all discussion in one place. drivers/gpu/drm/panel/panel-simple.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 4e2dad314c79..c8964efd562b 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -2205,6 +2205,15 @@ static const struct panel_desc hitachi_tx23d38vm0caa = { }, }; +static const struct panel_desc google_pompom_panel = { + .delay = { + .hpd_absent_delay = 200, + .enable = 200, + .unprepare = 500, + }, + .connector_type = DRM_MODE_CONNECTOR_eDP, +}; + static const struct drm_display_mode innolux_at043tn24_mode = { .clock = 9000, .hdisplay = 480, @@ -4265,6 +4274,9 @@ static const struct of_device_id platform_of_match[] = { }, { .compatible = "hit,tx23d38vm0caa", .data = &hitachi_tx23d38vm0caa + }, { + .compatible = "google,pompom-panel", + .data = &google_pompom_panel, }, { .compatible = "innolux,at043tn24", .data = &innolux_at043tn24,