From patchwork Mon Mar 15 15:59:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 400493 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp3546738jai; Mon, 15 Mar 2021 09:01:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyOwJQzeTBtEKwfVZKFv7cXiUyq/h9NGoUiadHxIw+zVy0osZo9x4p8wYCxJWFPNBCVulT1 X-Received: by 2002:a1c:e184:: with SMTP id y126mr339559wmg.163.1615824073018; Mon, 15 Mar 2021 09:01:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1615824073; cv=none; d=google.com; s=arc-20160816; b=e26Z6eTmMkarBwAgm25se+s1ZE4ZDLPpRehgF8Shg4yvCfAyfk/XVjqac8IA9eT0/c MRXt+WktZq9k+yPIXtj2QiRUeEewnHo2Ik4E918kxo0Wj6fPTbLt5JtrZpXEUaT2/coo v15mZNo+HQ0qfAjKgWfvIw5tiVqMZe153rYuJeID3A7tn1rW5/Rifq4qVsHn303OMSoJ tOj4CYzS9+WFmfaquue7Q5dkYtSaUmEQExZNHxIQIqnkY2HK9hLpkIrFyaDwJQQQULbn D6m1YvmDfoQ7VlBM8zu03KlJR41hI88cWGVlILa26AGI8rgtv8d6NHkHeRDLwP02vS+n dQTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ej7xOSZO0R65foWhNJ0JMxxsG9s/H1fy7cCdiAqZQjQ=; b=sOjMs1XTEU1dn/F28COQq3RlcgCpl4cbwyJwfAPAweJ9zZE34Mta7SNQJRWoKTb8am K+sqdVeJNNycfBBpIpDVciTE9Z27XiFOi1v04pwf84f6darWxMwhDH651kEbj+jFkOMH 9oCN5Q+jDInXAf59fATRQpQ7ETFNlLY+cB8Y9PDP16aKrzmim7DM7mRjzgIXhtEt9F0w Ddt2D3TFl6x+OPlpRMK4Pfq8WY0CoRvjn8pwxwadxpfCB3COypDZyf6Kobxi3GgcGKRJ BU3auHjj+IibE3t71oTy7ROxVp17ENesDuubRsDg4rBUWBq6AEitnzPuUPLrzmZwgZ78 KEYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iWKapvP5; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ga15si11470494ejc.24.2021.03.15.09.01.12; Mon, 15 Mar 2021 09:01:13 -0700 (PDT) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=iWKapvP5; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231503AbhCOQAi (ORCPT + 6 others); Mon, 15 Mar 2021 12:00:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231679AbhCOQA1 (ORCPT ); Mon, 15 Mar 2021 12:00:27 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 09E71C061762 for ; Mon, 15 Mar 2021 09:00:27 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id t9so5950970wrn.11 for ; Mon, 15 Mar 2021 09:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ej7xOSZO0R65foWhNJ0JMxxsG9s/H1fy7cCdiAqZQjQ=; b=iWKapvP5snj2BIegwBWCgs7oi835uqSMcSh0tRpH9TF8ZFMi/OB/adnXNyeaJasmCZ G9zjQBLzL0HyrhTV/dzhVTlowodLzArFqYiU2ManJyMeZ+/wVBv905JlQANb76YL3ebi bSm7fCeuBdeXNG9lZjdbjLAuNx0qK3YVvgwBqDUVKJrpY2YL3Xi4vEdWIvCuUT7AC72D IZO6YWANVll46/Jv9bZgO/asi+bZQFykufGLi/IwJiI9ClxeFzzkKoD7WlcQGEgHIJG9 hTINplvsNVKyBqTLnHmUq8qq8fQjZBWXqh/ZilbBjunXfpTXIvJYINcrqFXGcXjY7xwL 6xRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ej7xOSZO0R65foWhNJ0JMxxsG9s/H1fy7cCdiAqZQjQ=; b=R0Vsa6ooRTkGKBUDN8cSW2qIo6E0DdHW7jfd7hmkh5TG2iMN1jCFNWX66+t/6ciZe9 FCA5I857bKT7w7+cztKIHxbLG/76CcC0Ycd5RTKs239bIcDIUD1x+FWuEmd37GZWCpxB YK9561Dfy2Rw10Qff+StO7nJb+t/+S/Wkhu1PkV+9pfIyfAWv+wWYXsGLylWqs47oAMQ 10YFPjTmQKGFEAbo1DgwhwBE2F0Vubh8zTGJ9RHNMoyqsb7p8q7PjHjnxmmVAuUOJhnc GuQ/SjztltIYUiKpWubpv9tfrI/H4S+OhVHV9lC797fKTEbbx2qNgRg1eggQkZJqRlnC xLRQ== X-Gm-Message-State: AOAM530sVI0pRPrazHWn7jgEI33uw/2/fUelBGIqRWZHfiXyT/cYKVE3 kGdCPQaaHqvKqHrSHJhlrmMYhrXvX2CQLNDx X-Received: by 2002:aa7:c907:: with SMTP id b7mr31371404edt.37.1615824015097; Mon, 15 Mar 2021 09:00:15 -0700 (PDT) Received: from localhost.localdomain ([37.120.1.234]) by smtp.gmail.com with ESMTPSA id r5sm8456445eds.49.2021.03.15.09.00.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Mar 2021 09:00:14 -0700 (PDT) From: Robert Foss To: agross@kernel.org, bjorn.andersson@linaro.org, robert.foss@linaro.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, angelogioacchino.delregno@somainline.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Sakari Ailus , Andrey Konovalov , Hans Verkuil Cc: Rob Herring , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek , Nicolas Boichat Subject: [PATCH v8 03/22] media: camss: Replace trace_printk() with dev_dbg() Date: Mon, 15 Mar 2021 16:59:24 +0100 Message-Id: <20210315155942.640889-4-robert.foss@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210315155942.640889-1-robert.foss@linaro.org> References: <20210315155942.640889-1-robert.foss@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org trace_printk() should not be used in production code, since extra memory is used for special buffers whenever trace_puts() is used. Replace it with dev_dbg() which provides all of the desired debugging functionality. Signed-off-by: Robert Foss Suggested-by: Nicolas Boichat Reviewed-by: Nicolas Boichat --- Changes since v3: - Nicolas: Create this patch Changes since v4: - Nicolas: Add r-b drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++-- drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.27.0 diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index a1b56b89130d..85b9bcbc7321 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 84c33b8f9fe3..f7e00a2de393 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe);