From patchwork Thu Mar 11 18:09:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Robert Foss X-Patchwork-Id: 397546 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp535996jai; Thu, 11 Mar 2021 10:11:12 -0800 (PST) X-Google-Smtp-Source: ABdhPJwzYolFFhcukfDXRhLLh93AMc3EB0kiXKcI0CT0PSmWt8tpn7TRAU46sZivGNuDdjqIrQr+ X-Received: by 2002:a17:907:2661:: with SMTP id ci1mr4225936ejc.403.1615486271973; Thu, 11 Mar 2021 10:11:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615486271; cv=none; d=google.com; s=arc-20160816; b=lvc51AUCK6jkg8JdUdZouzF7r25VCAjF0Ncwm38dbrvHDtlykbkMAo8BpiUKnWdUlO EUybiziQS4YE26CQqE2mUyVeaKejp8u6AMqwI4OdTJqDiEPsyVOnX+2ZyUMFVY9M3/5H tGoUG9MapgZG+u3RIkqa95ZRUls5kgNd+z1FqB+xNFcTib7Y7E/PEvN+b8OXlxTIMTMy 6EmqbllpCMhPK1VjM9XBj5DX0ygqkYpiePRUZYzRiZq2aJ+z2VX2xQ+uGwJnLjzmR2C0 Mxbl88qw6CyqAtZ29+PdaG4uB9aJcmKK6uNVbS0Dwk78222TPuDnLGrcXtaJtPgXYu5z V2/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=mxyW1onhXDiHAxxUJjBsSs0nMCqFkArlx/FPrMEURJM=; b=SRGrZWOtUvalO+G5qCb9zYLyz0NhpGJdbbeNb9sPmEYbXnMuadY5aKkaHLgNUgghbu c247akx320bG+jKl1lI1nz4VnALlMb2ysWqMnwZvfcaO25MSuUHKG29r7w/sqLbiv+rP uqtRMoWPH6gITpwl9vVU75VSqFcFtBp0zXaYLaqAHerggyVn0WsfuG/0fNsnkqLEy/9x 52Y1yNr4sHFsTMlH/XlJFTymOTnxeWbtpXWNh3bRR03rLIgcUcGjcqgWImWkNCPGMfGM zWc/lQE7ea280Zz2LBcpQpyKChzD7/A9nDfvj4shai05bjo+OWk6eR41axePmknsQ8Dm 19/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ffIVGKH+; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg2si1771266edb.136.2021.03.11.10.11.11; Thu, 11 Mar 2021 10:11:11 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=ffIVGKH+; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229828AbhCKSKc (ORCPT + 6 others); Thu, 11 Mar 2021 13:10:32 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50734 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230154AbhCKSKE (ORCPT ); Thu, 11 Mar 2021 13:10:04 -0500 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77504C061761 for ; Thu, 11 Mar 2021 10:10:04 -0800 (PST) Received: by mail-ej1-x629.google.com with SMTP id c10so48081970ejx.9 for ; Thu, 11 Mar 2021 10:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mxyW1onhXDiHAxxUJjBsSs0nMCqFkArlx/FPrMEURJM=; b=ffIVGKH+PAc55h8ya/6dZjK1asTfvVkhbxgO3eRZizelpZ3TGUki0MWSGCLa4l/CuS Yf82tXquF0O/T024aBvlgDbqYC9igocLnta6PBX4TTgm5EuRvsH39iGAaxPv+bMUCQ8Y qqZ7Htbj6gLHNOaNs3V+3xnSt4caDEDhlYTbM5Nl49YPGXvJuGOnPCFhl8GtJ8zn0rE8 zXBvjIr8fxREcpgxOvR1VUkRiD72Ya5Yf3Xi2ZmmcbRpI5KYGHgLxPe3KMR9nF+/ciAz 5mPwbuHMFKgWB3IQMSRPoLyUFmDBWentjn1rIHJWM/Jp0ryK38uj7X05US8LLc98zEss kzLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mxyW1onhXDiHAxxUJjBsSs0nMCqFkArlx/FPrMEURJM=; b=a2r/mew5MZ0E9OagGVLNvR8Io0brbo5j22rQpqzn5Pb4mmr5MzpP6r54G3UvN4Mw0q b7QvlxG5tc09945weqWAfWorxVQZuA0mHVRnGD7duEDDHTKBMxGjClf8H9rtHo+Pe+/6 JxLHW3K8yef5KiqsoJoaYaJjpJSIrT8COGUy6Lto0QblDLLkD7oIFovjJCatk0mxwv9L k1ACH/bumbfrUp+cFQfiaCpXuUVbpDZ6Yg5XTmq05+Pi2mH5A96X4TMFn6q7qV7PAqJR sUzSVX1u5/yGn4Rw6wO4Gvp6qEoFBZ4E0BBOqyqy3wIbewS5IrW8xj7rbVpjg/dDE9sp GtTw== X-Gm-Message-State: AOAM5323Hr+9+CqmuuyvhzOA0zxDrRLyuFkQyemZmBoE6wTRoK2cZMHe hpTA69USqGj7XXKlIYhaSMelxg== X-Received: by 2002:a17:906:4117:: with SMTP id j23mr4443860ejk.10.1615486203151; Thu, 11 Mar 2021 10:10:03 -0800 (PST) Received: from localhost.localdomain ([2a02:2454:3e3:5f00:8e01:34c:da50:eb7e]) by smtp.gmail.com with ESMTPSA id a22sm1741290ejr.89.2021.03.11.10.10.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 10:10:02 -0800 (PST) From: Robert Foss To: agross@kernel.org, bjorn.andersson@linaro.org, robert.foss@linaro.org, todor.too@gmail.com, mchehab@kernel.org, robh+dt@kernel.org, angelogioacchino.delregno@somainline.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , Sakari Ailus , Andrey Konovalov , Hans Verkuil Cc: Rob Herring , Tomasz Figa , Azam Sadiq Pasha Kapatrala Syed , Sarvesh Sridutt , Laurent Pinchart , Jonathan Marek , Nicolas Boichat Subject: [PATCH v7 03/22] media: camss: Replace trace_printk() with dev_dbg() Date: Thu, 11 Mar 2021 19:09:29 +0100 Message-Id: <20210311180948.268343-4-robert.foss@linaro.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20210311180948.268343-1-robert.foss@linaro.org> References: <20210311180948.268343-1-robert.foss@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org trace_printk() should not be used in production code, since extra memory is used for special buffers whenever trace_puts() is used. Replace it with dev_dbg() which provides all of the desired debugging functionality. Signed-off-by: Robert Foss Suggested-by: Nicolas Boichat Reviewed-by: Nicolas Boichat --- Changes since v3: - Nicolas: Create this patch Changes since v4: - Nicolas: Add r-b drivers/media/platform/qcom/camss/camss-vfe-4-1.c | 5 +++-- drivers/media/platform/qcom/camss/camss-vfe-4-7.c | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) -- 2.27.0 diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c index a1b56b89130d..85b9bcbc7321 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-1.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-1.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -936,8 +937,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe); diff --git a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c index 84c33b8f9fe3..f7e00a2de393 100644 --- a/drivers/media/platform/qcom/camss/camss-vfe-4-7.c +++ b/drivers/media/platform/qcom/camss/camss-vfe-4-7.c @@ -12,6 +12,7 @@ #include #include +#include "camss.h" #include "camss-vfe.h" #define VFE_0_HW_VERSION 0x000 @@ -1069,8 +1070,8 @@ static irqreturn_t vfe_isr(int irq, void *dev) vfe->ops->isr_read(vfe, &value0, &value1); - trace_printk("VFE: status0 = 0x%08x, status1 = 0x%08x\n", - value0, value1); + dev_dbg(vfe->camss->dev, "VFE: status0 = 0x%08x, status1 = 0x%08x\n", + value0, value1); if (value0 & VFE_0_IRQ_STATUS_0_RESET_ACK) vfe->isr_ops.reset_ack(vfe);