From patchwork Mon Mar 8 05:07:29 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 395338 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp1422548jai; Sun, 7 Mar 2021 21:10:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJymHI+8PG8HY8m5DQm4MpdoiK4S/mh77WmtelfxecYVc0EMzinORsbaZGmZTR5i8HJI7Lro X-Received: by 2002:a17:906:2dc1:: with SMTP id h1mr13519117eji.460.1615180225657; Sun, 07 Mar 2021 21:10:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1615180225; cv=none; d=google.com; s=arc-20160816; b=nVI6sx+YEPDbVrW2ZEt2VV0Ldz4VzLzfgKDDUi84fyIgGUcPW7c2XkXPVCfx9aUEQ0 rqb6G2lJmi8/BFIFi+C3w+8mQeJUyMNl9iM6JtP3gi1ryVm5VUPbpfcNOkQcJOFH5wwC mfBjo8zlX3o93GOg07Mz0gDxPc8tzQl+mkq5dI5vSiX94Fh4zWeU+wvVZhaYuCmZFixx fjmAwsQ8E0dcVDHVFI3j4GUMrPSyDubgLzH9hB/0ULNFav11Bnmy7XxbWJs0qKKoOVSn tzrGwLZ6NjVWa+z6dYDdprAPRnhYQGA14P2C5NAKbHnsfnrgADZNdJ/+/cIQYVzX1O1m 22mg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=UNoEYKDBGTzOJeT/EP06qqm1sw++l0u4ofBeIhu+mFQ=; b=mEkMVp7p45GbAX787+B3lx6zWrKGVu3nhSvulf8fLoY9Bfuvus4uXkkaPSlgyH4Enn FbboUNoMRrDe2oUSQCajZEzA0ITPEN9U8esFeWrAAIu8fOUwzB3xoKa7HOWpZzYGsR4F dFf796NPIPO8COEWumwaxuF8ATeCZ4/9BxvV7HHttr1DiUAAXbNFwzlOmqxRmL1LG2bQ 4Y3TmoWaXhpBY/h5BhD59LNgfcNs9Ku/MvMoU6m7RiDul06L4bQLJJYHST0Qjv/iKbn6 dFkF/E3STtsD4BuGhnQN5lq6V2QDNSQNliOoftS+FcS6RJVRdmYJbc3DDSNSTGgvMXUn 2P5A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kkGBMFqK; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dg23si6340931edb.519.2021.03.07.21.10.25; Sun, 07 Mar 2021 21:10:25 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=kkGBMFqK; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234358AbhCHFIt (ORCPT + 6 others); Mon, 8 Mar 2021 00:08:49 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:38072 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234334AbhCHFIW (ORCPT ); Mon, 8 Mar 2021 00:08:22 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 12858HoQ023656; Sun, 7 Mar 2021 23:08:17 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1615180097; bh=UNoEYKDBGTzOJeT/EP06qqm1sw++l0u4ofBeIhu+mFQ=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=kkGBMFqKaCMFT2cdpHYS0/xT5zBGCTDbhSo6LEzrSkC9V7HH13ml4JfETb/chMaB8 4R5oOnJ9aJZt3pMjoaLx/1lKSWz6frBGXKtCuJUYLJAFVuWEjEQl+N4g6EpbI63X63 QWMTfQ/ZvAocYTxcxpqQxOAtRO4Y/K48XjJsCgno= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 12858HH4068766 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 7 Mar 2021 23:08:17 -0600 Received: from DLEE110.ent.ti.com (157.170.170.21) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Sun, 7 Mar 2021 23:08:17 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE110.ent.ti.com (157.170.170.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Sun, 7 Mar 2021 23:08:17 -0600 Received: from a0393678-ssd.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 12857aL8086547; Sun, 7 Mar 2021 23:08:14 -0600 From: Kishon Vijay Abraham I To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Philipp Zabel , Swapnil Jakhade CC: , , Lokesh Vutla Subject: [PATCH v5 10/13] phy: cadence: cadence-sierra: Add missing clk_disable_unprepare() in .remove callback Date: Mon, 8 Mar 2021 10:37:29 +0530 Message-ID: <20210308050732.7140-11-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210308050732.7140-1-kishon@ti.com> References: <20210308050732.7140-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org commit 44d30d622821("phy: cadence: Add driver for Sierra PHY") enabled the clock in probe and failed to disable in remove callback. Add missing clk_disable_unprepare() in cdns_sierra_phy_remove(). Fixes: 44d30d622821("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-sierra.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.17.1 diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index a45278c30948..ac32b7b0289f 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -689,6 +689,9 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev) reset_control_assert(phy->phys[i].lnk_rst); reset_control_put(phy->phys[i].lnk_rst); } + + clk_disable_unprepare(phy->input_clks[PHY_CLK]); + return 0; }