From patchwork Thu Mar 4 04:41:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 392724 Delivered-To: patch@linaro.org Received: by 2002:a02:8562:0:0:0:0:0 with SMTP id g89csp348632jai; Thu, 4 Mar 2021 14:16:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/Wf9LFPJZppvE/qcStsQCYc1wsSGMYCITrx/xRZ5o3JBTu/bwmkIk2Bt/3BmC9CQeO//+ X-Received: by 2002:a17:907:10ce:: with SMTP id rv14mr6709799ejb.56.1614896187185; Thu, 04 Mar 2021 14:16:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614896187; cv=none; d=google.com; s=arc-20160816; b=ObauB5bMfWgFyUclrstuYYzBr8CV7Zb2djzbScPrZJKKrSATdPBTllQ+oV9f7uh2Is zlZ38t/82ZR4sk6CQrDJ7gHznr15TjPjc0VPXI1WH3hZVv21NiIpGs+uRE+pqcoOX5iR lMJNi+szsT2dN7Z119HzuEW4EBQ819N+3oW9Gh8EDo8pSPg9atTKDFnLqUiMGbep2ERP /HmdTH56b+2S9q7sUr7ifi2uVQYbHzGOM0nuOLPSgDptniov9r77BZ+BXWKxppQOu8bq D6qyvAFr1gW0Rj2n5v2gqtTC8mr1xRC2fFcOl3jeRoEIadSk3FuWVZ5oa4/Tymj9Rgte GhWA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=Fr9ZyGLW31JmJAp0IyWK9eWBsQt1ma4OyJ8An42gTxI=; b=Eod0YvLq9Cu3FGwSCughuPPwqDmLuyW/fGhLsUQ2fmyEwwCB6BZBHJsH/G8Z/qqO4y InGPRdewCN8DWkF45YyQIrK35kHn89SF05ExOxG54PlQxlsWRoOln8EnGNF+f2rd9UwV jKLimy89hKLUSc2+oRDRLA084u1nsbHEXS35/8l8TzYvpE+Rr9qh8hoI8/Qm0jj+UKlm KsZxnrKrRpqEu4fppJZ636PB64xIja6XuHtVC9STA6984z4jlXgsK2ovWUIwTxfSCwCv hRqEPh0Iexen4hJwFKZwbuKWasIn303C4SrbF2ztN1K/biSqbkb4TpbX+8gFMiTiHaVs U73g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=esapfHlQ; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k6si527757edj.545.2021.03.04.14.16.26; Thu, 04 Mar 2021 14:16:27 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=esapfHlQ; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233708AbhCDEn2 (ORCPT + 6 others); Wed, 3 Mar 2021 23:43:28 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:36700 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233635AbhCDEnA (ORCPT ); Wed, 3 Mar 2021 23:43:00 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 1244g5Xq101933; Wed, 3 Mar 2021 22:42:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1614832925; bh=Fr9ZyGLW31JmJAp0IyWK9eWBsQt1ma4OyJ8An42gTxI=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=esapfHlQBfFqGr+e/OZGX5imYLaE/2OdK4paWDCwmPQ8VlFrQx7Q6mB7xIo7SnwvF nO5UR/UVlwWF7DkRWm/I1sFwV4sBxtrLbm0Ne1lQPFVhv5Zt8bTqLxd3ih831lApw8 lSD27o05COqAYvoW5/7rqxptIrZUIlHhYGzawHIM= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 1244g5Eo016590 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 3 Mar 2021 22:42:05 -0600 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Wed, 3 Mar 2021 22:42:05 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Wed, 3 Mar 2021 22:42:05 -0600 Received: from a0393678-ssd.dhcp.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 1244fQfr042911; Wed, 3 Mar 2021 22:42:02 -0600 From: Kishon Vijay Abraham I To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Philipp Zabel , Swapnil Jakhade CC: , , Lokesh Vutla Subject: [PATCH v4 10/13] phy: cadence: cadence-sierra: Add missing clk_disable_unprepare() in .remove callback Date: Thu, 4 Mar 2021 10:11:19 +0530 Message-ID: <20210304044122.15166-11-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210304044122.15166-1-kishon@ti.com> References: <20210304044122.15166-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org commit 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") enabled the clock in probe and failed to disable in remove callback. Add missing clk_disable_unprepare() in cdns_sierra_phy_remove(). Fixes: 44d30d622821 ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I --- drivers/phy/cadence/phy-cadence-sierra.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.17.1 diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index a45278c30948..ac32b7b0289f 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -689,6 +689,9 @@ static int cdns_sierra_phy_remove(struct platform_device *pdev) reset_control_assert(phy->phys[i].lnk_rst); reset_control_put(phy->phys[i].lnk_rst); } + + clk_disable_unprepare(phy->input_clks[PHY_CLK]); + return 0; }