| Message ID | 20210107121754.3295-5-martin.kepplinger@puri.sm |
|---|---|
| State | Accepted |
| Commit | ad1abc8a03fdbc05b3390962b15287d4e7c5db22 |
| Headers | show |
| Series | imx8mq: updates for the interconnect fabric | expand |
On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: > Add interconnect ports for lcdif to set bus capabilities. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > --- > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > index 89e7de2e7f7a..9300be8c9b53 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > @@ -11,6 +11,7 @@ > #include "dt-bindings/input/input.h" > #include <dt-bindings/interrupt-controller/arm-gic.h> > #include <dt-bindings/thermal/thermal.h> > +#include <dt-bindings/interconnect/imx8mq.h> > #include "imx8mq-pinfunc.h" > > / { > @@ -522,6 +523,8 @@ > <&clk IMX8MQ_VIDEO_PLL1>, > <&clk IMX8MQ_VIDEO_PLL1_OUT>; > assigned-clock-rates = <0>, <0>, <0>, <594000000>; > + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; > + interconnect-names = "dram"; Hmm, two interconnect phandles but only one name? Shawn > status = "disabled"; > > port@0 { > -- > 2.20.1 >
On 15.01.21 10:47, Shawn Guo wrote: > On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: >> Add interconnect ports for lcdif to set bus capabilities. >> >> Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> >> --- >> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> index 89e7de2e7f7a..9300be8c9b53 100644 >> --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi >> @@ -11,6 +11,7 @@ >> #include "dt-bindings/input/input.h" >> #include <dt-bindings/interrupt-controller/arm-gic.h> >> #include <dt-bindings/thermal/thermal.h> >> +#include <dt-bindings/interconnect/imx8mq.h> >> #include "imx8mq-pinfunc.h" >> >> / { >> @@ -522,6 +523,8 @@ >> <&clk IMX8MQ_VIDEO_PLL1>, >> <&clk IMX8MQ_VIDEO_PLL1_OUT>; >> assigned-clock-rates = <0>, <0>, <0>, <594000000>; >> + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; >> + interconnect-names = "dram"; > > Hmm, two interconnect phandles but only one name? > Well it's one interconnect path that would more accurately be named "lcdif-dram" if that's what you mean. I removed "lcdif-" because it's the lcdif node, but maybe we should name it lcdif-dram after all. at least that's how others describe it. martin
On Fri, Jan 15, 2021 at 10:57:02AM +0100, Martin Kepplinger wrote: > > > On 15.01.21 10:47, Shawn Guo wrote: > > On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: > > > Add interconnect ports for lcdif to set bus capabilities. > > > > > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> > > > --- > > > arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > index 89e7de2e7f7a..9300be8c9b53 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi > > > @@ -11,6 +11,7 @@ > > > #include "dt-bindings/input/input.h" > > > #include <dt-bindings/interrupt-controller/arm-gic.h> > > > #include <dt-bindings/thermal/thermal.h> > > > +#include <dt-bindings/interconnect/imx8mq.h> > > > #include "imx8mq-pinfunc.h" > > > / { > > > @@ -522,6 +523,8 @@ > > > <&clk IMX8MQ_VIDEO_PLL1>, > > > <&clk IMX8MQ_VIDEO_PLL1_OUT>; > > > assigned-clock-rates = <0>, <0>, <0>, <594000000>; > > > + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; > > > + interconnect-names = "dram"; > > > > Hmm, two interconnect phandles but only one name? > > > > Well it's one interconnect path that would more accurately be named > "lcdif-dram" if that's what you mean. I removed "lcdif-" because it's the > lcdif node, but maybe we should name it lcdif-dram after all. at least > that's how others describe it. Ha, sorry, I misunderstood the interconnects property. Shawn
On Thu, Jan 07, 2021 at 01:17:53PM +0100, Martin Kepplinger wrote: > Add interconnect ports for lcdif to set bus capabilities. > > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> Applied, thanks.
diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi index 89e7de2e7f7a..9300be8c9b53 100644 --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi @@ -11,6 +11,7 @@ #include "dt-bindings/input/input.h" #include <dt-bindings/interrupt-controller/arm-gic.h> #include <dt-bindings/thermal/thermal.h> +#include <dt-bindings/interconnect/imx8mq.h> #include "imx8mq-pinfunc.h" / { @@ -522,6 +523,8 @@ <&clk IMX8MQ_VIDEO_PLL1>, <&clk IMX8MQ_VIDEO_PLL1_OUT>; assigned-clock-rates = <0>, <0>, <0>, <594000000>; + interconnects = <&noc IMX8MQ_ICM_LCDIF &noc IMX8MQ_ICS_DRAM>; + interconnect-names = "dram"; status = "disabled"; port@0 {
Add interconnect ports for lcdif to set bus capabilities. Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm> --- arch/arm64/boot/dts/freescale/imx8mq.dtsi | 3 +++ 1 file changed, 3 insertions(+)