| Message ID | 20201223172505.34736-5-wsa+renesas@sang-engineering.com |
|---|---|
| State | New |
| Headers | show |
| Series | v3u: enable I2C0-6 | expand |
Hi Wolfram, On Wed, Dec 23, 2020 at 6:25 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > [wsa: rebased] > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts > @@ -21,6 +21,34 @@ chosen { > }; > }; > > +&i2c0 { > + pinctrl-0 = <&i2c0_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > +}; > + > +&i2c1 { > + pinctrl-0 = <&i2c1_pins>; > + pinctrl-names = "default"; > + > + status = "okay"; > + clock-frequency = <400000>; > +}; > + > +&pfc { > + i2c0_pins: i2c0 { > + groups = "i2c0"; > + function = "i2c0"; > + }; > + > + i2c1_pins: i2c1 { > + groups = "i2c1"; > + function = "i2c1"; > + }; > +}; > + BTW, why not adding i2c6, which also has slave devices connected to it? > &rwdt { > timeout-sec = <60>; > status = "okay"; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Wolfram, On Wed, Dec 23, 2020 at 6:25 PM Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > From: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com> > [wsa: rebased] > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com> > --- > .../boot/dts/renesas/r8a779a0-falcon.dts | 28 +++++++++++++++++++ Shouldn't all of this be added to r8a779a0-falcon-cpu.dtsi instead of r8a779a0-falcon.dts? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts index fb9978ea18f4..7de3eed96ceb 100644 --- a/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts +++ b/arch/arm64/boot/dts/renesas/r8a779a0-falcon.dts @@ -21,6 +21,34 @@ chosen { }; }; +&i2c0 { + pinctrl-0 = <&i2c0_pins>; + pinctrl-names = "default"; + + status = "okay"; + clock-frequency = <400000>; +}; + +&i2c1 { + pinctrl-0 = <&i2c1_pins>; + pinctrl-names = "default"; + + status = "okay"; + clock-frequency = <400000>; +}; + +&pfc { + i2c0_pins: i2c0 { + groups = "i2c0"; + function = "i2c0"; + }; + + i2c1_pins: i2c1 { + groups = "i2c1"; + function = "i2c1"; + }; +}; + &rwdt { timeout-sec = <60>; status = "okay";