From patchwork Tue Dec 22 07:05:07 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kishon Vijay Abraham I X-Patchwork-Id: 346612 Delivered-To: patch@linaro.org Received: by 2002:a02:85a7:0:0:0:0:0 with SMTP id d36csp5095866jai; Mon, 21 Dec 2020 23:08:01 -0800 (PST) X-Google-Smtp-Source: ABdhPJzMPPTKc3y3VlbJrgUuzpUVUOV474urCGfqE7h2tWGW1EFBULH5k03uvq6nm5gcwq6oW9LY X-Received: by 2002:a17:906:a008:: with SMTP id p8mr5680510ejy.117.1608620881242; Mon, 21 Dec 2020 23:08:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1608620881; cv=none; d=google.com; s=arc-20160816; b=jV1Wb0yH24VdfOpkb98PXhsWOFI7W4lrlcUnesUh6pCSS+lu1orj/3kpIUSfz8IRnI gKD6F+nDGMswwe9HV0k5VafvjhGznTg10K+KIyD+krOaagPdyYfkwKcPA9r+EFMXraf4 P3KYnJTtLMW4uHh34ye6wAkxTXg+5sNIQdOhMw0+r6U6VCqtFrILb1j8hfcb2iew3N1I RHu7Pc/2SWoDLOFG73r6pu9xqrunfEJzObPR8ZvaL4cODweJbt1m/CEzZykCws4+cH/h ItBl4Kt0LgLkjvsOro/u80ONR9Vv0D6vq5r5OBgxyHNUSrUHsr4HWhbxHVx7ahuAzrIA Z80g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=HHTvmMjtTJRPNFpN3zkcx0PIiGXY1RMP1eK0a1ouBO4=; b=GO/YZyGb1jdW0NHBcnp2m/OGXRdN7VV1jk+qNGMwTlBgHnUVkXDVlJyGbz/55VEStJ LouqAwE+dpcs8zpnkgAZ+F9rSWtEj3TAZqGVkR/rBf3XpVerJNaiem9rdpCQlLoqfSQs GiNlvzuBuayKdi2f5PGz4D+MY5VFT0NhYhgEhgCyqnDYR5wfN+MYyDpnfUMSkYIbdEj8 s24EtDvjzmE6Rv8eFkCDRLLl6uqr+vmhU7zHT+LhzzuB1E4N8wmZOvXjlPFUPE5nZQtJ Sy4S5CikZ1ks5dmjy1LKbKFJ6Bb90Ub7PdhN1aMv1D8ujW3UCWRG2fttbOyOsTF3y/mR 6fEQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=aGAEk04v; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h4si1408831edf.490.2020.12.21.23.08.01; Mon, 21 Dec 2020 23:08:01 -0800 (PST) Received-SPF: pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=aGAEk04v; spf=pass (google.com: domain of devicetree-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=devicetree-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726413AbgLVHHS (ORCPT + 7 others); Tue, 22 Dec 2020 02:07:18 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:53844 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726396AbgLVHHR (ORCPT ); Tue, 22 Dec 2020 02:07:17 -0500 Received: from lelv0265.itg.ti.com ([10.180.67.224]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0BM75UJO064018; Tue, 22 Dec 2020 01:05:30 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1608620730; bh=HHTvmMjtTJRPNFpN3zkcx0PIiGXY1RMP1eK0a1ouBO4=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=aGAEk04v60w1DV9ToCDUcSTdb5TacFqifX2ky8qkVMtFrePrgzSzDVvnqAZm6sMrz RTq8jDtEle+Yg3A/g0f3+forpgz33cttvCa9F9l3gX1phah2abQxvEaQwjsAbbVkCQ d4y8rxDY4JQ2hlU+px4YBPd9xpzlG+pMr/a3pDos= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by lelv0265.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0BM75UFo014639 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 22 Dec 2020 01:05:30 -0600 Received: from DLEE114.ent.ti.com (157.170.170.25) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Tue, 22 Dec 2020 01:05:30 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE114.ent.ti.com (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Tue, 22 Dec 2020 01:05:30 -0600 Received: from a0393678-ssd.dal.design.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0BM75N7A050344; Tue, 22 Dec 2020 01:05:27 -0600 From: Kishon Vijay Abraham I To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Swapnil Jakhade , , , CC: Nishanth Menon , Philipp Zabel , Subject: [PATCH v2 01/14] phy: cadence: Sierra: Fix PHY power_on sequence Date: Tue, 22 Dec 2020 12:35:07 +0530 Message-ID: <20201222070520.28132-2-kishon@ti.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201222070520.28132-1-kishon@ti.com> References: <20201222070520.28132-1-kishon@ti.com> MIME-Version: 1.0 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Commit 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") de-asserts PHY_RESET even before the configurations are loaded in phy_init(). However PHY_RESET should be de-asserted only after all the configurations has been initialized, instead of de-asserting in probe. Fix it here. Fixes: 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") Signed-off-by: Kishon Vijay Abraham I Cc: # v5.4+ --- drivers/phy/cadence/phy-cadence-sierra.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) -- 2.17.1 diff --git a/drivers/phy/cadence/phy-cadence-sierra.c b/drivers/phy/cadence/phy-cadence-sierra.c index 26a0badabe38..19f32ae877b9 100644 --- a/drivers/phy/cadence/phy-cadence-sierra.c +++ b/drivers/phy/cadence/phy-cadence-sierra.c @@ -319,6 +319,12 @@ static int cdns_sierra_phy_on(struct phy *gphy) u32 val; int ret; + ret = reset_control_deassert(sp->phy_rst); + if (ret) { + dev_err(dev, "Failed to take the PHY out of reset\n"); + return ret; + } + /* Take the PHY lane group out of reset */ ret = reset_control_deassert(ins->lnk_rst); if (ret) { @@ -616,7 +622,6 @@ static int cdns_sierra_phy_probe(struct platform_device *pdev) pm_runtime_enable(dev); phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate); - reset_control_deassert(sp->phy_rst); return PTR_ERR_OR_ZERO(phy_provider); put_child: