| Message ID | 20201117220807.208747-4-krzk@kernel.org |
|---|---|
| State | Accepted |
| Commit | 15d4a6f736c446231907e9f04ce6fc4b57c32aa2 |
| Headers | show |
| Series | None | expand |
On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote: > Convert the Analog Devices ADM1275 bindings to dt-schema. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > --- > .../bindings/hwmon/adi,adm1275.yaml | 58 +++++++++++++++++++ > .../devicetree/bindings/hwmon/adm1275.txt | 25 -------- > Documentation/hwmon/adm1275.rst | 2 +- > 3 files changed, 59 insertions(+), 26 deletions(-) > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > new file mode 100644 > index 000000000000..2cad28c499dc > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > + > +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors > + > +maintainers: > + - Krzysztof Kozlowski <krzk@kernel.org> > + > +description: | > + The ADM1293 and ADM1294 are high accuracy integrated digital power monitors > + that offer digital current, voltage, and power monitoring using an on-chip, > + 12-bit analog-to-digital converter (ADC), communicated through a PMBus > + compliant I2C interface. > + > + Datasheets: > + https://www.analog.com/en/products/adm1294.html > + > +properties: > + compatible: > + enum: > + - adi,adm1075 > + - adi,adm1272 > + - adi,adm1275 > + - adi,adm1276 > + - adi,adm1278 > + - adi,adm1293 > + - adi,adm1294 > + > + reg: > + maxItems: 1 > + > + shunt-resistor-micro-ohms: > + description: > + Shunt resistor value in micro-Ohm. > + $ref: /schemas/types.yaml#/definitions/uint32 Don't need a type if you have units. With that dropped, Reviewed-by: Rob Herring <robh@kernel.org>
On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote: > On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote: > > Convert the Analog Devices ADM1275 bindings to dt-schema. > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > --- > > .../bindings/hwmon/adi,adm1275.yaml | 58 +++++++++++++++++++ > > .../devicetree/bindings/hwmon/adm1275.txt | 25 -------- > > Documentation/hwmon/adm1275.rst | 2 +- > > 3 files changed, 59 insertions(+), 26 deletions(-) > > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > > delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt > > > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > > new file mode 100644 > > index 000000000000..2cad28c499dc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > > @@ -0,0 +1,58 @@ > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > + > > +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors > > + > > +maintainers: > > + - Krzysztof Kozlowski <krzk@kernel.org> > > + > > +description: | > > + The ADM1293 and ADM1294 are high accuracy integrated digital power monitors > > + that offer digital current, voltage, and power monitoring using an on-chip, > > + 12-bit analog-to-digital converter (ADC), communicated through a PMBus > > + compliant I2C interface. > > + > > + Datasheets: > > + https://www.analog.com/en/products/adm1294.html > > + > > +properties: > > + compatible: > > + enum: > > + - adi,adm1075 > > + - adi,adm1272 > > + - adi,adm1275 > > + - adi,adm1276 > > + - adi,adm1278 > > + - adi,adm1293 > > + - adi,adm1294 > > + > > + reg: > > + maxItems: 1 > > + > > + shunt-resistor-micro-ohms: > > + description: > > + Shunt resistor value in micro-Ohm. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > Don't need a type if you have units. With that dropped, > Sorry, I am not familiar with the terminology. Does that refer to the '$ref' line ? Thanks, Guenter
On Mon, Dec 07, 2020 at 04:19:16PM -0800, Guenter Roeck wrote: > On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote: > > On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote: > > > Convert the Analog Devices ADM1275 bindings to dt-schema. > > > > > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > > > --- > > > .../bindings/hwmon/adi,adm1275.yaml | 58 +++++++++++++++++++ > > > .../devicetree/bindings/hwmon/adm1275.txt | 25 -------- > > > Documentation/hwmon/adm1275.rst | 2 +- > > > 3 files changed, 59 insertions(+), 26 deletions(-) > > > create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > > > delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt > > > > > > diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > > > new file mode 100644 > > > index 000000000000..2cad28c499dc > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml > > > @@ -0,0 +1,58 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > + > > > +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors > > > + > > > +maintainers: > > > + - Krzysztof Kozlowski <krzk@kernel.org> > > > + > > > +description: | > > > + The ADM1293 and ADM1294 are high accuracy integrated digital power monitors > > > + that offer digital current, voltage, and power monitoring using an on-chip, > > > + 12-bit analog-to-digital converter (ADC), communicated through a PMBus > > > + compliant I2C interface. > > > + > > > + Datasheets: > > > + https://www.analog.com/en/products/adm1294.html > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - adi,adm1075 > > > + - adi,adm1272 > > > + - adi,adm1275 > > > + - adi,adm1276 > > > + - adi,adm1278 > > > + - adi,adm1293 > > > + - adi,adm1294 > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > + shunt-resistor-micro-ohms: > > > + description: > > > + Shunt resistor value in micro-Ohm. > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > Don't need a type if you have units. With that dropped, > > > > Sorry, I am not familiar with the terminology. Does that refer to > the '$ref' line ? Yes, it's the $ref line which can be safely removed. The core dt-schema applies such $ref if the property name ends with '-micro-ohms'. Best regards, Krzysztof
On 12/8/20 12:13 AM, Krzysztof Kozlowski wrote: > On Mon, Dec 07, 2020 at 04:19:16PM -0800, Guenter Roeck wrote: >> On Mon, Dec 07, 2020 at 03:12:59PM -0600, Rob Herring wrote: >>> On Tue, Nov 17, 2020 at 11:08:07PM +0100, Krzysztof Kozlowski wrote: >>>> Convert the Analog Devices ADM1275 bindings to dt-schema. >>>> >>>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> >>>> --- >>>> .../bindings/hwmon/adi,adm1275.yaml | 58 +++++++++++++++++++ >>>> .../devicetree/bindings/hwmon/adm1275.txt | 25 -------- >>>> Documentation/hwmon/adm1275.rst | 2 +- >>>> 3 files changed, 59 insertions(+), 26 deletions(-) >>>> create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml >>>> delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt >>>> >>>> diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml >>>> new file mode 100644 >>>> index 000000000000..2cad28c499dc >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml >>>> @@ -0,0 +1,58 @@ >>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >>>> +%YAML 1.2 >>>> +--- >>>> + >>>> +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml# >>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# >>>> + >>>> +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors >>>> + >>>> +maintainers: >>>> + - Krzysztof Kozlowski <krzk@kernel.org> >>>> + >>>> +description: | >>>> + The ADM1293 and ADM1294 are high accuracy integrated digital power monitors >>>> + that offer digital current, voltage, and power monitoring using an on-chip, >>>> + 12-bit analog-to-digital converter (ADC), communicated through a PMBus >>>> + compliant I2C interface. >>>> + >>>> + Datasheets: >>>> + https://www.analog.com/en/products/adm1294.html >>>> + >>>> +properties: >>>> + compatible: >>>> + enum: >>>> + - adi,adm1075 >>>> + - adi,adm1272 >>>> + - adi,adm1275 >>>> + - adi,adm1276 >>>> + - adi,adm1278 >>>> + - adi,adm1293 >>>> + - adi,adm1294 >>>> + >>>> + reg: >>>> + maxItems: 1 >>>> + >>>> + shunt-resistor-micro-ohms: >>>> + description: >>>> + Shunt resistor value in micro-Ohm. >>>> + $ref: /schemas/types.yaml#/definitions/uint32 >>> >>> Don't need a type if you have units. With that dropped, >>> >> >> Sorry, I am not familiar with the terminology. Does that refer to >> the '$ref' line ? > > Yes, it's the $ref line which can be safely removed. The core dt-schema > applies such $ref if the property name ends with '-micro-ohms'. > Thanks a lot for the information. Ill apply the patch with this line removed. Thanks, Guenter
diff --git a/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml new file mode 100644 index 000000000000..2cad28c499dc --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml @@ -0,0 +1,58 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- + +$id: http://devicetree.org/schemas/hwmon/adi,adm1275.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices ADM1075/ADM127x/ADM129x digital power monitors + +maintainers: + - Krzysztof Kozlowski <krzk@kernel.org> + +description: | + The ADM1293 and ADM1294 are high accuracy integrated digital power monitors + that offer digital current, voltage, and power monitoring using an on-chip, + 12-bit analog-to-digital converter (ADC), communicated through a PMBus + compliant I2C interface. + + Datasheets: + https://www.analog.com/en/products/adm1294.html + +properties: + compatible: + enum: + - adi,adm1075 + - adi,adm1272 + - adi,adm1275 + - adi,adm1276 + - adi,adm1278 + - adi,adm1293 + - adi,adm1294 + + reg: + maxItems: 1 + + shunt-resistor-micro-ohms: + description: + Shunt resistor value in micro-Ohm. + $ref: /schemas/types.yaml#/definitions/uint32 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + power-sensor@10 { + compatible = "adi,adm1272"; + reg = <0x10>; + shunt-resistor-micro-ohms = <500>; + }; + }; diff --git a/Documentation/devicetree/bindings/hwmon/adm1275.txt b/Documentation/devicetree/bindings/hwmon/adm1275.txt deleted file mode 100644 index 1ecd03f3da4d..000000000000 --- a/Documentation/devicetree/bindings/hwmon/adm1275.txt +++ /dev/null @@ -1,25 +0,0 @@ -adm1275 properties - -Required properties: -- compatible: Must be one of the supported compatible strings: - - "adi,adm1075" for adm1075 - - "adi,adm1272" for adm1272 - - "adi,adm1275" for adm1275 - - "adi,adm1276" for adm1276 - - "adi,adm1278" for adm1278 - - "adi,adm1293" for adm1293 - - "adi,adm1294" for adm1294 -- reg: I2C address - -Optional properties: - -- shunt-resistor-micro-ohms - Shunt resistor value in micro-Ohm - -Example: - -adm1272@10 { - compatible = "adi,adm1272"; - reg = <0x10>; - shunt-resistor-micro-ohms = <500>; -}; diff --git a/Documentation/hwmon/adm1275.rst b/Documentation/hwmon/adm1275.rst index ce6528f90e4a..804590eeabdc 100644 --- a/Documentation/hwmon/adm1275.rst +++ b/Documentation/hwmon/adm1275.rst @@ -83,7 +83,7 @@ or current scaling. Reported voltages, currents, and power are raw measurements, and will typically have to be scaled. The shunt value in micro-ohms can be set via device tree at compile-time. Please -refer to the Documentation/devicetree/bindings/hwmon/adm1275.txt for bindings +refer to the Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml for bindings if the device tree is used. Platform data support
Convert the Analog Devices ADM1275 bindings to dt-schema. Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> --- .../bindings/hwmon/adi,adm1275.yaml | 58 +++++++++++++++++++ .../devicetree/bindings/hwmon/adm1275.txt | 25 -------- Documentation/hwmon/adm1275.rst | 2 +- 3 files changed, 59 insertions(+), 26 deletions(-) create mode 100644 Documentation/devicetree/bindings/hwmon/adi,adm1275.yaml delete mode 100644 Documentation/devicetree/bindings/hwmon/adm1275.txt